From 0951b442aefdf35c4c1049fd8cd826c63be02158 Mon Sep 17 00:00:00 2001 From: mlemanczyk Date: Sun, 30 Apr 2023 21:42:06 +0200 Subject: [PATCH] Compilation warnings resolved --- .../Benchmarks/Count.cs | 6 +++--- .../Benchmarks/GetItem..cs | 12 ++++++------ .../Benchmarks/LongCount.cs | 4 ++-- .../Benchmarks/RecyclableCollections.Benchmarks.cs | 8 ++++---- .../Benchmarks/SetItem.cs | 4 ++-- .../RecyclableListPoc.Benchmarks.EnsureCapacity.cs | 2 +- Recyclable.Collections/RecyclableSortedList.cs | 2 +- 7 files changed, 19 insertions(+), 19 deletions(-) diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Count.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Count.cs index d5286c5..1803de3 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Count.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Count.cs @@ -8,7 +8,7 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = false)] public void Array_Count() { - var data = _testArray; + var data = TestObjects; DoNothing(data.Length); } @@ -22,7 +22,7 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = true)] public void PooledList_Count() { - var data = _testPooledList; + var data = TestObjectsAsPooledList; DoNothing(data.Count); } @@ -36,7 +36,7 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = false)] public void RecyclableList_Count() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; DoNothing(data.Count); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs b/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs index db56607..27006d4 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs @@ -29,7 +29,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = true)] public void PooledList_GetItem() { - var data = _testPooledList; + var data = TestObjectsAsPooledList; var dataCount = TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -51,7 +51,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = false)] public void RecyclableList_GetItem() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; var dataCount = TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -62,7 +62,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = false)] public void RecyclableList_GetItem_AsSpan() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; int blockSize = data.BlockSize; int nextItemBlockIndex = data.NextItemBlockIndex; @@ -90,7 +90,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = false)] public void RecyclableList_GetItem_AsArray() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; int blockSize = data.BlockSize; int nextItemBlockIndex = data.NextItemBlockIndex; @@ -118,7 +118,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = false)] public void RecyclableList_GetItem_AsForEach() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; var dataCount = TestObjectCount; foreach (var item in data) @@ -130,7 +130,7 @@ namespace Recyclable.Collections.Benchmarks [Benchmark(Baseline = false)] public void RecyclableList_GetItem_AsWhile() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; long dataCount = TestObjectCount; if (dataCount == 0) { diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/LongCount.cs b/Recyclable.Collections.Benchmarks/Benchmarks/LongCount.cs index f9a2813..e299491 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/LongCount.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/LongCount.cs @@ -7,14 +7,14 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = false)] public void Array_LongCount() { - var data = _testArray; + var data = TestObjects; DoNothing(data.LongLength); } //[Benchmark(Baseline = false)] public void RecyclableList_LongCount() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; DoNothing(data.LongCount); } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs b/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs index 2d501c6..a927053 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs @@ -6,10 +6,10 @@ namespace Recyclable.Collections.Benchmarks [MemoryDiagnoser] public partial class RecyclableCollectionsBenchmarks : BenchmarkBase { - private long[] _testArray; - private RecyclableArrayList _testRecyclableArrayList; - private RecyclableList _testRecyclableList; - private PooledList _testPooledList; + private long[]? _testArray; + private RecyclableArrayList? _testRecyclableArrayList; + private RecyclableList? _testRecyclableList; + private PooledList? _testPooledList; public PooledList TestObjectsAsPooledList => _testPooledList ?? throw new NullReferenceException("Something is wrong and the field is not initialized"); diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/SetItem.cs b/Recyclable.Collections.Benchmarks/Benchmarks/SetItem.cs index 54dc577..ce4eaef 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/SetItem.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/SetItem.cs @@ -31,7 +31,7 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = true)] public void PooledList_SetItem() { - var data = _testPooledList; + var data = TestObjectsAsPooledList; var dataCount = TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -53,7 +53,7 @@ namespace Recyclable.Collections.Benchmarks //[Benchmark(Baseline = false)] public void RecyclableList_SetItem() { - var data = _testRecyclableList; + var data = TestObjectsAsRecyclableList; var dataCount = TestObjectCount; for (var i = 0; i < dataCount; i++) { diff --git a/Recyclable.Collections.Benchmarks/POC/RecyclableListPoc.Benchmarks.EnsureCapacity.cs b/Recyclable.Collections.Benchmarks/POC/RecyclableListPoc.Benchmarks.EnsureCapacity.cs index 1732974..5f4ebe2 100644 --- a/Recyclable.Collections.Benchmarks/POC/RecyclableListPoc.Benchmarks.EnsureCapacity.cs +++ b/Recyclable.Collections.Benchmarks/POC/RecyclableListPoc.Benchmarks.EnsureCapacity.cs @@ -1277,7 +1277,7 @@ namespace Recyclable.Collections.Benchmarks.POC _blockSizePow2Shift = (byte)(31 - BitOperations.LeadingZeroCount((uint)minBlockSize)); _capacity = Resize(this, minBlockSize, _blockSizePow2Shift, expectedItemsCount.Value); - if (_memoryBlocks?.Length > 0 && minBlockSize != _memoryBlocks[0].Length) + if (_memoryBlocks!.Length > 0 && minBlockSize != _memoryBlocks[0].Length) { _blockSize = _memoryBlocks[0].Length; _blockSizePow2Shift = (byte)(31 - BitOperations.LeadingZeroCount((uint)minBlockSize)); diff --git a/Recyclable.Collections/RecyclableSortedList.cs b/Recyclable.Collections/RecyclableSortedList.cs index ee807e2..1c64e82 100644 --- a/Recyclable.Collections/RecyclableSortedList.cs +++ b/Recyclable.Collections/RecyclableSortedList.cs @@ -38,7 +38,7 @@ public void BeginUpdate() => _isUpdating++; - public void Clear() + public new void Clear() { BeginUpdate(); try