From 15614de8a43b78722e0d0f2cd3ffb0171ad31aa2 Mon Sep 17 00:00:00 2001 From: mlemanczyk Date: Sun, 11 Jun 2023 22:02:55 +0200 Subject: [PATCH] BaselineBenchmarkType / BenchmarkType renamed to BaseDataType / DataType --- .../RecyclableCollections.Benchmarks.cs | 8 ++++---- .../POC/BoolOrComparePoc.Benchmarks.cs | 2 +- .../POC/DelegateVsComparerPoc.Benchmarks.cs | 4 ++-- .../POC/PocBenchmarkBase.cs | 20 +++++++++---------- .../POC/RecyclableLongListPoc.Benchmarks.cs | 6 +++--- .../POC/RoundBenchmarks.cs | 4 ++-- .../POC/SpanVsArrayBenchmarks.cs | 4 ++-- .../POC/WhenParallelSearchBenchmarks.cs | 6 +++--- 8 files changed, 27 insertions(+), 27 deletions(-) diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs b/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs index b741a94..c8560c2 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs @@ -17,8 +17,8 @@ namespace Recyclable.Collections.Benchmarks public RecyclableCollectionsBenchmarks() : base() { TestObjectCount = 1; - BaselineBenchmarkType = RecyclableCollectionsBenchmarkSource.List; - BenchmarkType = RecyclableCollectionsBenchmarkSource.RecyclableLongList; + BaseDataType = RecyclableCollectionsBenchmarkSource.List; + DataType = RecyclableCollectionsBenchmarkSource.RecyclableLongList; } [Params @@ -54,7 +54,7 @@ namespace Recyclable.Collections.Benchmarks ( RecyclableCollectionsBenchmarkSource.List )] - public override RecyclableCollectionsBenchmarkSource BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override RecyclableCollectionsBenchmarkSource BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } [Params ( @@ -64,7 +64,7 @@ namespace Recyclable.Collections.Benchmarks RecyclableCollectionsBenchmarkSource.RecyclableList, RecyclableCollectionsBenchmarkSource.RecyclableLongList )] - public override RecyclableCollectionsBenchmarkSource BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override RecyclableCollectionsBenchmarkSource DataType { get => base.DataType; set => base.DataType = value; } protected override Action? GetTestMethod(RecyclableCollectionsBenchmarkSource benchmarkType) => (Action?) GetType().GetMethod($"{benchmarkType}_{TestCase}", BindingFlags.Instance | BindingFlags.Public)?.CreateDelegate(typeof(Action), this) diff --git a/Recyclable.Collections.Benchmarks/POC/BoolOrComparePoc.Benchmarks.cs b/Recyclable.Collections.Benchmarks/POC/BoolOrComparePoc.Benchmarks.cs index ea60943..755b2a0 100644 --- a/Recyclable.Collections.Benchmarks/POC/BoolOrComparePoc.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/BoolOrComparePoc.Benchmarks.cs @@ -12,7 +12,7 @@ namespace Recyclable.Collections.Benchmarks.POC public class BoolOrComparePocBenchmarks : PocBenchmarkBase { [Params(BoolOrComparePocBenchmarkType.Bool, BoolOrComparePocBenchmarkType.Compare)] - public override BoolOrComparePocBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override BoolOrComparePocBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } [Params(8)] public override int TestObjectCount { get => base.TestObjectCount; set => base.TestObjectCount = value; } diff --git a/Recyclable.Collections.Benchmarks/POC/DelegateVsComparerPoc.Benchmarks.cs b/Recyclable.Collections.Benchmarks/POC/DelegateVsComparerPoc.Benchmarks.cs index c926998..11a2a5f 100644 --- a/Recyclable.Collections.Benchmarks/POC/DelegateVsComparerPoc.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/DelegateVsComparerPoc.Benchmarks.cs @@ -38,10 +38,10 @@ namespace Recyclable.Collections.Benchmarks.POC DelegateVsComparerPocBenchmarkType.ListOfUnboxedStructs, DelegateVsComparerPocBenchmarkType.StaticFunc )] - public override DelegateVsComparerPocBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override DelegateVsComparerPocBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } [Params(DelegateVsComparerPocBenchmarkType.Comparer)] - public override DelegateVsComparerPocBenchmarkType BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override DelegateVsComparerPocBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } #region Dummy classes diff --git a/Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs b/Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs index 03805e5..5e8f2f3 100644 --- a/Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs +++ b/Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs @@ -6,8 +6,8 @@ namespace Recyclable.Collections.Benchmarks.POC { public abstract class PocBenchmarkBase { - public virtual TBenchmarkType? BenchmarkType { get; set; } - public virtual TBenchmarkType? BaselineBenchmarkType { get; set; } + public virtual TBenchmarkType? DataType { get; set; } + public virtual TBenchmarkType? BaseDataType { get; set; } private Action? _testMethod; protected Action TestMethod @@ -96,23 +96,23 @@ namespace Recyclable.Collections.Benchmarks.POC [GlobalSetup] public virtual void Setup() { - Console.WriteLine($"******* SETTING UP TEST CASE FOR BENCHMARK {{{BenchmarkType}}} *******"); + Console.WriteLine($"******* SETTING UP TEST CASE FOR BENCHMARK {{{DataType}}} *******"); - if (!EqualityComparer.Default.Equals(BaselineBenchmarkType, default)) + if (!EqualityComparer.Default.Equals(BaseDataType, default)) { Console.WriteLine("******* SETTING UP BASELINE DATA *******"); - PrepareData(BaselineBenchmarkType); - _baselineMethod = GetTestMethod(BaselineBenchmarkType); + PrepareData(BaseDataType); + _baselineMethod = GetTestMethod(BaseDataType); } //~ We don't want to prepare data if baseline data is the same is benchmark data. //~ One would override another - waste of time & resources. - if (!EqualityComparer.Default.Equals(BaselineBenchmarkType, BenchmarkType)) + if (!EqualityComparer.Default.Equals(BaseDataType, DataType)) { Console.WriteLine("******* SETTING UP TEST CASE DATA *******"); - //~ If BaselineBenchmarkType == null, then we'll come here only if BaselineBenchmarkType != null. - PrepareData(BenchmarkType!); - _testMethod = GetTestMethod(BenchmarkType); + //~ If BaseDataType == null, then we'll come here only if DataType != null. + PrepareData(DataType!); + _testMethod = GetTestMethod(DataType); } Console.WriteLine("******* DATA PREPARED *******"); diff --git a/Recyclable.Collections.Benchmarks/POC/RecyclableLongListPoc.Benchmarks.cs b/Recyclable.Collections.Benchmarks/POC/RecyclableLongListPoc.Benchmarks.cs index 0a067a8..a7fb2b6 100644 --- a/Recyclable.Collections.Benchmarks/POC/RecyclableLongListPoc.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/RecyclableLongListPoc.Benchmarks.cs @@ -23,11 +23,11 @@ namespace Recyclable.Collections.Benchmarks.POC public partial class RecyclableLongListPocBenchmarks : PocBenchmarkBase { [Params(RecyclableLongListPocBenchmarkType.IndexOf)] - public override RecyclableLongListPocBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override RecyclableLongListPocBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } // [Params(BenchmarkType.Array, BenchmarkType.List, BenchmarkType.RecyclableList, BenchmarkType.RecyclableLongList)] [Params(RecyclableLongListPocBenchmarkType.IndexOf_PooledList)] - public override RecyclableLongListPocBenchmarkType BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override RecyclableLongListPocBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } private long[]? _testArray; public long[] TestObjects => _testArray ?? throw new NullReferenceException("Something is wrong and test objects are null"); @@ -131,7 +131,7 @@ namespace Recyclable.Collections.Benchmarks.POC { base.PrepareData(benchmarkType); - switch (BenchmarkType) + switch (DataType) { case RecyclableLongListPocBenchmarkType.IndexOfV1: _testRecyclableLongListIndexOfV1 = new(TestObjects, BlockSize, expectedItemsCount: TestObjectCount); diff --git a/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs index d3b8223..1aa35b4 100644 --- a/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs @@ -12,10 +12,10 @@ namespace Recyclable.Collections.Benchmarks.POC public class RoundBenchmarks : PocBenchmarkBase { [Params(RoundBenchmarkType.MathFloor)] - public override RoundBenchmarkType BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override RoundBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } [Params(RoundBenchmarkType.MathRound, RoundBenchmarkType.WithTypecasting)] - public override RoundBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override RoundBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } private const double OptimalParallelSearchStep = 0.329; diff --git a/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs index b270c14..3a45b2c 100644 --- a/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs @@ -21,11 +21,11 @@ namespace Recyclable.Collections.Benchmarks.POC SpanVsArrayBenchmarkType.ArrayGetWithVar, SpanVsArrayBenchmarkType.SpanGet, SpanVsArrayBenchmarkType.ArraySetWithField, SpanVsArrayBenchmarkType.ArraySetWithVar, SpanVsArrayBenchmarkType.SpanSet )] - public override SpanVsArrayBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override SpanVsArrayBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } [Params(SpanVsArrayBenchmarkType.ArrayGetWithField)] // [Params(SpanVsArrayBenchmarkType.ArraySetWithField)] - public override SpanVsArrayBenchmarkType BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override SpanVsArrayBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } protected override Action GetTestMethod(SpanVsArrayBenchmarkType benchmarkType) => benchmarkType switch { diff --git a/Recyclable.Collections.Benchmarks/POC/WhenParallelSearchBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/WhenParallelSearchBenchmarks.cs index b2b3e4a..397b59c 100644 --- a/Recyclable.Collections.Benchmarks/POC/WhenParallelSearchBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/WhenParallelSearchBenchmarks.cs @@ -83,10 +83,10 @@ namespace Recyclable.Collections.Benchmarks.POC public object? ItemToFind { get; set; } [Params(WhenParallelSearchBenchmarkType.IndexOfParallel)] - public override WhenParallelSearchBenchmarkType BenchmarkType { get => base.BenchmarkType; set => base.BenchmarkType = value; } + public override WhenParallelSearchBenchmarkType DataType { get => base.DataType; set => base.DataType = value; } [Params(WhenParallelSearchBenchmarkType.IndexOfSequentially)] - public override WhenParallelSearchBenchmarkType BaselineBenchmarkType { get => base.BaselineBenchmarkType; set => base.BaselineBenchmarkType = value; } + public override WhenParallelSearchBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } private long DoLongIndexOfSequentially() { @@ -304,7 +304,7 @@ namespace Recyclable.Collections.Benchmarks.POC ItemToFind ??= _testData.Last(); } - protected override Action? GetTestMethod(WhenParallelSearchBenchmarkType benchmarkType) => BenchmarkType switch + protected override Action? GetTestMethod(WhenParallelSearchBenchmarkType benchmarkType) => DataType switch { WhenParallelSearchBenchmarkType.IndexOfSequentially => IndexOfSequentially, WhenParallelSearchBenchmarkType.IndexOfParallel => IndexOfParallel,