RecyclableList.Enumerator performance improvements to match List<T>'s performance. Dirty state.

Recyclable.Collections.Benchmarks/Benchmarks/ForEach.cs

@@ -0,0 +1,45 @@
+namespace Recyclable.Collections.Benchmarks
+{
+	public partial class RecyclableCollectionsBenchmarks
+	{
+		public void Array_ForEach()
+		{
+			foreach (var item in TestObjects)
+			{
+				DoNothing(item);
+			}
+		}
+
+		public void List_ForEach()
+		{
+			foreach (var item in TestObjectsAsList)
+			{
+				DoNothing(item);
+			}
+		}
+
+		public void PooledList_ForEach()
+		{
+			foreach (var item in TestObjectsAsPooledList)
+			{
+				DoNothing(item);
+			}
+		}
+
+		public void RecyclableList_ForEach()
+		{
+			foreach (var item in TestObjectsAsRecyclableList)
+			{
+				DoNothing(item);
+			}
+		}
+
+		public void RecyclableLongList_ForEach()
+		{
+			foreach (var item in TestObjectsAsRecyclableLongList)
+			{
+				DoNothing(item);
+			}
+		}
+	}
+}

Recyclable.Collections.Benchmarks/Benchmarks/RecyclableCollections.Benchmarks.cs

@@ -5,9 +5,9 @@ namespace Recyclable.Collections.Benchmarks
 {
 	public enum RecyclableCollectionsBenchmarkType
 	{
-		Add_WithCapacity, Add, AddRange_WithCapacity, AddRangeWhenSourceIsArray, AddRangeWhenSourceIsIEnumerable,
+		Unknown, Add_WithCapacity, Add, AddRange_WithCapacity, AddRangeWhenSourceIsArray, AddRangeWhenSourceIsIEnumerable,
 		AddRangeWhenSourceIsIList, AddRangeWhenSourceIsList, AddRangeWhenSourceIsSameType, Contains_FirstItems,
-		Contains_LastItems, Count, Create_WithCapacity, Create, GetItem, IndexOf_BestAndWorstCases, IndexOf_FirstItems,
+		Contains_LastItems, Count, Create_WithCapacity, Create, ForEach, GetItem, IndexOf_BestAndWorstCases, IndexOf_FirstItems,
 		IndexOf_LastItems, LongCount, Remove_FirstItems, Remove_LastItems, RemoveAt_FirstItems, RemoveAt_LastItems,
 		SetItem,
 	}
@@ -17,52 +17,53 @@ namespace Recyclable.Collections.Benchmarks
 		public RecyclableCollectionsBenchmarks() : base()
 		{
 			TestObjectCount = 1;
-			BaseDataType = RecyclableCollectionsBenchmarkSource.List;
-			DataType = RecyclableCollectionsBenchmarkSource.RecyclableLongList;
+			//BaseDataType = RecyclableCollectionsBenchmarkSource.List;
+			DataType = RecyclableCollectionsBenchmarkSource.RecyclableList;
 		}
 
 		[Params
 		(
-			RecyclableCollectionsBenchmarkType.Add_WithCapacity,
-			RecyclableCollectionsBenchmarkType.Add,
-			RecyclableCollectionsBenchmarkType.AddRange_WithCapacity,
-			RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsArray,
-			RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsIEnumerable,
-			RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsIList,
-			RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsList,
-			RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsSameType,
-			RecyclableCollectionsBenchmarkType.Contains_FirstItems,
-			RecyclableCollectionsBenchmarkType.Contains_LastItems,
-			RecyclableCollectionsBenchmarkType.Count,
-			RecyclableCollectionsBenchmarkType.Create_WithCapacity,
-			RecyclableCollectionsBenchmarkType.Create,
-			RecyclableCollectionsBenchmarkType.GetItem,
-			RecyclableCollectionsBenchmarkType.IndexOf_BestAndWorstCases,
-			RecyclableCollectionsBenchmarkType.IndexOf_FirstItems,
-			RecyclableCollectionsBenchmarkType.IndexOf_LastItems,
-			RecyclableCollectionsBenchmarkType.LongCount,
-			RecyclableCollectionsBenchmarkType.Remove_FirstItems,
-			RecyclableCollectionsBenchmarkType.Remove_LastItems,
-			RecyclableCollectionsBenchmarkType.RemoveAt_FirstItems,
-			RecyclableCollectionsBenchmarkType.RemoveAt_LastItems,
-			RecyclableCollectionsBenchmarkType.SetItem
+			//RecyclableCollectionsBenchmarkType.Add_WithCapacity,
+			//RecyclableCollectionsBenchmarkType.Add,
+			//RecyclableCollectionsBenchmarkType.AddRange_WithCapacity,
+			//RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsArray,
+			//RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsIEnumerable,
+			//RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsIList,
+			//RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsList,
+			//RecyclableCollectionsBenchmarkType.AddRangeWhenSourceIsSameType,
+			//RecyclableCollectionsBenchmarkType.Contains_FirstItems,
+			//RecyclableCollectionsBenchmarkType.Contains_LastItems,
+			//RecyclableCollectionsBenchmarkType.Count,
+			//RecyclableCollectionsBenchmarkType.Create_WithCapacity,
+			//RecyclableCollectionsBenchmarkType.Create,
+			RecyclableCollectionsBenchmarkType.ForEach
+			//RecyclableCollectionsBenchmarkType.GetItem,
+			//RecyclableCollectionsBenchmarkType.IndexOf_BestAndWorstCases,
+			//RecyclableCollectionsBenchmarkType.IndexOf_FirstItems,
+			//RecyclableCollectionsBenchmarkType.IndexOf_LastItems,
+			//RecyclableCollectionsBenchmarkType.LongCount,
+			//RecyclableCollectionsBenchmarkType.Remove_FirstItems,
+			//RecyclableCollectionsBenchmarkType.Remove_LastItems,
+			//RecyclableCollectionsBenchmarkType.RemoveAt_FirstItems,
+			//RecyclableCollectionsBenchmarkType.RemoveAt_LastItems,
+			//RecyclableCollectionsBenchmarkType.SetItem
 		)]
 
 		public RecyclableCollectionsBenchmarkType TestCase { get; set; } = RecyclableCollectionsBenchmarkType.IndexOf_BestAndWorstCases;
 
-		[Params
-		(
-			RecyclableCollectionsBenchmarkSource.List
-		)]
+		//[Params
+		//(
+		//	RecyclableCollectionsBenchmarkSource.List
+		//)]
 		public override RecyclableCollectionsBenchmarkSource BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; }
 
 		[Params
 		(
-			RecyclableCollectionsBenchmarkSource.Array,
-			RecyclableCollectionsBenchmarkSource.List,
-			RecyclableCollectionsBenchmarkSource.PooledList,
-			RecyclableCollectionsBenchmarkSource.RecyclableList,
-			RecyclableCollectionsBenchmarkSource.RecyclableLongList
+			//RecyclableCollectionsBenchmarkSource.Array,
+			//RecyclableCollectionsBenchmarkSource.List,
+			//RecyclableCollectionsBenchmarkSource.PooledList,
+			RecyclableCollectionsBenchmarkSource.RecyclableList
+			//RecyclableCollectionsBenchmarkSource.RecyclableLongList
 		)]
 		public override RecyclableCollectionsBenchmarkSource DataType { get => base.DataType; set => base.DataType = value; }
 

Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs

@@ -50,7 +50,7 @@ namespace Recyclable.Collections.Benchmarks.POC
 		// [Params(1, 10, 1024, 10240, RecyclableDefaults.MinPooledArrayLength, RecyclableDefaults.MinItemsCountForParallelization)]
 		// [Params(RecyclableDefaults.MinItemsCountForParallelization * 3)]
 		// [Params(1_048_576)]
-		public virtual int TestObjectCount { get; set; } = 1; //33_554_432; //524_288; //131_072;
+		public virtual int TestObjectCount { get; set; } = 131_072; //1; //33_554_432; //524_288; //131_072;
 		public virtual int TestObjectCountForSlowMethods => (TestObjectCount / 2) + 1;// Math.Min(TestObjectCount, 131_072);
 
 		// [Params(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120, 130, 140, 150, 160, 170, 180, 190, 200)]

Recyclable.Collections.Benchmarks/Program.cs

@@ -23,17 +23,16 @@ public static class Program
 		// ****************
 		// *** Template ***
 		// ****************
-		//var benchmark = new RecyclableCollectionsBenchmarks();
-		//benchmark.Setup();
+		var benchmark = new RecyclableCollectionsBenchmarks();
+		benchmark.Setup();
 
 		//foreach (var _ in Enumerable.Range(1, 1000))
 		//{
-			// benchmark.RecyclableLongList_Remove_FirstItems();
-			// benchmark.RecyclableLongList_RemoveAt_LastItems();
-			// benchmark.List_RemoveAt_LastItems();
+		benchmark.List_ForEach();
+		benchmark.RecyclableList_ForEach();
 		//}
 
-		//benchmark.Cleanup();
+		benchmark.Cleanup();
 	}
 
 	static void RunPocBenchmarks()
@@ -53,8 +52,8 @@ public static class Program
 	static void Main(string[] args)
 	{
 		RunRecyclableCollectionsBenchmarks();
-		// RunPocBenchmarks();
-		// RunSelectedBenchmarks();
-		// RunAssemblyBenchmarks();
+		//RunPocBenchmarks();
+		//RunSelectedBenchmarks();
+		//RunAssemblyBenchmarks();
 	}
 }