mlemanczyk/Recyclable.Collections
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Small cleanup

Browse Source
This commit is contained in:
mlemanczyk committed 2023-05-13 20:35:57 +02:00
1 parent bb878caa39
commit 53d759586e
6 files changed
+66 -66
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Recyclable.Collections.Benchmarks/Benchmarks/Create.cs
+4 -4
View File
@@ -4,25 +4,25 @@ namespace Recyclable.Collections.Benchmarks
{ {
public partial class RecyclableCollectionsBenchmarks public partial class RecyclableCollectionsBenchmarks
{ {
public void List_Create() public static void List_Create()
{ {
var list = new List<long>(); var list = new List<long>();
DoNothing(list); DoNothing(list);
} }
public void PooledList_Create() public static void PooledList_Create()
{ {
using var list = new PooledList<long>(ClearMode.Auto); using var list = new PooledList<long>(ClearMode.Auto);
DoNothing(list); DoNothing(list);
} }
public void RecyclableArrayList_Create() public static void RecyclableArrayList_Create()
{ {
using var list = new RecyclableArrayList<long>(); using var list = new RecyclableArrayList<long>();
DoNothing(list); DoNothing(list);
} }
public void RecyclableList_Create() public static void RecyclableList_Create()
{ {
using var list = new RecyclableList<long>(); using var list = new RecyclableList<long>();
DoNothing(list); DoNothing(list);
Recyclable.Collections.Benchmarks/POC/ArraySizeLimitPoc.Benchmarks.cs
+5 -5
View File
@@ -14,7 +14,7 @@ namespace Recyclable.Collections.Benchmarks.POC
{ {
var benchmark = new ArraySizeLimitPocBenchmarks(); var benchmark = new ArraySizeLimitPocBenchmarks();
benchmark.Setup(); benchmark.Setup();
benchmark.FindArraySizeLimit(); FindArraySizeLimit();
benchmark.Cleanup(); benchmark.Cleanup();
} }
@@ -24,12 +24,12 @@ namespace Recyclable.Collections.Benchmarks.POC
[Benchmark(OperationsPerInvoke = 1)] [Benchmark(OperationsPerInvoke = 1)]
public void Max_Allowed_Size_2_147_483_605() public void Max_Allowed_Size_2_147_483_605()
{ {
long[] arr = ArrayPool<long>.Shared.Rent(TestObjectCount); long[] arr = ArrayPool<long>.Shared.Rent(TestObjectCount);
DoNothing(arr); DoNothing(arr);
} }
[Benchmark(OperationsPerInvoke = 1)] [Benchmark(OperationsPerInvoke = 1)]
public void FindArraySizeLimit() public static void FindArraySizeLimit()
{ {
var pool = ArrayPool<long>.Shared; var pool = ArrayPool<long>.Shared;
var bufferSize = int.MaxValue / 2; var bufferSize = int.MaxValue / 2;
@@ -66,5 +66,5 @@ namespace Recyclable.Collections.Benchmarks.POC
Console.WriteLine("All done"); Console.WriteLine("All done");
throw new Exception($"Everything was successful. You can create {oldValue} byte big arrays. Exception is logged to prevent more benchmarks."); throw new Exception($"Everything was successful. You can create {oldValue} byte big arrays. Exception is logged to prevent more benchmarks.");
} }
} }
} }
Recyclable.Collections.Benchmarks/POC/PocBenchmarkBase.cs
+16 -16
View File
@@ -4,31 +4,31 @@ using System.Runtime.CompilerServices;
namespace Recyclable.Collections.Benchmarks.POC namespace Recyclable.Collections.Benchmarks.POC
{ {
public abstract class PocBenchmarkBase<TBenchmarkType> public abstract class PocBenchmarkBase<TBenchmarkType>
{ {
public virtual TBenchmarkType? BenchmarkType { get; set; } public virtual TBenchmarkType? BenchmarkType { get; set; }
public virtual TBenchmarkType? BaselineBenchmarkType { get; set; } public virtual TBenchmarkType? BaselineBenchmarkType { get; set; }
private Action? _testMethod; private Action? _testMethod;
protected Action TestMethod protected Action TestMethod
{ {
get => _testMethod ?? throw new OperationCanceledException("Skip - Custom benchmark run in progress"); get => _testMethod ?? throw new OperationCanceledException("Skip - Custom benchmark run in progress");
set => _testMethod = value; set => _testMethod = value;
} }
private Action? _baselineMethod; private Action? _baselineMethod;
protected Action BaselineMethod protected Action BaselineMethod
{ {
get => _baselineMethod ?? throw new OperationCanceledException("Skip - No baseline defined"); get => _baselineMethod ?? throw new OperationCanceledException("Skip - No baseline defined");
set => _baselineMethod = value; set => _baselineMethod = value;
} }
[Benchmark]
public void RunWhen() => TestMethod.Invoke();
[Benchmark(Baseline = true)] [Benchmark(Baseline = true)]
public void Baseline() => BaselineMethod.Invoke(); public void Baseline() => BaselineMethod.Invoke();
[Benchmark]
public void Actual() => TestMethod.Invoke();
// 0 2 4 8 16 32 64 128 256 512 1024 2048 4096 8192 16384 32768 65536 131072 262144 524_288 // 0 2 4 8 16 32 64 128 256 512 1024 2048 4096 8192 16384 32768 65536 131072 262144 524_288
// 1048576 2097152 4194304 8388608 16777216 33554432 67108864 134217728 268435456 536870912 // 1048576 2097152 4194304 8388608 16777216 33554432 67108864 134217728 268435456 536870912
// 1073741824 2147483648 // 1073741824 2147483648
@@ -64,12 +64,12 @@ namespace Recyclable.Collections.Benchmarks.POC
protected static Exception CreateUnknownBenchmarkTypeException<T>(T benchmarkType) protected static Exception CreateUnknownBenchmarkTypeException<T>(T benchmarkType)
{ {
return new InvalidOperationException($"******* UNKNOWN BENCHMARK TYPE {{{benchmarkType}}} *******"); return new InvalidOperationException($"******* UNKNOWN BENCHMARK TYPE {{{benchmarkType}}} *******");
} }
protected static Exception CreateMethodNotFoundException(in string methodName, in string? className) protected static Exception CreateMethodNotFoundException(in string methodName, in string? className)
{ {
return new MethodAccessException($"******* METHOD {{{methodName}}} NOT FOUND IN CLASS {{{className}}} *******"); return new MethodAccessException($"******* METHOD {{{methodName}}} NOT FOUND IN CLASS {{{className}}} *******");
} }
protected virtual void PrepareData<T>(T benchmarkType) { } protected virtual void PrepareData<T>(T benchmarkType) { }
Recyclable.Collections.Benchmarks/Program.cs
+2 -2
View File
@@ -51,8 +51,8 @@ internal class Program
private static void Main(string[] args) private static void Main(string[] args)
{ {
RunRecyclableCollectionsBenchmarks(); RunRecyclableCollectionsBenchmarks();
//RunPocBenchmarks(); // RunPocBenchmarks();
//RunSelectedBenchmarks(); // RunSelectedBenchmarks();
//RunAssemblyBenchmarks(); //RunAssemblyBenchmarks();
} }
} }
Recyclable.Collections/ItemRange.cs
+1 -1
View File
@@ -2,7 +2,7 @@ using Recyclable.Collections.Pools;
namespace Recyclable.Collections namespace Recyclable.Collections
{ {
public sealed class ItemRange public sealed class ItemRange
{ {
public int BlockIndex; public int BlockIndex;
public int StartingItemIndex; public int StartingItemIndex;
Recyclable.Collections/Parallel/ParallelSynchronizationContextPool.cs
+38 -38
View File
@@ -2,49 +2,49 @@ using Microsoft.Extensions.ObjectPool;
namespace Recyclable.Collections.Parallel namespace Recyclable.Collections.Parallel
{ {
public static class ParallelSynchronizationContextPool public static class ParallelSynchronizationContextPool
{ {
private static readonly SpinLock _updateLock = new(false); private static readonly SpinLock _updateLock = new(false);
public static readonly ObjectPool<ParallelSynchronizationContext> Shared = new DefaultObjectPool<ParallelSynchronizationContext>(new DefaultPooledObjectPolicy<ParallelSynchronizationContext>()); public static readonly ObjectPool<ParallelSynchronizationContext> Shared = new DefaultObjectPool<ParallelSynchronizationContext>(new DefaultPooledObjectPolicy<ParallelSynchronizationContext>());
public static ParallelSynchronizationContext GetWithOneParticipant() public static ParallelSynchronizationContext GetWithOneParticipant()
{ {
bool lockTaken = false; bool lockTaken = false;
_updateLock.Enter(ref lockTaken); _updateLock.Enter(ref lockTaken);
var context = Shared.Get(); var context = Shared.Get();
if (lockTaken) if (lockTaken)
{ {
_updateLock.Exit(false); _updateLock.Exit(false);
} }
if (context.ItemFoundSignal._isSet) if (context.ItemFoundSignal._isSet)
{ {
context.ItemFoundSignal.Reset(); context.ItemFoundSignal.Reset();
} }
switch (context.AllDoneSignal.ParticipantsRemaining) switch (context.AllDoneSignal.ParticipantsRemaining)
{ {
case > 1: case > 1:
context.AllDoneSignal.RemoveParticipants(context.AllDoneSignal.ParticipantsRemaining - 1); context.AllDoneSignal.RemoveParticipants(context.AllDoneSignal.ParticipantsRemaining - 1);
break; break;
case 0: case 0:
context.AllDoneSignal.AddParticipant(); _ = context.AllDoneSignal.AddParticipant();
break; break;
} }
if (context.Exception != null) if (context.Exception != null)
{ {
context.Exception = null; context.Exception = null;
} }
if (context.FoundItemIndex >= 0) if (context.FoundItemIndex >= 0)
{ {
context.FoundItemIndex = -1L; context.FoundItemIndex = -1L;
} }
context._returned = false; context._returned = false;
return context; return context;
} }
} }
} }