diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 25f43e7..a190a6f 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -15,14 +15,14 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - name: Setup .NET - uses: actions/setup-dotnet@v3 - with: - dotnet-version: 6.0.x - - name: Restore dependencies - run: dotnet restore - - name: Build - run: dotnet build --no-restore - - name: Test - run: dotnet test --no-build --verbosity normal + - uses: actions/checkout@v3 + - name: Setup .NET + uses: actions/setup-dotnet@v3 + with: + dotnet-version: 8.0.x + - name: Restore dependencies + run: dotnet restore + - name: Build + run: dotnet build --no-restore + - name: Test + run: dotnet test --framework net8.0 --verbosity normal diff --git a/AGENTS.md b/AGENTS.md index 6dd4a2f..ef3e0df 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -2,7 +2,7 @@ This repository hosts various libraries distributed as NuGet packages. Keep these links up to date so contributors and tools can easily locate them. -Only the .NET SDK **8.0** is available in the execution environment. Use this version when building or running tests. +Only the .NET SDK **8.0** is available in the execution environment. Use this version when building or running tests. When invoking `dotnet test`, do **not** pass `--no-build` because that leads to missing assemblies. Instead, specify the `--framework` argument matching the SDK available in the environment (currently `net8.0`). All `*.csproj` files should enable nullable reference types with `enable`. Indent code using four spaces or a single tab per level. Place one blank line after each closing curly brace of a code block, except when several closing braces appear sequentially. Always use braces for `if` and `else` bodies. diff --git a/Recyclable.Collections/RecyclableStack.cs b/Recyclable.Collections/RecyclableStack.cs index 21f8403..def9ba0 100644 --- a/Recyclable.Collections/RecyclableStack.cs +++ b/Recyclable.Collections/RecyclableStack.cs @@ -43,7 +43,6 @@ namespace Recyclable.Collections } private RecyclableArrayPoolChunk _current; - private RecyclableArrayPoolChunk _bottom; private bool _disposed; private long _capacity; private long _count; @@ -61,7 +60,6 @@ namespace Recyclable.Collections } _current = RentChunk(initialCapacity, null); - _bottom = _current; _capacity = initialCapacity; _count = 0; } @@ -128,7 +126,6 @@ namespace Recyclable.Collections _capacity = _current.Buffer.Length; _current.Index = 0; _count = 0; - _bottom = _current; } public Enumerator GetEnumerator() => new(this); @@ -160,10 +157,6 @@ namespace Recyclable.Collections _current = toReturn.Previous!; _current.Next = null; _capacity -= toReturn.Buffer.Length; - if (_current.Previous == null) - { - _bottom = _current; - } ReturnChunk(toReturn); } diff --git a/SourceCodeGenerator.Net/SourceCodeGenerator.Net.csproj b/SourceCodeGenerator.Net/SourceCodeGenerator.Net.csproj index bca5e9a..76fdb19 100644 --- a/SourceCodeGenerator.Net/SourceCodeGenerator.Net.csproj +++ b/SourceCodeGenerator.Net/SourceCodeGenerator.Net.csproj @@ -1,8 +1,9 @@ - net8.0 - True + net8.0;net7.0;net6.0 + enable + True