mlemanczyk/Recyclable.Collections
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RecyclableList.AddRange performance improvements. Local variable removed.

Browse Source
This commit is contained in:
mlemanczyk committed 2023-07-15 16:42:33 +02:00
1 parent 7909417a68
commit 8242247436
1 file changed
+15 -20
Download Patch File Download Diff File Expand all files Collapse all files
Recyclable.Collections/RecyclableList.cs
+15 -20
View File
@@ -198,70 +198,65 @@ namespace Recyclable.Collections
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public void AddRange(in T[] items) public void AddRange(in T[] items)
{ {
int targetCapacity = _count + items.Length; if (_capacity < _count + items.Length)
if (_capacity < targetCapacity)
{ {
_ = RecyclableListHelpers<T>.EnsureCapacity(this, targetCapacity); _ = RecyclableListHelpers<T>.EnsureCapacity(this, _count + items.Length);
} }
new Span<T>(items).CopyTo(new Span<T>(_memoryBlock, _count, items.Length)); new Span<T>(items).CopyTo(new Span<T>(_memoryBlock, _count, items.Length));
_count = targetCapacity; _count += items.Length;
_version++; _version++;
} }
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public void AddRange(ReadOnlySpan<T> items) public void AddRange(ReadOnlySpan<T> items)
{ {
int targetCapacity = _count + items.Length; if (_capacity < _count + items.Length)
if (_capacity < targetCapacity)
{ {
_ = RecyclableListHelpers<T>.EnsureCapacity(this, targetCapacity); _ = RecyclableListHelpers<T>.EnsureCapacity(this, _count + items.Length);
} }
items.CopyTo(new Span<T>(_memoryBlock, _count, items.Length)); items.CopyTo(new Span<T>(_memoryBlock, _count, items.Length));
_count = targetCapacity; _count += items.Length;
_version++; _version++;
} }
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public void AddRange(List<T> items) public void AddRange(List<T> items)
{ {
var targetCapacity = _count + items.Count; if (_capacity < _count + items.Count)
if (_capacity < targetCapacity)
{ {
_ = RecyclableListHelpers<T>.EnsureCapacity(this, targetCapacity); _ = RecyclableListHelpers<T>.EnsureCapacity(this, _count + items.Count);
} }
items.CopyTo(_memoryBlock, _count); items.CopyTo(_memoryBlock, _count);
_count = targetCapacity; _count += items.Count;
_version++; _version++;
} }
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public void AddRange(IList<T> items) public void AddRange(IList<T> items)
{ {
var targetCapacity = _count + items.Count; if (_capacity < _count + items.Count)
if (_capacity < targetCapacity)
{ {
_ = RecyclableListHelpers<T>.EnsureCapacity(this, targetCapacity); _ = RecyclableListHelpers<T>.EnsureCapacity(this, _count + items.Count);
} }
items.CopyTo(_memoryBlock, _count); items.CopyTo(_memoryBlock, _count);
_count = targetCapacity; _count += items.Count;
_version++; _version++;
} }
[MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)] [MethodImpl(MethodImplOptions.NoInlining | MethodImplOptions.AggressiveOptimization)]
public void AddRange(RecyclableList<T> items) public void AddRange(RecyclableList<T> items)
{ {
var targetCapacity = _count + items._count; if (_capacity < _count + items._count)
if (_capacity < targetCapacity)
{ {
_ = RecyclableListHelpers<T>.EnsureCapacity(this, targetCapacity); _ = RecyclableListHelpers<T>.EnsureCapacity(this, _count + items._count);
} }
new Span<T>(items._memoryBlock, 0, items._count).CopyTo(new Span<T>(_memoryBlock, _count, items._count)); new Span<T>(items._memoryBlock, 0, items._count).CopyTo(new Span<T>(_memoryBlock, _count, items._count));
_count = targetCapacity; _count += items._count;
_version++; _version++;
} }