From cb66a90a9ccce714d2b35ebaa596ab4aa7c4ea91 Mon Sep 17 00:00:00 2001 From: mlemanczyk Date: Sun, 3 Sep 2023 16:54:18 +0200 Subject: [PATCH] Small cleanup. Duplicated tests removed. --- Recyclable.CollectionsTests/RecyclableListTests.cs | 14 +------------- .../RecyclableLongListTests.cs | 14 +------------- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/Recyclable.CollectionsTests/RecyclableListTests.cs b/Recyclable.CollectionsTests/RecyclableListTests.cs index 54f6477..39e2cdb 100644 --- a/Recyclable.CollectionsTests/RecyclableListTests.cs +++ b/Recyclable.CollectionsTests/RecyclableListTests.cs @@ -246,19 +246,6 @@ namespace Recyclable.CollectionsTests _ = list.Should().Equal(testData.Concat(testData)); } - [Theory] - [MemberData(nameof(RecyclableLongListTestData.SourceDataVariants), MemberType = typeof(RecyclableLongListTestData))] - public void ConstructorShouldAddItemsInCorrectOrderWhenSourceIsIEnumerable(string testCase, IEnumerable testData, long itemsCount) - { - // Act - using var list = new RecyclableList(testData, (int)itemsCount); - - // Validate - _ = list.Capacity.Should().BeGreaterThanOrEqualTo((int)itemsCount, "when we succeed in taking count without enumerating, then we allocate as much memory as needed, only"); - _ = list.Count.Should().Be((int)itemsCount); - _ = list.Should().Equal(testData); - } - [Theory] [MemberData(nameof(RecyclableLongListTestData.SourceDataVariants), MemberType = typeof(RecyclableLongListTestData))] public void ConstructorSourceShouldInitializeList(string testCase, IEnumerable testData, long itemsCount) @@ -267,6 +254,7 @@ namespace Recyclable.CollectionsTests using var list = new RecyclableList(testData, (int)itemsCount); // Validate + _ = list.Capacity.Should().BeGreaterThanOrEqualTo((int)itemsCount, "when we succeed in taking count without enumerating, then we allocate as much memory as needed, only"); _ = list.Count.Should().Be((int)itemsCount); _ = list.Should().Equal(testData); } diff --git a/Recyclable.CollectionsTests/RecyclableLongListTests.cs b/Recyclable.CollectionsTests/RecyclableLongListTests.cs index 200e53f..8b2d7b2 100644 --- a/Recyclable.CollectionsTests/RecyclableLongListTests.cs +++ b/Recyclable.CollectionsTests/RecyclableLongListTests.cs @@ -269,19 +269,6 @@ namespace Recyclable.CollectionsTests _ = list.Should().Equal(testData); } - [Theory] - [MemberData(nameof(RecyclableLongListTestData.SourceTargetDataVariants), MemberType = typeof(RecyclableLongListTestData))] - public void ConstructorShouldAddItemsInCorrectOrderWhenSourceIsIEnumerable(string testCase, IEnumerable testData, long itemsCount, int targetBlockSize) - { - // Act - using var list = new RecyclableLongList(testData, minBlockSize: targetBlockSize); - - // Validate - _ = list.Capacity.Should().BeGreaterThanOrEqualTo((int)itemsCount, "when we succeed in taking count without enumerating, then we allocate as much memory as needed, only"); - _ = list.LongCount.Should().Be(itemsCount); - _ = list.Should().Equal(testData); - } - [Theory] [MemberData(nameof(RecyclableLongListTestData.SourceTargetDataVariants), MemberType = typeof(RecyclableLongListTestData))] public void ConstructorSourceShouldInitializeList(string testCase, IEnumerable testData, long itemsCount, int targetBlockSize) @@ -290,6 +277,7 @@ namespace Recyclable.CollectionsTests using var list = new RecyclableLongList(testData, minBlockSize: targetBlockSize); // Validate + _ = list.Capacity.Should().BeGreaterThanOrEqualTo((int)itemsCount, "when we succeed in taking count without enumerating, then we allocate as much memory as needed, only"); _ = list.LongCount.Should().Be(itemsCount); _ = list.Should().Equal(testData); }