diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Add.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Add.cs index 9993bc9..8ab1da5 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Add.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Add.cs @@ -8,7 +8,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - var list = new long[dataCount]; + var list = new int[dataCount]; for (var i = 0; i < dataCount; i++) { list[i] = data[i]; @@ -19,7 +19,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - var list = new List(); + var list = new List(); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -30,7 +30,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new PooledList(ClearMode.Auto); + using var list = new PooledList(ClearMode.Auto); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -41,7 +41,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableList(); + using var list = new RecyclableList(); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -52,7 +52,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableLongList(); + using var list = new RecyclableLongList(); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsArray.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsArray.cs index 823f861..a329e32 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsArray.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsArray.cs @@ -7,35 +7,35 @@ namespace Recyclable.Collections.Benchmarks public void Array_AddRangeWhenSourceIsArray() { var data = TestObjects; - var list = new long[TestObjectCount]; + var list = new int[TestObjectCount]; data.CopyTo(list, 0); } public void List_AddRangeWhenSourceIsArray() { var data = TestObjects; - var list = new List(); + var list = new List(); list.AddRange(data); } public void PooledList_AddRangeWhenSourceIsArray() { var data = TestObjects; - using var list = new PooledList(ClearMode.Auto); + using var list = new PooledList(ClearMode.Auto); list.AddRange(data); } public void RecyclableList_AddRangeWhenSourceIsArray() { var data = TestObjects; - using var list = new RecyclableList(); + using var list = new RecyclableList(); list.AddRange(data); } public void RecyclableLongList_AddRangeWhenSourceIsArray() { var data = TestObjects; - using var list = new RecyclableLongList(minBlockSize: BlockSize); + using var list = new RecyclableLongList(minBlockSize: BlockSize); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIEnumerable.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIEnumerable.cs index da5d00c..422231c 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIEnumerable.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIEnumerable.cs @@ -7,7 +7,7 @@ namespace Recyclable.Collections.Benchmarks public void Array_AddRangeWhenSourceIsIEnumerable() { var data = TestObjectsAsIEnumerable; - var list = new long[TestObjectCount]; + var list = new int[TestObjectCount]; int itemIndex = 0; foreach (var item in data) @@ -19,28 +19,28 @@ namespace Recyclable.Collections.Benchmarks public void List_AddRangeWhenSourceIsIEnumerable() { var data = TestObjectsAsIEnumerable; - var list = new List(); + var list = new List(); list.AddRange(data); } public void PooledList_AddRangeWhenSourceIsIEnumerable() { var data = TestObjectsAsIEnumerable; - using var list = new PooledList(ClearMode.Auto); + using var list = new PooledList(ClearMode.Auto); list.AddRange(data); } public void RecyclableList_AddRangeWhenSourceIsIEnumerable() { var data = TestObjectsAsIEnumerable; - using var list = new RecyclableList(); + using var list = new RecyclableList(); list.AddRange(data); } public void RecyclableLongList_AddRangeWhenSourceIsIEnumerable() { var data = TestObjectsAsIEnumerable; - using var list = new RecyclableLongList(minBlockSize: BlockSize); + using var list = new RecyclableLongList(minBlockSize: BlockSize); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIList.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIList.cs index e09ce55..e4fe95e 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIList.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsIList.cs @@ -6,36 +6,36 @@ namespace Recyclable.Collections.Benchmarks { public void Array_AddRangeWhenSourceIsIList() { - var data = (IList)TestObjectsAsRecyclableLongList; - var list = new long[TestObjectCount]; + var data = (IList)TestObjectsAsRecyclableLongList; + var list = new int[TestObjectCount]; data.CopyTo(list, 0); } public void List_AddRangeWhenSourceIsIList() { - var data = (IList)TestObjectsAsRecyclableLongList; - var list = new List(); + var data = (IList)TestObjectsAsRecyclableLongList; + var list = new List(); list.AddRange(data); } public void PooledList_AddRangeWhenSourceIsIList() { - var data = (IList)TestObjectsAsRecyclableLongList; - using var list = new PooledList(ClearMode.Auto); + var data = (IList)TestObjectsAsRecyclableLongList; + using var list = new PooledList(ClearMode.Auto); list.AddRange(data); } public void RecyclableList_AddRangeWhenSourceIsIList() { - var data = (IList)TestObjectsAsRecyclableLongList; - using var list = new RecyclableList(); + var data = (IList)TestObjectsAsRecyclableLongList; + using var list = new RecyclableList(); list.AddRange(data); } public void RecyclableLongList_AddRangeWhenSourceIsIList() { - var data = (IList)TestObjectsAsRecyclableLongList; - using var list = new RecyclableLongList(minBlockSize: BlockSize); + var data = (IList)TestObjectsAsRecyclableLongList; + using var list = new RecyclableLongList(minBlockSize: BlockSize); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsList.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsList.cs index 6409998..473f383 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsList.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsList.cs @@ -7,35 +7,35 @@ namespace Recyclable.Collections.Benchmarks public void Array_AddRangeWhenSourceIsList() { var data = TestObjectsAsList; - var list = new long[TestObjectCount]; + var list = new int[TestObjectCount]; data.CopyTo(list, 0); } public void List_AddRangeWhenSourceIsList() { var data = TestObjectsAsList; - var list = new List(); + var list = new List(); list.AddRange(data); } public void PooledList_AddRangeWhenSourceIsList() { var data = TestObjectsAsList; - using var list = new PooledList(ClearMode.Auto); + using var list = new PooledList(ClearMode.Auto); list.AddRange(data); } public void RecyclableList_AddRangeWhenSourceIsList() { var data = TestObjectsAsList; - using var list = new RecyclableList(); + using var list = new RecyclableList(); list.AddRange(data); } public void RecyclableLongList_AddRangeWhenSourceIsList() { var data = TestObjectsAsList; - using var list = new RecyclableLongList(minBlockSize: BlockSize); + using var list = new RecyclableLongList(minBlockSize: BlockSize); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsSameType.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsSameType.cs index 293192f..d3e055f 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsSameType.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRangeWhenSourceIsSameType.cs @@ -7,21 +7,21 @@ namespace Recyclable.Collections.Benchmarks public void PooledList_AddRangeWhenSourceIsPooledList() { var data = TestObjectsAsPooledList; - using var list = new PooledList(capacity: TestObjectCount, ClearMode.Auto); + using var list = new PooledList(capacity: TestObjectCount, ClearMode.Auto); list.AddRange(data); } public void RecyclableList_AddRangeWhenSourceIsRecyclableList() { var data = TestObjectsAsRecyclableList; - using var list = new RecyclableList(TestObjectCount); + using var list = new RecyclableList(TestObjectCount); list.AddRange(data); } public void RecyclableLongList_AddRangeWhenSourceIsRecyclableLongList() { var data = TestObjectsAsRecyclableList; - using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: TestObjectCount); + using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: TestObjectCount); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/AddRange_WithCapacity.cs b/Recyclable.Collections.Benchmarks/Benchmarks/AddRange_WithCapacity.cs index 3eac8f4..1c22228 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/AddRange_WithCapacity.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/AddRange_WithCapacity.cs @@ -8,7 +8,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - var list = new long[dataCount]; + var list = new int[dataCount]; data.CopyTo(list, 0); } @@ -16,7 +16,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - var list = new List(dataCount); + var list = new List(dataCount); list.AddRange(data); } @@ -24,7 +24,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new PooledList(capacity: dataCount, ClearMode.Auto); + using var list = new PooledList(capacity: dataCount, ClearMode.Auto); list.AddRange(data); } @@ -32,7 +32,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableList(dataCount); + using var list = new RecyclableList(dataCount); list.AddRange(data); } @@ -40,7 +40,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: dataCount); + using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: dataCount); list.AddRange(data); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Add_WithCapacity.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Add_WithCapacity.cs index 7d01ee0..f6b35b5 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Add_WithCapacity.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Add_WithCapacity.cs @@ -8,7 +8,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - var list = new List(dataCount); + var list = new List(dataCount); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -19,7 +19,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new PooledList(capacity: dataCount, ClearMode.Auto); + using var list = new PooledList(capacity: dataCount, ClearMode.Auto); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -30,7 +30,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableList(dataCount); + using var list = new RecyclableList(dataCount); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); @@ -41,7 +41,7 @@ namespace Recyclable.Collections.Benchmarks { var data = TestObjects; var dataCount = TestObjectCount; - using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: dataCount); + using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: dataCount); for (var i = 0; i < dataCount; i++) { list.Add(data[i]); diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Create.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Create.cs index 4a85c5a..d10adf0 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Create.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Create.cs @@ -8,31 +8,31 @@ namespace Recyclable.Collections.Benchmarks { public void Array_Create() { - var list = new long[0]; + var list = new int[0]; DoNothing(list); } public void List_Create() { - var list = new List(); + var list = new List(); DoNothing(list); } public void PooledList_Create() { - using var list = new PooledList(ClearMode.Auto); + using var list = new PooledList(ClearMode.Auto); DoNothing(list); } public void RecyclableList_Create() { - using var list = new RecyclableList(); + using var list = new RecyclableList(); DoNothing(list); } public void RecyclableLongList_Create() { - using var list = new RecyclableLongList(); + using var list = new RecyclableLongList(); DoNothing(list); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Create_WithCapacity.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Create_WithCapacity.cs index b27c3ec..cb5b584 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Create_WithCapacity.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Create_WithCapacity.cs @@ -6,31 +6,31 @@ namespace Recyclable.Collections.Benchmarks { public void Array_Create_WithCapacity() { - var data = new long[TestObjectCount]; + var data = new int[TestObjectCount]; DoNothing(data); } public void List_Create_WithCapacity() { - var list = new List(TestObjectCount); + var list = new List(TestObjectCount); DoNothing(list); } public void PooledList_Create_WithCapacity() { - using var list = new PooledList(capacity: TestObjectCount, ClearMode.Auto); + using var list = new PooledList(capacity: TestObjectCount, ClearMode.Auto); DoNothing(list); } public void RecyclableList_Create_WithCapacity() { - using var list = new RecyclableList(TestObjectCount); + using var list = new RecyclableList(TestObjectCount); DoNothing(list); } public void RecyclableLongList_Create_WithCapacity() { - using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: TestObjectCount); + using var list = new RecyclableLongList(minBlockSize: BlockSize, initialCapacity: TestObjectCount); DoNothing(list); } } diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs b/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs index b8fcb3f..4f03945 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/GetItem..cs @@ -58,10 +58,10 @@ int blockSize = data.BlockSize; int nextItemBlockIndex = data.NextItemBlockIndex; - var memoryBlocks = new Span(data.AsArray, 0, data.LastBlockWithData + 1); + var memoryBlocks = new Span(data.AsArray, 0, data.LastBlockWithData + 1); for (var blockIndex = 0; blockIndex < nextItemBlockIndex; blockIndex++) { - var memoryBlock = new Span(memoryBlocks[blockIndex], 0, blockSize); + var memoryBlock = new Span(memoryBlocks[blockIndex], 0, blockSize); for (var itemIndex = 0; itemIndex < blockSize; itemIndex++) { DoNothing(memoryBlock[itemIndex]); @@ -70,7 +70,7 @@ if (nextItemBlockIndex == data.LastBlockWithData) { - var memoryBlock = new Span(memoryBlocks[nextItemBlockIndex], 0, data.NextItemIndex); + var memoryBlock = new Span(memoryBlocks[nextItemBlockIndex], 0, data.NextItemIndex); for (var itemIndex = 0; itemIndex < memoryBlock.Length; itemIndex++) { DoNothing(memoryBlock[itemIndex]); @@ -117,7 +117,7 @@ public void RecyclableLongList_GetItem_AsWhile() { var data = TestObjectsAsRecyclableLongList; - long dataCount = TestObjectCount; + int dataCount = TestObjectCount; if (dataCount == 0) { return; diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_FirstItems.cs b/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_FirstItems.cs index c4f7059..2f5cdab 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_FirstItems.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_FirstItems.cs @@ -7,7 +7,7 @@ namespace Recyclable.Collections.Benchmarks public void List_RemoveAt_FirstItems() { var data = TestObjects; - var list = new List(data); + var list = new List(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -18,7 +18,7 @@ namespace Recyclable.Collections.Benchmarks public void PooledList_RemoveAt_FirstItems() { var data = TestObjects; - using var list = new PooledList(data, ClearMode.Auto); + using var list = new PooledList(data, ClearMode.Auto); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -29,7 +29,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableList_RemoveAt_FirstItems() { var data = TestObjects; - using var list = new RecyclableList(data); + using var list = new RecyclableList(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -40,7 +40,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableLongList_RemoveAt_FirstItems() { var data = TestObjects; - using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); + using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_LastItems.cs b/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_LastItems.cs index abbadbb..ca567f8 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_LastItems.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/RemoveAt_LastItems.cs @@ -7,7 +7,7 @@ namespace Recyclable.Collections.Benchmarks public void List_RemoveAt_LastItems() { var data = TestObjects; - var list = new List(data); + var list = new List(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -18,7 +18,7 @@ namespace Recyclable.Collections.Benchmarks public void PooledList_RemoveAt_LastItems() { var data = TestObjects; - using var list = new PooledList(data, ClearMode.Auto); + using var list = new PooledList(data, ClearMode.Auto); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -29,7 +29,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableList_RemoveAt_LastItems() { var data = TestObjects; - using var list = new RecyclableList(data); + using var list = new RecyclableList(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -40,7 +40,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableLongList_RemoveAt_LastItems() { var data = TestObjects; - using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); + using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Remove_FirstItems.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Remove_FirstItems.cs index 659d17f..1640951 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Remove_FirstItems.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Remove_FirstItems.cs @@ -7,7 +7,7 @@ namespace Recyclable.Collections.Benchmarks public void List_Remove_FirstItems() { var data = TestObjects; - var list = new List(data); + var list = new List(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -18,7 +18,7 @@ namespace Recyclable.Collections.Benchmarks public void PooledList_Remove_FirstItems() { var data = TestObjects; - using var list = new PooledList(data, ClearMode.Auto); + using var list = new PooledList(data, ClearMode.Auto); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -29,7 +29,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableList_Remove_FirstItems() { var data = TestObjects; - using var list = new RecyclableList(data); + using var list = new RecyclableList(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { @@ -40,7 +40,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableLongList_Remove_FirstItems() { var data = TestObjects; - using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); + using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity: base.TestObjectCount); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = 0; i < dataCount; i++) { diff --git a/Recyclable.Collections.Benchmarks/Benchmarks/Remove_LastItems.cs b/Recyclable.Collections.Benchmarks/Benchmarks/Remove_LastItems.cs index af08df1..d971c7a 100644 --- a/Recyclable.Collections.Benchmarks/Benchmarks/Remove_LastItems.cs +++ b/Recyclable.Collections.Benchmarks/Benchmarks/Remove_LastItems.cs @@ -7,7 +7,7 @@ namespace Recyclable.Collections.Benchmarks public void List_Remove_LastItems() { var data = TestObjects; - var list = new List(data); + var list = new List(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -18,7 +18,7 @@ namespace Recyclable.Collections.Benchmarks public void PooledList_Remove_LastItems() { var data = TestObjects; - using var list = new PooledList(data, ClearMode.Auto); + using var list = new PooledList(data, ClearMode.Auto); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -29,7 +29,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableList_Remove_LastItems() { var data = TestObjects; - using var list = new RecyclableList(data); + using var list = new RecyclableList(data); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { @@ -40,7 +40,7 @@ namespace Recyclable.Collections.Benchmarks public void RecyclableLongList_Remove_LastItems() { var data = TestObjects; - using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity:base.TestObjectCount); + using var list = new RecyclableLongList(data, minBlockSize: BlockSize, initialCapacity:base.TestObjectCount); var dataCount = TestObjectCount / 10 > 0 ? TestObjectCount / 10 : TestObjectCount; for (var i = data.Length - 1; i > data.Length - dataCount - 1; i--) { diff --git a/Recyclable.Collections.Benchmarks/POC/EqualVsContainsInConsecutiveOrderBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/EqualVsContainsInConsecutiveOrderBenchmarks.cs index b1c2a55..aaeab5b 100644 --- a/Recyclable.Collections.Benchmarks/POC/EqualVsContainsInConsecutiveOrderBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/EqualVsContainsInConsecutiveOrderBenchmarks.cs @@ -1,4 +1,6 @@ -using BenchmarkDotNet.Attributes; +// Ignore Spelling: Poc + +using BenchmarkDotNet.Attributes; using FluentAssertions; using Recyclable.CollectionsTests; @@ -24,7 +26,7 @@ namespace Recyclable.Collections.Benchmarks.POC _ = _list1.Should().ContainInConsecutiveOrder(_list2); } - public void Dispose() + void IDisposable.Dispose() { if (_list1 is IDisposable disposable1) { @@ -35,6 +37,8 @@ namespace Recyclable.Collections.Benchmarks.POC { disposable2.Dispose(); } + + GC.SuppressFinalize(this); } } } diff --git a/Recyclable.Collections.Benchmarks/POC/LessOperatorvsAndOperatorBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/LessOperatorvsAndOperatorBenchmarks.cs index 6781143..2f89dcb 100644 --- a/Recyclable.Collections.Benchmarks/POC/LessOperatorvsAndOperatorBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/LessOperatorvsAndOperatorBenchmarks.cs @@ -1,4 +1,6 @@ -using BenchmarkDotNet.Attributes; +// Ignore Spelling: Poc + +using BenchmarkDotNet.Attributes; using System.Runtime.CompilerServices; #pragma warning disable CA1822 @@ -7,14 +9,14 @@ namespace Recyclable.Collections.Benchmarks.POC { public class LessOperatorVsAndOperatorBenchmarks { - private const int bitShift = 1 << 31; + private const int BitShift = 1 << 31; private static readonly Random _rnd = new(1); - private static int num = -Math.Abs(_rnd.Next()); + private static int _num = -Math.Abs(_rnd.Next()); public void Setup() { - num = -1; - Console.WriteLine($"*** We're comparing if {num} is < 0 ***"); + _num = -1; + Console.WriteLine($"*** We're comparing if {_num} is < 0 ***"); } public void Cleanup() { } @@ -30,25 +32,25 @@ namespace Recyclable.Collections.Benchmarks.POC [Benchmark(Baseline = true)] public void CompareWithLess() { - DoNothing(num < 0); + DoNothing(_num < 0); } [Benchmark] public void CompareWithAnd() { - DoNothing((num & bitShift) != 0); + DoNothing((_num & BitShift) != 0); } [Benchmark] public void CompareWithEqual() { - DoNothing(num == -1); + DoNothing(_num == -1); } [Benchmark] public void CompareToZero() { - DoNothing(num == 0); + DoNothing(_num == 0); } } } diff --git a/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs index 1aa35b4..e1d133b 100644 --- a/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/RoundBenchmarks.cs @@ -1,4 +1,6 @@ -using BenchmarkDotNet.Attributes; +// Ignore Spelling: Poc + +using BenchmarkDotNet.Attributes; namespace Recyclable.Collections.Benchmarks.POC { @@ -35,11 +37,11 @@ namespace Recyclable.Collections.Benchmarks.POC } protected override Action GetTestMethod(RoundBenchmarkType benchmarkType) => benchmarkType switch - { - RoundBenchmarkType.MathFloor => RoundWithMathFloor, - RoundBenchmarkType.MathRound => RoundWithMathRound, - RoundBenchmarkType.WithTypecasting => RoundWithTypeCasting, - _ => throw CreateUnknownBenchmarkTypeException(benchmarkType), - }; + { + RoundBenchmarkType.MathFloor => RoundWithMathFloor, + RoundBenchmarkType.MathRound => RoundWithMathRound, + RoundBenchmarkType.WithTypecasting => RoundWithTypeCasting, + _ => throw CreateUnknownBenchmarkTypeException(benchmarkType), + }; } } diff --git a/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs b/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs index 3a45b2c..944d396 100644 --- a/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/SpanVsArrayBenchmarks.cs @@ -1,4 +1,6 @@ -using BenchmarkDotNet.Attributes; +// Ignore Spelling: Poc + +using BenchmarkDotNet.Attributes; namespace Recyclable.Collections.Benchmarks.POC { @@ -28,21 +30,21 @@ namespace Recyclable.Collections.Benchmarks.POC public override SpanVsArrayBenchmarkType BaseDataType { get => base.BaseDataType; set => base.BaseDataType = value; } protected override Action GetTestMethod(SpanVsArrayBenchmarkType benchmarkType) => benchmarkType switch - { - SpanVsArrayBenchmarkType.ArrayGetWithVar => ArrayGetWithVar, - SpanVsArrayBenchmarkType.ArrayGetWithField => ArrayGetWithField, - SpanVsArrayBenchmarkType.SpanGet => SpanGet, - SpanVsArrayBenchmarkType.ArraySetWithVar => ArraySetWithVar, - SpanVsArrayBenchmarkType.ArraySetWithField => ArraySetWithField, - SpanVsArrayBenchmarkType.SpanSet => SpanSet, - _ => throw CreateUnknownBenchmarkTypeException(benchmarkType), - }; + { + SpanVsArrayBenchmarkType.ArrayGetWithVar => ArrayGetWithVar, + SpanVsArrayBenchmarkType.ArrayGetWithField => ArrayGetWithField, + SpanVsArrayBenchmarkType.SpanGet => SpanGet, + SpanVsArrayBenchmarkType.ArraySetWithVar => ArraySetWithVar, + SpanVsArrayBenchmarkType.ArraySetWithField => ArraySetWithField, + SpanVsArrayBenchmarkType.SpanSet => SpanSet, + _ => throw CreateUnknownBenchmarkTypeException(benchmarkType), + }; - public void ArrayGetWithVar() + public void ArrayGetWithVar() { var data = TestObjects; var dataCount = TestObjectCount; - for (long i = 0; i < dataCount; i++) + for (int i = 0; i < dataCount; i++) { DoNothing(data[i]); } @@ -51,7 +53,7 @@ namespace Recyclable.Collections.Benchmarks.POC public void ArrayGetWithField() { var dataCount = TestObjectCount; - for (long i = 0; i < dataCount; i++) + for (int i = 0; i < dataCount; i++) { DoNothing(_testObjects![i]); } @@ -60,7 +62,7 @@ namespace Recyclable.Collections.Benchmarks.POC public void SpanGet() { var dataCount = TestObjectCount; - Span data = new(_testObjects, 0, dataCount); + Span data = new(_testObjects, 0, dataCount); for (int i = 0; i < dataCount; i++) { DoNothing(data[i]); @@ -71,7 +73,7 @@ namespace Recyclable.Collections.Benchmarks.POC { var data = TestObjects; var dataCount = TestObjectCount; - for (long i = 0; i < dataCount; i++) + for (int i = 0; i < dataCount; i++) { data[i] = i; } @@ -80,7 +82,7 @@ namespace Recyclable.Collections.Benchmarks.POC public void ArraySetWithField() { var dataCount = TestObjectCount; - for (long i = 0; i < dataCount; i++) + for (int i = 0; i < dataCount; i++) { _testObjects![i] = i; } @@ -89,7 +91,7 @@ namespace Recyclable.Collections.Benchmarks.POC public void SpanSet() { var dataCount = TestObjectCount; - Span data = new(_testObjects, 0, dataCount); + Span data = new(_testObjects, 0, dataCount); for (int i = 0; i < dataCount; i++) { data[i] = i; diff --git a/Recyclable.Collections.Benchmarks/POC/TaskRunVsTaskFactoryStartNew.Benchmarks.cs b/Recyclable.Collections.Benchmarks/POC/TaskRunVsTaskFactoryStartNew.Benchmarks.cs index 546d108..6c93a8a 100644 --- a/Recyclable.Collections.Benchmarks/POC/TaskRunVsTaskFactoryStartNew.Benchmarks.cs +++ b/Recyclable.Collections.Benchmarks/POC/TaskRunVsTaskFactoryStartNew.Benchmarks.cs @@ -1,29 +1,25 @@ -using System; -using System.Collections.Generic; -using System.Linq; -using System.Threading.Tasks; -using System.Threading.Tasks.Sources; +// Ignore Spelling: Poc + using BenchmarkDotNet.Attributes; -using Microsoft.Extensions.ObjectPool; namespace Recyclable.Collections.Benchmarks.POC { [MemoryDiagnoser] - public class TaskRunVsTaskFactoryStartNewBenchmarks - { + public class TaskRunVsTaskFactoryStartNewBenchmarks + { public int NumberOfTasks = 100; - private static readonly TaskFactory TaskPool = new(); + private static readonly TaskFactory _taskPool = new(); [Benchmark] public void OwnTaskFactory() { for (var i = 0; i < NumberOfTasks; i++) { - _ = TaskPool.StartNew(() => {}); + _ = _taskPool.StartNew(() => {}); } } - [Benchmark] + [Benchmark] public void TaskRun() { for (var i = 0; i < NumberOfTasks; i++) @@ -32,7 +28,7 @@ namespace Recyclable.Collections.Benchmarks.POC } } - [Benchmark(Baseline = true)] + [Benchmark(Baseline = true)] public void TaskFactoryStartNew() { for (var i = 0; i < NumberOfTasks; i++) @@ -59,5 +55,5 @@ namespace Recyclable.Collections.Benchmarks.POC new Task(() => { }).Start(scheduler); } } - } + } } \ No newline at end of file diff --git a/Recyclable.Collections.Benchmarks/Program.cs b/Recyclable.Collections.Benchmarks/Program.cs index 0ae9ba7..a754215 100644 --- a/Recyclable.Collections.Benchmarks/Program.cs +++ b/Recyclable.Collections.Benchmarks/Program.cs @@ -51,7 +51,8 @@ namespace Recyclable.Collections.Benchmarks _ = BenchmarkRunner.Run(BenchmarkConfig); _ = BenchmarkRunner.Run(BenchmarkConfig); _ = BenchmarkRunner.Run(BenchmarkConfig); - // ArraySizeLimitPocBenchmarks>(BenchmarkConfig); + + //ArraySizeLimitBenchmarks.Run(); } static void Main() diff --git a/Recyclable.Collections/ComparisonToComparerAdapter.cs b/Recyclable.Collections/ComparisonToComparerAdapter.cs index 38582b0..efc1285 100644 --- a/Recyclable.Collections/ComparisonToComparerAdapter.cs +++ b/Recyclable.Collections/ComparisonToComparerAdapter.cs @@ -15,6 +15,7 @@ namespace Recyclable.Collections { return CompareResult.XEqualY; } +#pragma warning disable IDE0046 // This is intentional due to better performance - IL contained unnecessary local variable. else if (x != null && y == null) { return CompareResult.XGreaterThenY; @@ -27,6 +28,7 @@ namespace Recyclable.Collections { return _comparison(x!, y!); } +#pragma warning restore IDE0046 } } } diff --git a/Recyclable.Collections/ExceptionExtensions.cs b/Recyclable.Collections/ExceptionExtensions.cs index e0a4f10..be125b2 100644 --- a/Recyclable.Collections/ExceptionExtensions.cs +++ b/Recyclable.Collections/ExceptionExtensions.cs @@ -4,7 +4,7 @@ namespace Recyclable.Collections { internal static class ExceptionExtensions { - public static void CaptureAndRethrow(this Exception ex) + public static void CaptureAndReThrow(this Exception ex) { ExceptionDispatchInfo.Capture(ex).Throw(); } diff --git a/Recyclable.Collections/Linq/QuickSortExtensions.cs b/Recyclable.Collections/Linq/QuickSortExtensions.cs index d72dfac..7be3981 100644 --- a/Recyclable.Collections/Linq/QuickSortExtensions.cs +++ b/Recyclable.Collections/Linq/QuickSortExtensions.cs @@ -1,10 +1,5 @@ // Ignore Spelling: Linq -using System; -using System.Collections.Generic; -using System.Linq; using System.Runtime.CompilerServices; -using System.Text; -using System.Threading.Tasks; // The source code was taken from // https://codereview.stackexchange.com/questions/205407/quicksort-without-recursion. diff --git a/Recyclable.Collections/MemoryBucket.cs b/Recyclable.Collections/MemoryBucket.cs index 54a228a..5c8a8c2 100644 --- a/Recyclable.Collections/MemoryBucket.cs +++ b/Recyclable.Collections/MemoryBucket.cs @@ -13,12 +13,12 @@ namespace Recyclable.Collections _memory = memory; } -#pragma warning disable RCS1085 +#pragma warning disable IDE0032 // This is intentional due to better performance private T[] _memory; public T[] Memory { get => _memory; set => _memory = value; } private MemoryBucket? _nextBucket; +#pragma warning restore IDE0032 // Use auto property public MemoryBucket? NextBucket { get => _nextBucket; set => _nextBucket = value; } -#pragma warning restore RCS1085 } } diff --git a/Recyclable.Collections/Pools/MemoryUtils.cs b/Recyclable.Collections/Pools/MemoryUtils.cs index c51306d..d0f4cc8 100644 --- a/Recyclable.Collections/Pools/MemoryUtils.cs +++ b/Recyclable.Collections/Pools/MemoryUtils.cs @@ -7,26 +7,20 @@ namespace Recyclable.Collections.Pools Low } - internal static class MemoryUtils - { - public static MemoryPressure GetMemoryPressure() - { - const double HighPressureThreshold = .90; // Percent of GC memory pressure threshold we consider "high" - const double MediumPressureThreshold = .70; // Percent of GC memory pressure threshold we consider "medium" + internal static class MemoryUtils + { + private const double HighPressureThreshold = .90; // Percent of GC memory pressure threshold we consider "high" + private const double MediumPressureThreshold = .70; // Percent of GC memory pressure threshold we consider "medium" - GCMemoryInfo memoryInfo = GC.GetGCMemoryInfo(); + public static MemoryPressure GetMemoryPressure() + { + GCMemoryInfo memoryInfo = GC.GetGCMemoryInfo(); - if (memoryInfo.MemoryLoadBytes >= memoryInfo.HighMemoryLoadThresholdBytes * HighPressureThreshold) - { - return MemoryPressure.High; - } - - if (memoryInfo.MemoryLoadBytes >= memoryInfo.HighMemoryLoadThresholdBytes * MediumPressureThreshold) - { - return MemoryPressure.Medium; - } - - return MemoryPressure.Low; - } - } + return memoryInfo.MemoryLoadBytes >= memoryInfo.HighMemoryLoadThresholdBytes * HighPressureThreshold + ? MemoryPressure.High + : memoryInfo.MemoryLoadBytes >= memoryInfo.HighMemoryLoadThresholdBytes * MediumPressureThreshold + ? MemoryPressure.Medium + : MemoryPressure.Low; + } + } } \ No newline at end of file diff --git a/Recyclable.Collections/RecyclableList.AddRange.cs b/Recyclable.Collections/RecyclableList.AddRange.cs index 5aa15ee..a5f4d33 100644 --- a/Recyclable.Collections/RecyclableList.AddRange.cs +++ b/Recyclable.Collections/RecyclableList.AddRange.cs @@ -4,7 +4,9 @@ using System.Runtime.CompilerServices; namespace Recyclable.Collections { +#pragma warning disable IDE1006 // This is intentional naming for the class to show up at the end of IntelliSense list. public static class zRecyclableListAddRange +#pragma warning restore IDE1006 // This is intentional naming for the class to show up at the end of IntelliSense list. { private static void AddRangeEnumerated(this RecyclableList list, IEnumerable items, int growByCount) { diff --git a/Recyclable.Collections/RecyclableList.Helpers.cs b/Recyclable.Collections/RecyclableList.Helpers.cs index e8882c8..9c1ee39 100644 --- a/Recyclable.Collections/RecyclableList.Helpers.cs +++ b/Recyclable.Collections/RecyclableList.Helpers.cs @@ -5,7 +5,7 @@ namespace Recyclable.Collections { internal static class RecyclableListHelpers { - private static readonly bool NeedsClearing = !typeof(T).IsValueType; + private static readonly bool _needsClearing = !typeof(T).IsValueType; public static int CalculateIndex(int index, int lowerBound) => index >= 0 ? index + lowerBound : RecyclableDefaults.ItemNotFoundIndex; @@ -30,7 +30,7 @@ namespace Recyclable.Collections // Array.Clear(source); //} - RecyclableArrayPool.ReturnShared(oldMemoryBlock, NeedsClearing); + RecyclableArrayPool.ReturnShared(oldMemoryBlock, _needsClearing); } } @@ -54,7 +54,7 @@ namespace Recyclable.Collections //} // If anything, it has been already cleared above, so we don't need to repeat it. - RecyclableArrayPool.ReturnShared(oldMemoryBlock, NeedsClearing); + RecyclableArrayPool.ReturnShared(oldMemoryBlock, _needsClearing); } return newSize; @@ -80,7 +80,7 @@ namespace Recyclable.Collections //} // If anything, it has been already cleared above, so we don't need to repeat it. - RecyclableArrayPool.ReturnShared(oldMemoryBlock, NeedsClearing); + RecyclableArrayPool.ReturnShared(oldMemoryBlock, _needsClearing); } return newSize; diff --git a/Recyclable.Collections/RecyclableList.cs b/Recyclable.Collections/RecyclableList.cs index 4593fd6..8c739f6 100644 --- a/Recyclable.Collections/RecyclableList.cs +++ b/Recyclable.Collections/RecyclableList.cs @@ -41,22 +41,6 @@ namespace Recyclable.Collections } } - public RecyclableList(int initialCapacity, int lowerBound) - { - if (initialCapacity >= RecyclableDefaults.InitialCapacity) - { - _memoryBlock = initialCapacity >= RecyclableDefaults.MinPooledArrayLength - ? RecyclableArrayPool.RentShared(checked((int)BitOperations.RoundUpToPowerOf2((uint)initialCapacity))) - : new T[initialCapacity]; - _capacity = _memoryBlock.Length; - } - else - { - _memoryBlock = new T[RecyclableDefaults.InitialCapacity]; - _capacity = RecyclableDefaults.InitialCapacity; - } - } - public RecyclableList(in Array source) { _capacity = RecyclableDefaults.InitialCapacity; diff --git a/Recyclable.Collections/RecyclableLongList.AddRange.cs b/Recyclable.Collections/RecyclableLongList.AddRange.cs index e8f5b79..eaa2f36 100644 --- a/Recyclable.Collections/RecyclableLongList.AddRange.cs +++ b/Recyclable.Collections/RecyclableLongList.AddRange.cs @@ -4,7 +4,9 @@ using Recyclable.Collections.Pools; namespace Recyclable.Collections { +#pragma warning disable IDE1006 // This is intentional naming for the class to show up at the end of IntelliSense list. public static class zRecyclableLongListAddRange +#pragma warning restore IDE1006 { private static void AddRangeEnumerated(this RecyclableLongList targetList, IEnumerable items) { diff --git a/Recyclable.Collections/RecyclableLongList.Enumerator.cs b/Recyclable.Collections/RecyclableLongList.Enumerator.cs index 353f2d3..e277def 100644 --- a/Recyclable.Collections/RecyclableLongList.Enumerator.cs +++ b/Recyclable.Collections/RecyclableLongList.Enumerator.cs @@ -16,7 +16,9 @@ namespace Recyclable.Collections private readonly RecyclableLongList _list; #nullable disable +#pragma warning disable IDE0032 // This is intentional due to better performance private T _current; +#pragma warning restore IDE0032 #nullable restore [Pure] diff --git a/Recyclable.Collections/RecyclableLongList.IndexOfHelpers.cs b/Recyclable.Collections/RecyclableLongList.IndexOfHelpers.cs index 1ee976c..a669f3d 100644 --- a/Recyclable.Collections/RecyclableLongList.IndexOfHelpers.cs +++ b/Recyclable.Collections/RecyclableLongList.IndexOfHelpers.cs @@ -284,7 +284,7 @@ namespace Recyclable.Collections try { - context.Exception.CaptureAndRethrow(); + context.Exception.CaptureAndReThrow(); } finally { diff --git a/Recyclable.Collections/RecyclableQueue.cs b/Recyclable.Collections/RecyclableQueue.cs index bc9e910..547ea58 100644 --- a/Recyclable.Collections/RecyclableQueue.cs +++ b/Recyclable.Collections/RecyclableQueue.cs @@ -150,9 +150,7 @@ namespace Recyclable.Collections { RemoveBlock(Memory._count - 1); } -#pragma warning disable RCS1075 // We want to try returning as many arrays, as possible, before the list is cleared. catch (Exception) -#pragma warning restore RCS1075 { } } diff --git a/Recyclable.Collections/ThrowHelper.cs b/Recyclable.Collections/ThrowHelper.cs index d50e7e3..dfedd85 100644 --- a/Recyclable.Collections/ThrowHelper.cs +++ b/Recyclable.Collections/ThrowHelper.cs @@ -1,6 +1,4 @@ -using System.Diagnostics.Contracts; - -namespace Recyclable.Collections +namespace Recyclable.Collections { internal static class ThrowHelper { diff --git a/Recyclable.CollectionsTests/MathUtilsTests.cs b/Recyclable.CollectionsTests/MathUtilsTests.cs index dd8e625..afa988e 100644 --- a/Recyclable.CollectionsTests/MathUtilsTests.cs +++ b/Recyclable.CollectionsTests/MathUtilsTests.cs @@ -1,4 +1,6 @@ -using FluentAssertions; +// Ignore Spelling: Utils + +using FluentAssertions; using Recyclable.Collections; namespace Recyclable.CollectionsTests diff --git a/Recyclable.CollectionsTests/RecyclableListTests.cs b/Recyclable.CollectionsTests/RecyclableListTests.cs index ebfa680..9271a24 100644 --- a/Recyclable.CollectionsTests/RecyclableListTests.cs +++ b/Recyclable.CollectionsTests/RecyclableListTests.cs @@ -1329,13 +1329,13 @@ namespace Recyclable.CollectionsTests public void RemoveAtShouldClearItemWhenReferenceType(string testCase, IEnumerable testData, int itemsCount, in long[] indexesToRemove) { // Prepare - foreach (int indexToRemove in indexesToRemove) + foreach (long indexToRemove in indexesToRemove) { using var list = new RecyclableList(testData, itemsCount); _ = list[^1].Should().NotBeNull(); // Act - list.RemoveAt(indexToRemove); + list.RemoveAt((int)indexToRemove); // Validate _ = list[list.Count].Should().BeNull(); @@ -1391,7 +1391,7 @@ namespace Recyclable.CollectionsTests public void RemoveShouldClearItemWhenReferenceType(string testCase, IEnumerable testData, int itemsCount, in long[] indexesToRemove) { - foreach (int indexToRemove in indexesToRemove) + foreach (long indexToRemove in indexesToRemove) { // Prepare using var list = new RecyclableList(testData, itemsCount); diff --git a/Recyclable.CollectionsTests/RecyclableQueueTests.cs b/Recyclable.CollectionsTests/RecyclableQueueTests.cs index 18fe0a8..8f5052a 100644 --- a/Recyclable.CollectionsTests/RecyclableQueueTests.cs +++ b/Recyclable.CollectionsTests/RecyclableQueueTests.cs @@ -86,7 +86,7 @@ namespace Recyclable.CollectionsTests } [Fact] - public void DequeueShoudRaiseArgumentOutOfRangeWhenNoMoreElementsFound() + public void DequeueShouldRaiseArgumentOutOfRangeWhenNoMoreElementsFound() { // Prepare using var list = new RecyclableQueue(_testData); diff --git a/Recyclable.CollectionsTests/RecyclableStackTests.cs b/Recyclable.CollectionsTests/RecyclableStackTests.cs index dffdd52..e69720a 100644 --- a/Recyclable.CollectionsTests/RecyclableStackTests.cs +++ b/Recyclable.CollectionsTests/RecyclableStackTests.cs @@ -101,7 +101,7 @@ namespace Recyclable.CollectionsTests } [Fact] - public void PopShoudRaiseArgumentOutOfRangeWhenNoMoreElementsFound() + public void PopShouldRaiseArgumentOutOfRangeWhenNoMoreElementsFound() { // Prepare using var list = new RecyclableQueue(_testData);