mlemanczyk/Recyclable.Collections
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RecyclableList.DoLongIndexOfParallel performance improvements.

Browse Source
This commit is contained in:
mlemanczyk committed 2023-04-30 23:59:38 +02:00
1 parent 13fa23ac13
commit f934755d79
1 file changed
+5 -7
Download Patch File Download Diff File Expand all files Collapse all files
Recyclable.Collections/RecyclableList.cs
+5 -7
View File
@@ -228,9 +228,7 @@ namespace Recyclable.Collections
int blockSize = list._blockSize; int blockSize = list._blockSize;
int blockIndex = itemRange.BlockIndex; int blockIndex = itemRange.BlockIndex;
long itemsToSearchCount = itemRange.ItemsToSearchCount; long itemsToSearchCount = itemRange.ItemsToSearchCount;
int startingItemIndex = itemRange.StartingItemIndex; int index = Array.IndexOf(list._memoryBlocks[blockIndex], itemToFind, itemRange.StartingItemIndex, (int)Math.Min(blockSize - itemRange.StartingItemIndex, itemsToSearchCount));
T[][] memoryBlocks = list._memoryBlocks;
int index = Array.IndexOf(memoryBlocks[blockIndex], itemToFind, startingItemIndex, (int)Math.Min(blockSize - startingItemIndex, itemsToSearchCount));
if (itemFoundSignal.IsSet) if (itemFoundSignal.IsSet)
{ {
return ItemNotFoundIndex; return ItemNotFoundIndex;
@@ -243,7 +241,7 @@ namespace Recyclable.Collections
// We don't need Math.Min here, because if itemsToSearchCount < blockSize - itemRange.StartingItemIndex, then it would mean that // We don't need Math.Min here, because if itemsToSearchCount < blockSize - itemRange.StartingItemIndex, then it would mean that
// there are no more items and we already scanned all. We want to break the loop. Subtracting a higher value from itemsToSearchCount // there are no more items and we already scanned all. We want to break the loop. Subtracting a higher value from itemsToSearchCount
// will always result in a negative result. // will always result in a negative result.
itemsToSearchCount -= blockSize - startingItemIndex; itemsToSearchCount -= blockSize - itemRange.StartingItemIndex;
if (itemsToSearchCount <= 0) if (itemsToSearchCount <= 0)
{ {
return ItemNotFoundIndex; return ItemNotFoundIndex;
@@ -254,7 +252,7 @@ namespace Recyclable.Collections
blockIndex++; blockIndex++;
while (itemsToSearchCount > blockSize) while (itemsToSearchCount > blockSize)
{ {
index = Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, blockSize); index = Array.IndexOf(list._memoryBlocks[blockIndex], itemToFind, 0, blockSize);
if (itemFoundSignal.IsSet) if (itemFoundSignal.IsSet)
{ {
return ItemNotFoundIndex; return ItemNotFoundIndex;
@@ -271,8 +269,8 @@ namespace Recyclable.Collections
index = itemsToSearchCount <= 0 || blockIndex > list.LastBlockWithData index = itemsToSearchCount <= 0 || blockIndex > list.LastBlockWithData
? -1 ? -1
: blockIndex == list._nextItemBlockIndex : blockIndex == list._nextItemBlockIndex
? Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, (int)itemsToSearchCount) ? Array.IndexOf(list._memoryBlocks[blockIndex], itemToFind, 0, (int)itemsToSearchCount)
: Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, (int)itemsToSearchCount); : Array.IndexOf(list._memoryBlocks[blockIndex], itemToFind, 0, (int)itemsToSearchCount);
//? Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, checked((int)Math.Min(itemRange.List._nextItemIndex, itemsToSearchCount))) //? Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, checked((int)Math.Min(itemRange.List._nextItemIndex, itemsToSearchCount)))
//: Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, checked((int)Math.Min(blockSize, itemsToSearchCount))); //: Array.IndexOf(memoryBlocks[blockIndex], itemToFind, 0, checked((int)Math.Min(blockSize, itemsToSearchCount)));