From 47521e327aa6b6aaf61e80a5e2202c9a7ff7d251 Mon Sep 17 00:00:00 2001 From: mlemanczyk Date: Tue, 25 Nov 2025 00:50:18 +0100 Subject: [PATCH] Cleanup --- .../PrimeTesterBenchmarks.cs | 4 ++-- PerfectNumbers.Core/HeuristicCombinedPrimeTester.cs | 10 ---------- PerfectNumbers.Core/MersenneNumberTester.cs | 1 + 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/EvenPerfectBitScanner.Benchmarks/PrimeTesterBenchmarks.cs b/EvenPerfectBitScanner.Benchmarks/PrimeTesterBenchmarks.cs index e786dcc..6c30aac 100644 --- a/EvenPerfectBitScanner.Benchmarks/PrimeTesterBenchmarks.cs +++ b/EvenPerfectBitScanner.Benchmarks/PrimeTesterBenchmarks.cs @@ -33,7 +33,7 @@ public class PrimeTesterBenchmarks _ = HeuristicPrimeTester.IsPrimeCpu(_candidates[0]); _ = HeuristicPrimeTester.IsPrimeGpu(gpu, _candidates[0]); _ = Prime.Numbers.IsPrime(_candidates[0]); - PrimeOrderCalculatorAccelerator.Return(gpu); + PrimeOrderCalculatorAccelerator.Return(gpu); } // [Benchmark] @@ -67,8 +67,8 @@ public class PrimeTesterBenchmarks primeCount++; } } - PrimeOrderCalculatorAccelerator.Return(gpu); + PrimeOrderCalculatorAccelerator.Return(gpu); return primeCount; } diff --git a/PerfectNumbers.Core/HeuristicCombinedPrimeTester.cs b/PerfectNumbers.Core/HeuristicCombinedPrimeTester.cs index 4d302f2..b718628 100644 --- a/PerfectNumbers.Core/HeuristicCombinedPrimeTester.cs +++ b/PerfectNumbers.Core/HeuristicCombinedPrimeTester.cs @@ -168,16 +168,6 @@ public sealed class HeuristicCombinedPrimeTester return HeuristicTrialDivisionCpu(n, maxDivisorSquare, nMod10); } - // public static bool IsPrimeGpu(ulong n) - // { - // byte nMod10 = (byte)n.Mod10(); - // ulong maxDivisorSquare = ComputeHeuristicDivisorSquareLimit(n); - // var gpu = PrimeOrderCalculatorAccelerator.Rent(1); - // bool isPrime = IsPrimeGpu(gpu, n, maxDivisorSquare, nMod10); - // PrimeOrderCalculatorAccelerator.Return(gpu); - // return isPrime; - // } - public static bool IsPrimeGpu(PrimeOrderCalculatorAccelerator gpu, ulong n) { byte nMod10 = (byte)n.Mod10(); diff --git a/PerfectNumbers.Core/MersenneNumberTester.cs b/PerfectNumbers.Core/MersenneNumberTester.cs index 93dd5a6..89a7258 100644 --- a/PerfectNumbers.Core/MersenneNumberTester.cs +++ b/PerfectNumbers.Core/MersenneNumberTester.cs @@ -180,6 +180,7 @@ public sealed class MersenneNumberTester( { tmp[i] = (GpuUInt128)qs[offset + i]; } + // Copy only the populated elements to the device buffer to avoid overrun on pooled arrays. qBuffer.View.CopyFromCPU(stream, ref tmp[0], count); gpuUInt128Pool.Return(tmp);