Replace status modulo with subtract loop

EvenPerfectBitScanner.Benchmarks/GpuPow2ModBenchmarks.cs

@@ -50,7 +50,7 @@ public class GpuPow2ModBenchmarks
         return Pow2ModSingleBit(Input.Exponent, Input.Modulus);
     }
 
-    private static GpuUInt128 Pow2ModSingleBit(ulong exponent, GpuUInt128 modulus)
+    private static GpuUInt128 Pow2ModSingleBit(ulong exponent, in GpuUInt128 modulus)
     {
         if (modulus.IsZero || modulus == GpuUInt128.One)
         {

EvenPerfectBitScanner.Benchmarks/Pow2MontgomeryModBenchmarks.cs

@@ -52,31 +52,14 @@ public class Pow2MontgomeryModBenchmarks
     /// Baseline right-to-left Montgomery ladder; measured 36.36 μs on the small sample set and 117.32 μs on the large one.
     /// </summary>
     [Benchmark(Baseline = true)]
-    public ulong BaselineCpu()
+    public ulong Baseline()
     {
         GetData(out var exponents, out var divisors, out _);
         ulong checksum = 0UL;
 
         for (int i = 0; i < SampleCount; i++)
         {
-            checksum ^= exponents[i].Pow2MontgomeryModWindowedCpu(divisors[i], keepMontgomery: false);
-        }
-
-        return checksum;
-    }
-
-    /// <summary>
-    /// Baseline right-to-left Montgomery ladder; measured ??.?? μs on the small sample set and ??.?? μs on the large one.
-    /// </summary>
-    [Benchmark]
-    public ulong BaselineGpu()
-    {
-        GetData(out var exponents, out var divisors, out _);
-        ulong checksum = 0UL;
-
-        for (int i = 0; i < SampleCount; i++)
-        {
-            checksum ^= exponents[i].Pow2MontgomeryModWindowedGpu(divisors[i], keepMontgomery: false);
+            checksum ^= exponents[i].Pow2MontgomeryModWindowed(divisors[i], keepMontgomery: false);
         }
 
         return checksum;
@@ -86,31 +69,14 @@ public class Pow2MontgomeryModBenchmarks
     /// Uses a known divisor cycle to fold the exponent first, dropping runtimes to 26.04 μs on small inputs (0.72× baseline) and 9.53 μs on large inputs (0.08× baseline).
     /// </summary>
     [Benchmark]
-    public ulong BaselineWithKnownCycleCpu()
+    public ulong BaselineWithKnownCycle()
     {
         GetData(out var exponents, out var divisors, out var cycles);
         ulong checksum = 0UL;
 
         for (int i = 0; i < SampleCount; i++)
         {
-            checksum ^= exponents[i].Pow2MontgomeryModWithCycleCpu(cycles[i], divisors[i]);
-        }
-
-        return checksum;
-    }
-
-    /// <summary>
-    /// Uses a known divisor cycle to fold the exponent first, dropping runtimes to 26.04 μs on small inputs (0.72× baseline) and 9.53 μs on large inputs (0.08× baseline).
-    /// </summary>
-    [Benchmark]
-    public ulong BaselineWithKnownCycleGpu()
-    {
-        GetData(out var exponents, out var divisors, out var cycles);
-        ulong checksum = 0UL;
-
-        for (int i = 0; i < SampleCount; i++)
-        {
-            checksum ^= exponents[i].Pow2MontgomeryModWithCycleGpu(cycles[i], divisors[i]);
+            checksum ^= exponents[i].Pow2MontgomeryModWithCycle(cycles[i], divisors[i]);
         }
 
         return checksum;

EvenPerfectBitScanner.Benchmarks/Pow2MontgomeryModCycleComputationBenchmarks.cs

@@ -22,390 +22,320 @@ namespace EvenPerfectBitScanner.Benchmarks;
 [SimpleJob(RuntimeMoniker.Net80, launchCount: 1, warmupCount: 1, iterationCount: 5)]
 public class Pow2MontgomeryModCycleComputationBenchmarks
 {
-	private const int SampleCount = 256;
-	private const ulong OneShiftedLeft63 = 1UL << 63;
-	private const long OneShiftedLeft60 = 1L << 60;
-	private readonly MontgomeryDivisorData[] _smallDivisors = new MontgomeryDivisorData[SampleCount];
-	private readonly MontgomeryDivisorData[] _largeDivisors = new MontgomeryDivisorData[SampleCount];
-	private readonly MontgomeryDivisorData[] _veryLargeDivisors = new MontgomeryDivisorData[SampleCount];
-	private readonly UInt128[] _wideModuli = new UInt128[SampleCount];
-	private readonly ulong[] _smallExponents = new ulong[SampleCount];
-	private readonly ulong[] _largeExponents = new ulong[SampleCount];
-	private readonly ulong[] _veryLargeExponents = new ulong[SampleCount];
-	private readonly ulong[] _smallCycles = new ulong[SampleCount];
-	private readonly ulong[] _largeCycles = new ulong[SampleCount];
-	private readonly ulong[] _veryLargeCycles = new ulong[SampleCount];
-	private readonly UInt128[] _wideCycles = new UInt128[SampleCount];
+    private const int SampleCount = 256;
+    private const ulong OneShiftedLeft63 = 1UL << 63;
+    private const long OneShiftedLeft60 = 1L << 60;
+    private readonly MontgomeryDivisorData[] _smallDivisors = new MontgomeryDivisorData[SampleCount];
+    private readonly MontgomeryDivisorData[] _largeDivisors = new MontgomeryDivisorData[SampleCount];
+    private readonly MontgomeryDivisorData[] _veryLargeDivisors = new MontgomeryDivisorData[SampleCount];
+    private readonly UInt128[] _wideModuli = new UInt128[SampleCount];
+    private readonly ulong[] _smallExponents = new ulong[SampleCount];
+    private readonly ulong[] _largeExponents = new ulong[SampleCount];
+    private readonly ulong[] _veryLargeExponents = new ulong[SampleCount];
+    private readonly ulong[] _smallCycles = new ulong[SampleCount];
+    private readonly ulong[] _largeCycles = new ulong[SampleCount];
+    private readonly ulong[] _veryLargeCycles = new ulong[SampleCount];
+    private readonly UInt128[] _wideCycles = new UInt128[SampleCount];
 
-	private readonly Random _random = new(113);
-	private ulong? _previousPrimeOrder;
-	private UInt128? _previousWidePrimeOrder;
+    private readonly Random _random = new(113);
+    private ulong? _previousPrimeOrder;
+    private UInt128? _previousWidePrimeOrder;
 
-	public enum InputScale
-	{
-		Small,
-		Large,
-		VeryLarge
-	}
+    public enum InputScale
+    {
+        Small,
+        Large,
+        VeryLarge
+    }
 
-	[ParamsAllValues]
-	public InputScale Scale { get; set; }
+    [ParamsAllValues]
+    public InputScale Scale { get; set; }
 
-	[GlobalSetup]
-	public void Setup()
-	{
-		for (int i = 0; i < SampleCount; i++)
-		{
+    [GlobalSetup]
+    public void Setup()
+    {
+        for (int i = 0; i < SampleCount; i++)
+        {
 #if DEBUG
-			Console.WriteLine($"Generating sample {i}");
+            Console.WriteLine($"Generating sample {i}");
 #endif
-			ulong smallModulus = NextSmallOddModulus();
-			_smallDivisors[i] = CreateMontgomeryDivisorData(smallModulus);
-			_smallExponents[i] = NextSmallExponent();
-			_smallCycles[i] = CalculateCycleLengthWithHeuristics(smallModulus);
+            ulong smallModulus = NextSmallOddModulus();
+            _smallDivisors[i] = CreateMontgomeryDivisorData(smallModulus);
+            _smallExponents[i] = NextSmallExponent();
+            _smallCycles[i] = CalculateCycleLengthWithHeuristics(smallModulus);
 
-			(ulong largeModulus, ulong largeCycle) = NextLargeModulusAndCycle();
-			_largeDivisors[i] = CreateMontgomeryDivisorData(largeModulus);
-			_largeExponents[i] = NextLargeExponent();
-			_largeCycles[i] = CalculateCycleLengthWithHeuristics(largeModulus, largeCycle);
+            (ulong largeModulus, ulong largeCycle) = NextLargeModulusAndCycle();
+            _largeDivisors[i] = CreateMontgomeryDivisorData(largeModulus);
+            _largeExponents[i] = NextLargeExponent();
+            _largeCycles[i] = CalculateCycleLengthWithHeuristics(largeModulus, largeCycle);
 
-			ulong veryLargeModulus = NextVeryLargeOddModulus();
-			_veryLargeDivisors[i] = CreateMontgomeryDivisorData(veryLargeModulus);
-			_veryLargeExponents[i] = NextVeryLargeExponent();
+            ulong veryLargeModulus = NextVeryLargeOddModulus();
+            _veryLargeDivisors[i] = CreateMontgomeryDivisorData(veryLargeModulus);
+            _veryLargeExponents[i] = NextVeryLargeExponent();
 #if DEBUG
-			Console.WriteLine($"Calculating cycle length {veryLargeModulus}");
+            Console.WriteLine($"Calculating cycle length {veryLargeModulus}");
 #endif
-			_veryLargeCycles[i] = CalculateCycleLengthWithHeuristics(veryLargeModulus);
+            _veryLargeCycles[i] = CalculateCycleLengthWithHeuristics(veryLargeModulus);
 
-			Console.WriteLine($"Generating wide sample {i}");
-			UInt128 wideModulus = NextWideOddModulus();
-			_wideModuli[i] = wideModulus;
-			_wideCycles[i] = CalculateCycleLengthWithHeuristics(wideModulus);
-		}
-	}
+            Console.WriteLine($"Generating wide sample {i}");
+            UInt128 wideModulus = NextWideOddModulus();
+            _wideModuli[i] = wideModulus;
+            _wideCycles[i] = CalculateCycleLengthWithHeuristics(wideModulus);
+        }
+    }
 
-	/// <summary>
-	/// Baseline Montgomery reduction without precomputed cycle data; measured 35.41 μs on the small sample and 117.33 μs on the
-	/// large set.
-	/// </summary>
-	// [Benchmark(Baseline = true)]
-	public ulong MontgomeryWithoutCycleCpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
+    /// <summary>
+    /// Baseline Montgomery reduction without precomputed cycle data; measured 35.41 μs on the small sample and 117.33 μs on the
+    /// large set.
+    /// </summary>
+    // [Benchmark(Baseline = true)]
+    public ulong MontgomeryWithoutCycle()
+    {
+        GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
+        ulong checksum = 0UL;
 
-		for (int i = 0; i < SampleCount; i++)
-		{
-			checksum ^= exponents[i].Pow2MontgomeryModWindowedCpu(divisors[i], keepMontgomery: false);
-		}
+        for (int i = 0; i < SampleCount; i++)
+        {
+            checksum ^= exponents[i].Pow2MontgomeryModWindowed(divisors[i], keepMontgomery: false);
+        }
 
-		return checksum;
-	}
+        return checksum;
+    }
 
-	/// <summary>
-	/// Baseline Montgomery reduction without precomputed cycle data; measured 35.41 μs on the small sample and 117.33 μs on the
-	/// large set.
-	/// </summary>
-	// [Benchmark(Baseline = true)]
-	public ulong MontgomeryWithoutCycleGpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
+    /// <summary>
+    /// Montgomery reduction with a known cycle length (cycle lookup only); 25.81 μs on the small set (0.73× baseline) and 9.12 μs
+    /// on the large one (0.08×).
+    /// </summary>
+    [Benchmark]
+    public ulong MontgomeryWithPrecomputedCycle()
+    {
+        GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out ulong[] cycles);
+        ulong checksum = 0UL;
 
-		for (int i = 0; i < SampleCount; i++)
-		{
-			checksum ^= exponents[i].Pow2MontgomeryModWindowedGpu(divisors[i], keepMontgomery: false);
-		}
+        for (int i = 0; i < SampleCount; i++)
+        {
+            checksum ^= exponents[i].Pow2MontgomeryModWithCycle(cycles[i], divisors[i]);
+        }
 
-		return checksum;
-	}
+        return checksum;
+    }
 
-	/// <summary>
-	/// Montgomery reduction with a known cycle length (cycle lookup only); 25.81 μs on the small set (0.73× baseline) and 9.12 μs
-	/// on the large one (0.08×).
-	/// </summary>
-	[Benchmark]
-	public ulong MontgomeryWithPrecomputedCycleCpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out ulong[] cycles);
-		ulong checksum = 0UL;
+    /// <summary>
+    /// Montgomery reduction with the cycle computed on the fly using the GPU helper; costs 54.09 ms on the small benchmark due to
+    /// cycle discovery, but drops to 12.91 μs on the large set (0.11× baseline).
+    /// </summary>
+    // [Benchmark]
+    public ulong MontgomeryWithGpuCycleComputation()
+    {
+        GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
+        ulong checksum = 0UL;
 
-		for (int i = 0; i < SampleCount; i++)
-		{
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleCpu(cycles[i], divisors[i]);
-		}
+        for (int i = 0; i < SampleCount; i++)
+        {
+            ulong cycle = MersenneDivisorCycles.CalculateCycleLengthGpu(divisors[i].Modulus);
+            checksum ^= exponents[i].Pow2MontgomeryModWithCycle(cycle, divisors[i]);
+        }
 
-		return checksum;
-	}
-
-	/// <summary>
-	/// Montgomery reduction with a known cycle length (cycle lookup only); 25.81 μs on the small set (0.73× baseline) and 9.12 μs
-	/// on the large one (0.08×).
-	/// </summary>
-	[Benchmark]
-	public ulong MontgomeryWithPrecomputedCycleGpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out ulong[] cycles);
-		ulong checksum = 0UL;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleGpu(cycles[i], divisors[i]);
-		}
-
-		return checksum;
-	}
-
-	/// <summary>
-	/// Montgomery reduction with the cycle computed on the fly using the GPU helper; costs 54.09 ms on the small benchmark due to
-	/// cycle discovery, but drops to 12.91 μs on the large set (0.11× baseline).
-	/// </summary>
-	// [Benchmark]
-	public ulong MontgomeryWithGpuCycleComputationCpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			ulong cycle = MersenneDivisorCycles.CalculateCycleLengthGpu(divisors[i].Modulus);
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleCpu(cycle, divisors[i]);
-		}
-
-		return checksum;
-	}
-
-	/// <summary>
-	/// Montgomery reduction with the cycle computed on the fly using the GPU helper; costs 54.09 ms on the small benchmark due to
-	/// cycle discovery, but drops to 12.91 μs on the large set (0.11× baseline).
-	/// </summary>
-	// [Benchmark]
-	public ulong MontgomeryWithGpuCycleComputationGpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			ulong cycle = MersenneDivisorCycles.CalculateCycleLengthGpu(divisors[i].Modulus);
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleGpu(cycle, divisors[i]);
-		}
-
-		return checksum;
-	}
-
-	[Benchmark]
-	public ulong MontgomeryWithHeuristicCycleComputationCpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			ulong cycle = CalculateCycleLengthWithHeuristics(divisors[i].Modulus);
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleCpu(cycle, divisors[i]);
-		}
-
-		return checksum;
-	}
-
-	[Benchmark]
-	public ulong MontgomeryWithHeuristicCycleComputationGpu()
-	{
-		GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
-		ulong checksum = 0UL;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			ulong cycle = CalculateCycleLengthWithHeuristics(divisors[i].Modulus);
-			checksum ^= exponents[i].Pow2MontgomeryModWithCycleGpu(cycle, divisors[i]);
-		}
-
-		return checksum;
-	}
-
-	[Benchmark]
-	public UInt128 HeuristicWideCycleComputation()
-	{
-		UInt128 checksum = UInt128.Zero;
-
-		for (int i = 0; i < SampleCount; i++)
-		{
-			UInt128 cycle = CalculateCycleLengthWithHeuristics(_wideModuli[i]);
-			_wideCycles[i] = cycle;
-			checksum ^= cycle;
-		}
-
-		return checksum;
-	}
-
-	private void GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out ulong[] cycles)
-	{
-		switch (Scale)
-		{
-			case InputScale.Small:
-				exponents = _smallExponents;
-				divisors = _smallDivisors;
-				cycles = _smallCycles;
-				break;
-			case InputScale.Large:
-				exponents = _largeExponents;
-				divisors = _largeDivisors;
-				cycles = _largeCycles;
-				break;
-			case InputScale.VeryLarge:
-				exponents = _veryLargeExponents;
-				divisors = _veryLargeDivisors;
-				cycles = _veryLargeCycles;
-				break;
-			default:
-				throw new ArgumentOutOfRangeException(nameof(Scale), Scale, null);
-		}
-	}
-
-	private ulong NextSmallExponent() => (ulong)_random.NextInt64(1L, 1_000_000L);
-
-	private ulong NextLargeExponent() => (ulong)_random.NextInt64(OneShiftedLeft60, long.MaxValue);
-
-	private ulong NextVeryLargeExponent()
-	{
-		Span<byte> buffer = stackalloc byte[8];
-		_random.NextBytes(buffer);
-		ulong value = checked(BinaryPrimitives.ReadUInt64LittleEndian(buffer) | OneShiftedLeft63);
-		return value;
-	}
-
-	private ulong NextSmallOddModulus()
-	{
-		ulong value = (ulong)_random.NextInt64(3L, 1_000_000L);
-		return value | 1UL;
-	}
-
-	private (ulong modulus, ulong cycleLength) NextLargeModulusAndCycle()
-	{
-		int bitLength = _random.Next(48, 64);
-		ulong modulus = (1UL << bitLength) - 1UL;
-		return (modulus, (ulong)bitLength);
-	}
-
-	private ulong NextVeryLargeOddModulus()
-	{
-		Span<byte> buffer = stackalloc byte[8];
-		_random.NextBytes(buffer);
-		ulong value = BinaryPrimitives.ReadUInt64LittleEndian(buffer) | OneShiftedLeft63 | 1UL;
-		return value;
-	}
-
-	private UInt128 NextWideOddModulus()
-	{
-		Span<byte> buffer = stackalloc byte[16];
-		_random.NextBytes(buffer);
-		ulong low = BinaryPrimitives.ReadUInt64LittleEndian(buffer);
-		Span<byte> highSlice = buffer.Slice(8, 8);
-		ulong high = BinaryPrimitives.ReadUInt64LittleEndian(highSlice) | (1UL << 63);
-		UInt128 value = ((UInt128)high << 64) | low;
-		return value | UInt128.One;
-	}
-
-	private static MontgomeryDivisorData CreateMontgomeryDivisorData(ulong modulus)
-	{
-		if (modulus <= 1UL || (modulus & 1UL) == 0UL)
-		{
-			return new MontgomeryDivisorData(modulus, 0UL, 0UL, 0UL, 0UL);
-		}
-
-		ulong nPrime = ComputeMontgomeryNPrime(modulus);
-		ulong montgomeryOne = ComputeMontgomeryResidue(1UL, modulus);
-		ulong montgomeryTwo = ComputeMontgomeryResidue(2UL, modulus);
-		ulong montgomeryTwoSquared = ULongExtensions.MontgomeryMultiply(montgomeryTwo, montgomeryTwo, modulus, nPrime);
-
-		return new MontgomeryDivisorData(
-			modulus,
-			nPrime,
-			montgomeryOne,
-			montgomeryTwo,
-			montgomeryTwoSquared);
-	}
+        return checksum;
+    }
 
 
-	private ulong CalculateCycleLengthWithHeuristics(ulong modulus, ulong fallbackOrder = 0UL)
-	{
-		MontgomeryDivisorData divisorData = MontgomeryDivisorData.FromModulus(modulus);
-		if (modulus <= 1UL || (modulus & 1UL) == 0UL)
-		{
-			return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus, divisorData);
-		}
+    [Benchmark]
+    public ulong MontgomeryWithHeuristicCycleComputation()
+    {
+        GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out _);
+        ulong checksum = 0UL;
 
-		// When the below is uncommented, the benchmark never completes due to the primality test cost on very large random set.
+        for (int i = 0; i < SampleCount; i++)
+        {
+            ulong cycle = CalculateCycleLengthWithHeuristics(divisors[i].Modulus);
+            checksum ^= exponents[i].Pow2MontgomeryModWithCycle(cycle, divisors[i]);
+        }
 
-		// bool isPrime = Open.Numeric.Primes.Prime.Numbers.IsPrime(modulus);
-		// // bool isPrime = PrimeTester.IsPrimeInternal(modulus, CancellationToken.None);
-		// if (!isPrime)
-		// {
-		//     return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus);
-		// }
+        return checksum;
+    }
+
+    [Benchmark]
+    public UInt128 HeuristicWideCycleComputation()
+    {
+        UInt128 checksum = UInt128.Zero;
+
+        for (int i = 0; i < SampleCount; i++)
+        {
+            UInt128 cycle = CalculateCycleLengthWithHeuristics(_wideModuli[i]);
+            _wideCycles[i] = cycle;
+            checksum ^= cycle;
+        }
+
+        return checksum;
+    }
+
+    private void GetData(out ulong[] exponents, out MontgomeryDivisorData[] divisors, out ulong[] cycles)
+    {
+        switch (Scale)
+        {
+            case InputScale.Small:
+                exponents = _smallExponents;
+                divisors = _smallDivisors;
+                cycles = _smallCycles;
+                break;
+            case InputScale.Large:
+                exponents = _largeExponents;
+                divisors = _largeDivisors;
+                cycles = _largeCycles;
+                break;
+            case InputScale.VeryLarge:
+                exponents = _veryLargeExponents;
+                divisors = _veryLargeDivisors;
+                cycles = _veryLargeCycles;
+                break;
+            default:
+                throw new ArgumentOutOfRangeException(nameof(Scale), Scale, null);
+        }
+    }
+
+    private ulong NextSmallExponent() => (ulong)_random.NextInt64(1L, 1_000_000L);
+
+    private ulong NextLargeExponent() => (ulong)_random.NextInt64(OneShiftedLeft60, long.MaxValue);
+
+    private ulong NextVeryLargeExponent()
+    {
+        Span<byte> buffer = stackalloc byte[8];
+        _random.NextBytes(buffer);
+        ulong value = checked(BinaryPrimitives.ReadUInt64LittleEndian(buffer) | OneShiftedLeft63);
+        return value;
+    }
+
+    private ulong NextSmallOddModulus()
+    {
+        ulong value = (ulong)_random.NextInt64(3L, 1_000_000L);
+        return value | 1UL;
+    }
+
+    private (ulong modulus, ulong cycleLength) NextLargeModulusAndCycle()
+    {
+        int bitLength = _random.Next(48, 64);
+        ulong modulus = (1UL << bitLength) - 1UL;
+        return (modulus, (ulong)bitLength);
+    }
+
+    private ulong NextVeryLargeOddModulus()
+    {
+        Span<byte> buffer = stackalloc byte[8];
+        _random.NextBytes(buffer);
+        ulong value = BinaryPrimitives.ReadUInt64LittleEndian(buffer) | OneShiftedLeft63 | 1UL;
+        return value;
+    }
+
+    private UInt128 NextWideOddModulus()
+    {
+        Span<byte> buffer = stackalloc byte[16];
+        _random.NextBytes(buffer);
+        ulong low = BinaryPrimitives.ReadUInt64LittleEndian(buffer);
+        Span<byte> highSlice = buffer.Slice(8, 8);
+        ulong high = BinaryPrimitives.ReadUInt64LittleEndian(highSlice) | (1UL << 63);
+        UInt128 value = ((UInt128)high << 64) | low;
+        return value | UInt128.One;
+    }
+
+    private static MontgomeryDivisorData CreateMontgomeryDivisorData(ulong modulus)
+    {
+        if (modulus <= 1UL || (modulus & 1UL) == 0UL)
+        {
+            return new MontgomeryDivisorData(modulus, 0UL, 0UL, 0UL, 0UL);
+        }
+
+        ulong nPrime = ComputeMontgomeryNPrime(modulus);
+        ulong montgomeryOne = ComputeMontgomeryResidue(1UL, modulus);
+        ulong montgomeryTwo = ComputeMontgomeryResidue(2UL, modulus);
+        ulong montgomeryTwoSquared = ULongExtensions.MontgomeryMultiply(montgomeryTwo, montgomeryTwo, modulus, nPrime);
+
+        return new MontgomeryDivisorData(
+            modulus,
+            nPrime,
+            montgomeryOne,
+            montgomeryTwo,
+            montgomeryTwoSquared);
+    }
+
+
+    private ulong CalculateCycleLengthWithHeuristics(ulong modulus, ulong fallbackOrder = 0UL)
+    {
+        MontgomeryDivisorData divisorData = MontgomeryDivisorData.FromModulus(modulus);
+        if (modulus <= 1UL || (modulus & 1UL) == 0UL)
+        {
+            return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus, divisorData);
+        }
+
+        // When the below is uncommented, the benchmark never completes due to the primality test cost on very large random set.
+
+        // bool isPrime = Open.Numeric.Primes.Prime.Numbers.IsPrime(modulus);
+        // // bool isPrime = PrimeTester.IsPrimeInternal(modulus, CancellationToken.None);
+        // if (!isPrime)
+        // {
+        //     return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus);
+        // }
 
 #if DEBUG
-		Console.WriteLine("Trying heuristic. Prime order calculation");
+        Console.WriteLine("Trying heuristic. Prime order calculation");
 #endif
-		ulong order = PrimeOrderCalculator.Calculate(
-			modulus,
-			_previousPrimeOrder,
-			divisorData,
-			PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
-			PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+        PrimeOrderCalculator.PrimeOrderResult orderResult = PrimeOrderCalculator.Calculate(
+            modulus,
+            _previousPrimeOrder,
+            divisorData,
+            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-		if (order != 0UL)
-		{
-			_previousPrimeOrder = order;
-			return order;
-		}
+        if (orderResult.Order != 0UL)
+        {
+            _previousPrimeOrder = orderResult.Order;
+            return orderResult.Order;
+        }
 
-		_previousPrimeOrder = null;
+        _previousPrimeOrder = null;
 
-		Console.WriteLine($"Heuristic failed for {modulus}, falling back to full cycle calculation");
-		return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus, divisorData);
-	}
+        Console.WriteLine($"Heuristic failed for {modulus}, falling back to full cycle calculation");
+        return fallbackOrder != 0UL ? fallbackOrder : MersenneDivisorCycles.CalculateCycleLength(modulus, divisorData);
+    }
 
-	private UInt128 CalculateCycleLengthWithHeuristics(UInt128 modulus)
-	{
-		if (modulus <= UInt128.One || (modulus & UInt128.One) == UInt128.Zero)
-		{
-			return MersenneDivisorCycles.GetCycle(modulus);
-		}
+    private UInt128 CalculateCycleLengthWithHeuristics(UInt128 modulus)
+    {
+        if (modulus <= UInt128.One || (modulus & UInt128.One) == UInt128.Zero)
+        {
+            return MersenneDivisorCycles.GetCycle(modulus);
+        }
 
 #if DEBUG
-		Console.WriteLine("Trying heuristic. Wide prime order calculation");
+        Console.WriteLine("Trying heuristic. Wide prime order calculation");
 #endif
-		UInt128 order = PrimeOrderCalculator.Calculate(
-			modulus,
-			_previousWidePrimeOrder,
-			PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
+        PrimeOrderCalculator.PrimeOrderResultWide orderResult = PrimeOrderCalculator.Calculate(
+            modulus,
+            _previousWidePrimeOrder,
+            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-		if (order != UInt128.Zero)
-		{
-			_previousWidePrimeOrder = order;
-			return order;
-		}
+        if (orderResult.Order != UInt128.Zero)
+        {
+            _previousWidePrimeOrder = orderResult.Order;
+            return orderResult.Order;
+        }
 
-		_previousWidePrimeOrder = null;
+        _previousWidePrimeOrder = null;
 
-		Console.WriteLine($"Wide heuristic failed for {modulus}, falling back to full cycle calculation");
-		return MersenneDivisorCycles.GetCycle(modulus);
-	}
+        Console.WriteLine($"Wide heuristic failed for {modulus}, falling back to full cycle calculation");
+        return MersenneDivisorCycles.GetCycle(modulus);
+    }
 
-	private static ulong ComputeMontgomeryResidue(ulong value, ulong modulus) => (ulong)((UInt128)value * (UInt128.One << 64) % modulus);
+    private static ulong ComputeMontgomeryResidue(ulong value, ulong modulus) => (ulong)((UInt128)value * (UInt128.One << 64) % modulus);
 
-	private static ulong ComputeMontgomeryNPrime(ulong modulus)
-	{
-		ulong inv = modulus;
-		inv *= unchecked(2UL - modulus * inv);
-		inv *= unchecked(2UL - modulus * inv);
-		inv *= unchecked(2UL - modulus * inv);
-		inv *= unchecked(2UL - modulus * inv);
-		inv *= unchecked(2UL - modulus * inv);
-		inv *= unchecked(2UL - modulus * inv);
-		return unchecked(0UL - inv);
-	}
+    private static ulong ComputeMontgomeryNPrime(ulong modulus)
+    {
+        ulong inv = modulus;
+        inv *= unchecked(2UL - modulus * inv);
+        inv *= unchecked(2UL - modulus * inv);
+        inv *= unchecked(2UL - modulus * inv);
+        inv *= unchecked(2UL - modulus * inv);
+        inv *= unchecked(2UL - modulus * inv);
+        inv *= unchecked(2UL - modulus * inv);
+        return unchecked(0UL - inv);
+    }
 }
 

EvenPerfectBitScanner.Benchmarks/Pow2MontgomeryModUInt128Benchmarks.cs

@@ -176,7 +176,7 @@ public class Pow2MontgomeryModUInt128Benchmarks
         return (UInt128)result;
     }
 
-    private static bool ShouldUseSingleBit(GpuUInt128 exponent)
+    private static bool ShouldUseSingleBit(in GpuUInt128 exponent)
     {
         if (exponent.High == 0UL && exponent.Low <= Pow2WindowFallbackThreshold)
         {
@@ -257,7 +257,7 @@ public class Pow2MontgomeryModUInt128Benchmarks
         return result;
     }
 
-    private static bool IsBitSet(GpuUInt128 value, int bitIndex)
+    private static bool IsBitSet(in GpuUInt128 value, int bitIndex)
     {
         if (bitIndex >= 64)
         {
@@ -267,7 +267,7 @@ public class Pow2MontgomeryModUInt128Benchmarks
         return ((value.Low >> bitIndex) & 1UL) != 0UL;
     }
 
-    private static ulong ExtractWindowValue(GpuUInt128 exponent, int windowStart, int windowBitCount)
+    private static ulong ExtractWindowValue(in GpuUInt128 exponent, int windowStart, int windowBitCount)
     {
         if (windowStart != 0)
         {

PerfectNumbers.Core.Tests/Gpu/PrimeOrderGpuHeuristicsTests.cs

@@ -359,9 +359,10 @@ public class PrimeOrderGpuHeuristicsTests
             PrimeOrderGpuHeuristics.OverflowRegistry[prime] = 0;
 
             MontgomeryDivisorData divisorData = MontgomeryDivisorData.FromModulus(prime);
-            ulong result = PrimeOrderCalculator.Calculate(prime, null, divisorData, PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault, PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            PrimeOrderCalculator.PrimeOrderResult result = PrimeOrderCalculator.Calculate(prime, null, divisorData, PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-            result.Should().Be(3UL);
+            result.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+            result.Order.Should().Be(3UL);
         }
         finally
         {

PerfectNumbers.Core.Tests/PrimeOrderCalculatorTests.cs

@@ -45,14 +45,14 @@ public class PrimeOrderCalculatorTests
     {
         ulong expected = ComputeOrderByDoubling(prime);
 
-        ulong result = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult result = PrimeOrderCalculator.Calculate(
             prime,
             previousOrder: null,
             MontgomeryDivisorData.FromModulus(prime),
-            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-        result.Should().Be(expected);
+        result.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        result.Order.Should().Be(expected);
     }
 
     [Theory]
@@ -62,21 +62,21 @@ public class PrimeOrderCalculatorTests
     {
         ulong previousOrder = ComputeOrderByDoubling(previousPrime);
 
-        ulong heuristic = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult heuristic = PrimeOrderCalculator.Calculate(
             prime,
             previousOrder,
             MontgomeryDivisorData.FromModulus(prime),
-            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-        ulong strict = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult strict = PrimeOrderCalculator.Calculate(
             prime,
             previousOrder: null,
             MontgomeryDivisorData.FromModulus(prime),
-            PrimeOrderCalculator.PrimeOrderSearchConfig.StrictDefault,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            PrimeOrderCalculator.PrimeOrderSearchConfig.StrictDefault);
 
-        heuristic.Should().Be(strict);
+        heuristic.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        strict.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        heuristic.Order.Should().Be(strict.Order);
     }
 
     [Theory]
@@ -85,14 +85,14 @@ public class PrimeOrderCalculatorTests
     [InlineData(3UL, 2UL)]
     public void Calculate_handles_trivial_primes(ulong prime, ulong expectedOrder)
     {
-        ulong result = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult result = PrimeOrderCalculator.Calculate(
             prime,
             previousOrder: null,
             MontgomeryDivisorData.FromModulus(prime),
-            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-        result.Should().Be(expectedOrder);
+        result.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        result.Order.Should().Be(expectedOrder);
     }
 
     [Fact]
@@ -105,14 +105,14 @@ public class PrimeOrderCalculatorTests
             maxPowChecks: 8,
             mode: PrimeOrderCalculator.PrimeOrderMode.Heuristic);
 
-        ulong result = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult result = PrimeOrderCalculator.Calculate(
             prime: 13UL,
             previousOrder: null,
             MontgomeryDivisorData.FromModulus(13UL),
-            config,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            config);
 
-        result.Should().Be(ComputeOrderByDoubling(13UL));
+        result.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.HeuristicUnresolved);
+        result.Order.Should().Be(ComputeOrderByDoubling(13UL));
     }
 
     [Fact]
@@ -126,14 +126,14 @@ public class PrimeOrderCalculatorTests
             mode: PrimeOrderCalculator.PrimeOrderMode.Heuristic);
 
         MontgomeryDivisorData divisorData = MontgomeryDivisorData.FromModulus(239UL);
-        ulong heuristic = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult heuristic = PrimeOrderCalculator.Calculate(
             prime: 239UL,
             previousOrder: null,
             divisorData,
-            heuristicConfig,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            heuristicConfig);
 
-        heuristic.Should().Be(ComputeOrderByDoubling(239UL));
+        heuristic.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.HeuristicUnresolved);
+        heuristic.Order.Should().Be(ComputeOrderByDoubling(239UL));
 
         var strictConfig = new PrimeOrderCalculator.PrimeOrderSearchConfig(
             smallFactorLimit: 2,
@@ -141,14 +141,14 @@ public class PrimeOrderCalculatorTests
             maxPowChecks: 1,
             mode: PrimeOrderCalculator.PrimeOrderMode.Strict);
 
-        ulong strict = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult strict = PrimeOrderCalculator.Calculate(
             prime: 239UL,
             previousOrder: null,
             divisorData,
-            strictConfig,
-			      PrimeOrderCalculator.PrimeOrderHeuristicDevice.Gpu);
+            strictConfig);
 
-        strict.Should().Be(heuristic);
+        strict.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        strict.Order.Should().Be(heuristic.Order);
     }
 
     [Fact]
@@ -157,12 +157,13 @@ public class PrimeOrderCalculatorTests
     {
         UInt128 prime = UInt128.Parse("18446744073709641691");
 
-        UInt128 result = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResultWide result = PrimeOrderCalculator.Calculate(
             prime,
             previousOrder: null,
             PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault);
 
-        result.Should().Be((UInt128)1229782938247309446UL);
+        result.Status.Should().Be(PrimeOrderCalculator.PrimeOrderStatus.Found);
+        result.Order.Should().Be((UInt128)1229782938247309446UL);
     }
 
     [Fact]

PerfectNumbers.Core/DeterministicRandom.cs

@@ -1,49 +0,0 @@
-using System;
-using System.Threading;
-
-namespace PerfectNumbers.Core;
-
-internal static class DeterministicRandom
-{
-    [ThreadStatic]
-    private static ulong s_threadState;
-
-    private static long s_seedCounter;
-
-    public static ulong NextUInt64()
-    {
-        ulong state = s_threadState;
-        if (state == 0UL)
-        {
-            state = InitializeThreadState();
-        }
-
-        state ^= state >> 12;
-        state ^= state << 25;
-        state ^= state >> 27;
-        s_threadState = state;
-        return state * 2685821657736338717UL;
-    }
-
-    public static UInt128 NextUInt128()
-    {
-        UInt128 high = (UInt128)NextUInt64();
-        UInt128 low = (UInt128)NextUInt64();
-        return (high << 64) | low;
-    }
-
-    private static ulong InitializeThreadState()
-    {
-        ulong seed = (ulong)Interlocked.Increment(ref s_seedCounter);
-        seed += 0x9E3779B97F4A7C15UL;
-        seed = (seed ^ (seed >> 30)) * 0xBF58476D1CE4E5B9UL;
-        seed = (seed ^ (seed >> 27)) * 0x94D049BB133111EBUL;
-        seed ^= seed >> 31;
-        if (seed == 0UL)
-        {
-            seed = 0x9E3779B97F4A7C15UL;
-        }
-
-        return seed;
-    }
-}

PerfectNumbers.Core/ExponentRemainderStepper.cs

@@ -1,20 +1,31 @@
 namespace PerfectNumbers.Core;
 
-internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
+internal struct ExponentRemainderStepper
 {
-    private readonly MontgomeryDivisorData _divisor = divisor;
-    private readonly ulong _modulus = divisor.Modulus;
-    private readonly ulong _nPrime = divisor.NPrime;
-    private readonly ulong _montgomeryOne = divisor.MontgomeryOne;
-    private ulong _previousExponent = 0UL;
-    private ulong _currentMontgomery = divisor.MontgomeryOne;
-    private bool _hasState = false;
+    private readonly MontgomeryDivisorData _divisor;
+    private readonly ulong _modulus;
+    private readonly ulong _nPrime;
+    private readonly ulong _montgomeryOne;
+    private ulong _previousExponent;
+    private ulong _currentMontgomery;
+    private bool _hasState;
 
-	public readonly bool IsValidModulus => _modulus > 1UL && (_modulus & 1UL) != 0UL;
+    public ExponentRemainderStepper(in MontgomeryDivisorData divisor)
+    {
+        _divisor = divisor;
+        _modulus = divisor.Modulus;
+        _nPrime = divisor.NPrime;
+        _montgomeryOne = divisor.MontgomeryOne;
+        _previousExponent = 0UL;
+        _currentMontgomery = divisor.MontgomeryOne;
+        _hasState = false;
+    }
 
-    public readonly bool HasState => _hasState;
+    public bool IsValidModulus => _modulus > 1UL && (_modulus & 1UL) != 0UL;
 
-    public readonly ulong PreviousExponent => _previousExponent;
+    public bool HasState => _hasState;
+
+    public ulong PreviousExponent => _previousExponent;
 
     public void Reset()
     {
@@ -36,7 +47,7 @@ internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
             // TODO: Route these state resets through the ProcessEightBitWindows helper once the scalar
             // Pow2MontgomeryMod implementation adopts it so delta stepping inherits the benchmarked
             // 2× gains for large exponents.
-            _currentMontgomery = exponent.Pow2MontgomeryModWindowedCpu(_divisor, keepMontgomery: true);
+            _currentMontgomery = exponent.Pow2MontgomeryModWindowed(_divisor, keepMontgomery: true);
             _previousExponent = exponent;
             _hasState = true;
             return ReduceCurrent();
@@ -48,7 +59,7 @@ internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
         // cached Montgomery residue ladder highlighted in MersenneDivisorCycleLengthGpuBenchmarks.
         // TODO: Replace this per-delta powmod with the upcoming windowed ladder so incremental
         // updates stop paying the single-bit cost highlighted in GpuPow2ModBenchmarks.
-        ulong multiplier = delta.Pow2MontgomeryModWindowedCpu(_divisor, keepMontgomery: true);
+        ulong multiplier = delta.Pow2MontgomeryModWindowed(_divisor, keepMontgomery: true);
         _currentMontgomery = _currentMontgomery.MontgomeryMultiply(multiplier, _modulus, _nPrime);
         _previousExponent = exponent;
         return ReduceCurrent();
@@ -66,7 +77,7 @@ internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
         {
             // TODO: Switch this reload to the shared windowed pow2 helper once available so CPU
             // residue checks align with the optimized ProcessEightBitWindows timings.
-            _currentMontgomery = exponent.Pow2MontgomeryModWindowedCpu(_divisor, keepMontgomery: true);
+            _currentMontgomery = exponent.Pow2MontgomeryModWindowed(_divisor, keepMontgomery: true);
             _previousExponent = exponent;
             _hasState = true;
             return _currentMontgomery == _montgomeryOne;
@@ -77,7 +88,7 @@ internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
         // lookups so this branch also avoids recomputing powmods when the snapshot lacks the divisor.
         // TODO: Use the windowed delta pow2 helper here as well to avoid the single-bit ladder that
         // currently lags behind the benchmarked implementation for huge divisor cycles.
-        ulong multiplier = delta.Pow2MontgomeryModWindowedCpu(_divisor, keepMontgomery: true);
+        ulong multiplier = delta.Pow2MontgomeryModWindowed(_divisor, keepMontgomery: true);
         _currentMontgomery = _currentMontgomery.MontgomeryMultiply(multiplier, _modulus, _nPrime);
         _previousExponent = exponent;
         return _currentMontgomery == _montgomeryOne;
@@ -112,7 +123,7 @@ internal struct ExponentRemainderStepper(in MontgomeryDivisorData divisor)
         {
             // TODO: Replace this fallback path with the upcoming ProcessEightBitWindows helper so
             // fresh Montgomery states also benefit from the faster pow2 ladder measured on CPUs.
-            _currentMontgomery = exponent.Pow2MontgomeryModWindowedCpu(_divisor, keepMontgomery: true);
+            _currentMontgomery = exponent.Pow2MontgomeryModWindowed(_divisor, keepMontgomery: true);
             _previousExponent = exponent;
             _hasState = true;
             isUnity = _currentMontgomery == _montgomeryOne;

PerfectNumbers.Core/FactorEntry.cs

@@ -1,8 +0,0 @@
-namespace PerfectNumbers.Core
-{
-    public readonly struct FactorEntry(ulong value, int exponent)
-    {
-        public readonly ulong Value = value;
-        public readonly int Exponent = exponent;
-    }
-}

PerfectNumbers.Core/Gpu/GpuUInt128.cs

@@ -267,7 +267,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     public void Add(in ReadOnlyGpuUInt128 other) => AddInternal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Add(GpuUInt128 other) => AddInternal(other.High, other.Low);
+    public void Add(in GpuUInt128 other) => AddInternal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private void AddInternal(ulong otherHigh, ulong otherLow)
@@ -294,17 +294,17 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     public void AddMod(in ReadOnlyGpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => AddModInternal(value.High, value.Low, in modulus);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AddMod(GpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => AddModInternal(value.High, value.Low, in modulus);
+    public void AddMod(in GpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => AddModInternal(value.High, value.Low, in modulus);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AddMod(in ReadOnlyGpuUInt128 value, GpuUInt128 modulus)
+    public void AddMod(in ReadOnlyGpuUInt128 value, in GpuUInt128 modulus)
     {
         ReadOnlyGpuUInt128 readOnlyMod = modulus.AsReadOnly();
         AddModInternal(value.High, value.Low, in readOnlyMod);
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AddMod(GpuUInt128 value, GpuUInt128 modulus)
+    public void AddMod(in GpuUInt128 value, in GpuUInt128 modulus)
     {
         ReadOnlyGpuUInt128 readOnlyMod = modulus.AsReadOnly();
         AddModInternal(value.High, value.Low, in readOnlyMod);
@@ -390,7 +390,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AddMod(GpuUInt128 value, ulong modulus) => AddMod(value.Low, modulus);
+    public void AddMod(in GpuUInt128 value, ulong modulus) => AddMod(value.Low, modulus);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void AddMod(ulong value, ulong modulus)
@@ -414,7 +414,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     public void Sub(in ReadOnlyGpuUInt128 other) => SubInternal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Sub(GpuUInt128 other) => SubInternal(other.High, other.Low);
+    public void Sub(in GpuUInt128 other) => SubInternal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private void SubInternal(ulong otherHigh, ulong otherLow)
@@ -461,7 +461,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     public void Mul64(in ReadOnlyGpuUInt128 other) => Mul64Internal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Mul64(GpuUInt128 other) => Mul64Internal(other.High, other.Low);
+    public void Mul64(in GpuUInt128 other) => Mul64Internal(other.High, other.Low);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private void Mul64Internal(ulong otherHigh, ulong otherLow)
@@ -588,7 +588,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static int TrailingZeroCount(GpuUInt128 value)
+    public static int TrailingZeroCount(in GpuUInt128 value)
     {
         if (value.Low != 0UL)
         {
@@ -646,17 +646,17 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     public void SubMod(in ReadOnlyGpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => SubModInternal(value.High, value.Low, in modulus);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void SubMod(GpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => SubModInternal(value.High, value.Low, in modulus);
+    public void SubMod(in GpuUInt128 value, in ReadOnlyGpuUInt128 modulus) => SubModInternal(value.High, value.Low, in modulus);
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void SubMod(in ReadOnlyGpuUInt128 value, GpuUInt128 modulus)
+    public void SubMod(in ReadOnlyGpuUInt128 value, in GpuUInt128 modulus)
     {
         ReadOnlyGpuUInt128 readOnlyMod = modulus.AsReadOnly();
         SubModInternal(value.High, value.Low, in readOnlyMod);
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void SubMod(GpuUInt128 value, GpuUInt128 modulus)
+    public void SubMod(in GpuUInt128 value, in GpuUInt128 modulus)
     {
         ReadOnlyGpuUInt128 readOnlyMod = modulus.AsReadOnly();
         SubModInternal(value.High, value.Low, in readOnlyMod);
@@ -727,7 +727,7 @@ public struct GpuUInt128 : IComparable<GpuUInt128>, IEquatable<GpuUInt128>
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Mul(GpuUInt128 other)
+    public void Mul(in GpuUInt128 other)
     {
         ReadOnlyGpuUInt128 readOnlyThis = AsReadOnly();
         ReadOnlyGpuUInt128 readOnlyOther = other.AsReadOnly();

PerfectNumbers.Core/Gpu/MersenneNumberDivisorByDivisorGpuTester.cs

@@ -551,7 +551,7 @@ public sealed class MersenneNumberDivisorByDivisorGpuTester : IMersenneNumberDiv
         }
 
         ulong exponent = exponents[index];
-        hits[index] = exponent.Pow2MontgomeryModWindowedGpu(divisor, keepMontgomery: false) == 1UL ? (byte)1 : (byte)0;
+        hits[index] = exponent.Pow2MontgomeryModWindowed(divisor, keepMontgomery: false) == 1UL ? (byte)1 : (byte)0;
     }
 
     public sealed class DivisorScanSession : IMersenneNumberDivisorByDivisorTester.IDivisorScanSession
@@ -770,7 +770,7 @@ public sealed class MersenneNumberDivisorByDivisorGpuTester : IMersenneNumberDiv
 
         ulong exponent = exponents[index];
 
-        results[index] = exponent.Pow2MontgomeryModWindowedGpu(divisor, keepMontgomery: true);
+        results[index] = exponent.Pow2MontgomeryModWindowed(divisor, keepMontgomery: true);
     }
 
     public ulong DivisorLimit

PerfectNumbers.Core/Gpu/PrimeOrderGpuHeuristics.cs

@@ -415,9 +415,9 @@ internal static partial class PrimeOrderGpuHeuristics
         ulong? previousOrder,
         PrimeOrderCalculator.PrimeOrderSearchConfig config,
         in MontgomeryDivisorData divisorData,
-        out ulong order)
+        out PrimeOrderCalculator.PrimeOrderResult result)
     {
-        order = 0UL;
+        result = default;
 
         var lease = GpuKernelPool.GetKernel(useGpuOrder: true);
         var execution = lease.EnterExecutionScope();
@@ -497,17 +497,18 @@ internal static partial class PrimeOrderGpuHeuristics
             throw new InvalidOperationException("GPU Pollard Rho stack overflow; increase HeuristicStackCapacity.");
         }
 
+        ulong order = 0UL;
         resultBuffer.View.CopyToCPU(ref order, 1);
 
-        if (kernelStatus == PrimeOrderKernelStatus.FactoringFailure)
-        {
-            order = 0UL;
-        }
+        PrimeOrderCalculator.PrimeOrderStatus finalStatus = kernelStatus == PrimeOrderKernelStatus.Found
+            ? PrimeOrderCalculator.PrimeOrderStatus.Found
+            : PrimeOrderCalculator.PrimeOrderStatus.HeuristicUnresolved;
 
+        result = new PrimeOrderCalculator.PrimeOrderResult(finalStatus, order);
         DisposeResources();
         lease.Dispose();
 
-        return order != 0UL;
+        return true;
 
         void DisposeResources()
         {
@@ -811,7 +812,7 @@ internal static partial class PrimeOrderGpuHeuristics
             }
 
             ulong reduced = phi / factor;
-            if (reduced.Pow2MontgomeryModWindowedGpu(divisor, keepMontgomery: false) == 1UL)
+            if (reduced.Pow2MontgomeryModWindowed(divisor, keepMontgomery: false) == 1UL)
             {
                 return false;
             }
@@ -1595,7 +1596,7 @@ internal static partial class PrimeOrderGpuHeuristics
 
     private static bool Pow2EqualsOneKernel(ulong exponent, in MontgomeryDivisorData divisor)
     {
-        return exponent.Pow2MontgomeryModWindowedGpu(divisor, keepMontgomery: false) == 1UL;
+        return exponent.Pow2MontgomeryModWindowed(divisor, keepMontgomery: false) == 1UL;
     }
 
     private static ulong CalculateByDoublingKernel(ulong prime)
@@ -1795,7 +1796,7 @@ internal static partial class PrimeOrderGpuHeuristics
             return 0UL;
         }
 
-        return exponent.Pow2MontgomeryModWindowedGpu(divisorData, keepMontgomery: false);
+        return exponent.Pow2MontgomeryModWindowed(divisorData, keepMontgomery: false);
     }
 
     private static Action<AcceleratorStream, Index1D, ArrayView1D<ulong, Stride1D.Dense>, MontgomeryDivisorData, ArrayView1D<ulong, Stride1D.Dense>> GetPow2ModKernel(Accelerator accelerator)
@@ -1811,7 +1812,7 @@ internal static partial class PrimeOrderGpuHeuristics
     private static void Pow2ModKernel(Index1D index, ArrayView1D<ulong, Stride1D.Dense> exponents, MontgomeryDivisorData divisor, ArrayView1D<ulong, Stride1D.Dense> remainders)
     {
         ulong exponent = exponents[index];
-        remainders[index] = exponent.Pow2MontgomeryModWindowedGpu(divisor, keepMontgomery: false);
+        remainders[index] = exponent.Pow2MontgomeryModWindowed(divisor, keepMontgomery: false);
     }
 
     private static Action<AcceleratorStream, Index1D, ArrayView1D<GpuUInt128, Stride1D.Dense>, GpuUInt128, ArrayView1D<GpuUInt128, Stride1D.Dense>> GetPow2ModWideKernel(Accelerator accelerator)

PerfectNumbers.Core/HeuristicFailureLog.cs

@@ -1,98 +0,0 @@
-using System.Collections.Concurrent;
-using System.Globalization;
-using System.Text;
-
-namespace PerfectNumbers.Core
-{
-    internal static class HeuristicFailureLog
-    {
-        private const string LogFileName = "prime-order-heuristic-fallbacks.log";
-        private const int FlushThreshold = 4096;
-        private const int MaxBufferedEntries = 16;
-        private static readonly ThreadLocal<StringBuilder?> s_threadBuilder = new(() => StringBuilderPool.Rent(), trackAllValues: true);
-        private static readonly ThreadLocal<int> s_threadEntryCount = new(() => 0, trackAllValues: true);
-        private static readonly object s_fileLock = new();
-        private static readonly string s_logPath = Path.Combine(AppContext.BaseDirectory, LogFileName);
-        private static readonly UTF8Encoding s_utf8NoBom = new(false);
-
-        static HeuristicFailureLog()
-        {
-            AppDomain.CurrentDomain.ProcessExit += static (_, _) => FlushAll(force: true);
-        }
-
-        public static void Record(ulong prime, ulong? candidateOrder, HeuristicFailureReason reason)
-        {
-            string primeText = prime.ToString(CultureInfo.InvariantCulture);
-            string? candidateText = candidateOrder.HasValue ? candidateOrder.Value.ToString(CultureInfo.InvariantCulture) : null;
-            RecordInternal(primeText, candidateText, reason);
-        }
-
-        public static void Record(UInt128 prime, UInt128? candidateOrder, HeuristicFailureReason reason)
-        {
-            string primeText = prime.ToString(CultureInfo.InvariantCulture);
-            string? candidateText = candidateOrder.HasValue ? candidateOrder.Value.ToString(CultureInfo.InvariantCulture) : null;
-            RecordInternal(primeText, candidateText, reason);
-        }
-
-        private static void RecordInternal(string primeText, string? candidateText, HeuristicFailureReason reason)
-        {
-            StringBuilder? existing = s_threadBuilder.Value;
-            StringBuilder builder = existing ?? StringBuilderPool.Rent();
-            int count = s_threadEntryCount.Value + 1;
-            bool forceFlush = count >= MaxBufferedEntries;
-            builder.Append(DateTime.UtcNow.ToString("o", CultureInfo.InvariantCulture));
-            builder.Append(" | prime=");
-            builder.Append(primeText);
-            builder.Append(" | reason=");
-            builder.Append(reason);
-            if (candidateText is not null)
-            {
-                builder.Append(" | candidateOrder=");
-                builder.Append(candidateText);
-            }
-
-            builder.AppendLine();
-            FlushBuilderIfNeeded(builder, forceFlush);
-            if (builder.Length == 0)
-            {
-                count = 0;
-            }
-
-            s_threadEntryCount.Value = count;
-            s_threadBuilder.Value = builder;
-        }
-
-        private static void FlushAll(bool force)
-        {
-            foreach (StringBuilder? builder in s_threadBuilder.Values)
-            {
-                if (builder is not null)
-                {
-                    FlushBuilderIfNeeded(builder, force);
-                }
-            }
-        }
-
-        private static void FlushBuilderIfNeeded(StringBuilder builder, bool force)
-        {
-            if (builder.Length == 0)
-            {
-                return;
-            }
-
-            if (!force && builder.Length < FlushThreshold)
-            {
-                return;
-            }
-
-            string text = builder.ToString();
-            builder.Clear();
-            lock (s_fileLock)
-            {
-                using FileStream stream = new FileStream(s_logPath, FileMode.Append, FileAccess.Write, FileShare.ReadWrite);
-                using StreamWriter writer = new StreamWriter(stream, s_utf8NoBom);
-                writer.Write(text);
-            }
-        }
-    }
-}

PerfectNumbers.Core/HeuristicFailureReason.cs

@@ -1,11 +0,0 @@
-namespace PerfectNumbers.Core
-{
-    internal enum HeuristicFailureReason
-    {
-        PhiPartialFactorizationFailed,
-        StrictModeRequested,
-        HeuristicPipelineUnresolved,
-        HeuristicPipelineAssumedFullOrder,
-    }
-
-}

PerfectNumbers.Core/MersenneDivisorCycles.cs

@@ -1,8 +1,11 @@
 using System.Buffers;
+using System.Buffers.Binary;
 using System.Collections.Generic;
 using System.Numerics;
 using System.Runtime.CompilerServices;
+using System.Security.Cryptography;
 using System.Text;
+using System.Threading;
 using PerfectNumbers.Core.Gpu;
 using ILGPU;
 using ILGPU.Runtime;
@@ -51,15 +54,15 @@ public class MersenneDivisorCycles
         return snapshot;
     }
 
-    public static bool CycleEqualsExponentCpu(ulong divisor, in MontgomeryDivisorData divisorData, ulong exponent)
+    public static bool CycleEqualsExponent(ulong divisor, in MontgomeryDivisorData divisorData, ulong exponent)
     {
         Dictionary<ulong, FactorCacheEntry>? cache = null;
-        return CycleEqualsExponentCpu(divisor, exponent, divisorData, ref cache);
+        return CycleEqualsExponent(divisor, exponent, divisorData, ref cache);
     }
 
-    public static bool CycleEqualsExponentCpu(ulong divisor, ulong exponent, in MontgomeryDivisorData divisorData, ref Dictionary<ulong, FactorCacheEntry>? factorCache)
+    public static bool CycleEqualsExponent(ulong divisor, ulong exponent, in MontgomeryDivisorData divisorData, ref Dictionary<ulong, FactorCacheEntry>? factorCache)
     {
-        if (CycleEqualsExponentForMersenneCandidateCpu(divisor, divisorData, exponent))
+        if (CycleEqualsExponentForMersenneCandidate(divisor, divisorData, exponent))
         {
             return true;
         }
@@ -94,15 +97,15 @@ public class MersenneDivisorCycles
             factorCache = cache;
         }
 
-        if (TryCalculateCycleLengthForExponentCpu(divisor, exponent, divisorData, cache, out ulong cycleLength) && cycleLength != 0UL)
+        if (TryCalculateCycleLengthForExponent(divisor, exponent, divisorData, cache, out ulong cycleLength) && cycleLength != 0UL)
         {
             return cycleLength == exponent;
         }
 
-        return exponent.Pow2MontgomeryModWindowedCpu(divisorData, keepMontgomery: false) == 1UL;
+        return exponent.Pow2MontgomeryModWindowed(divisorData, keepMontgomery: false) == 1UL;
     }
 
-    public static bool CycleEqualsExponentForMersenneCandidateCpu(ulong divisor, in MontgomeryDivisorData divisorData, ulong exponent)
+    public static bool CycleEqualsExponentForMersenneCandidate(ulong divisor, in MontgomeryDivisorData divisorData, ulong exponent)
     {
         if (!IsValidMersenneDivisorCandidate(divisor, exponent))
         {
@@ -123,7 +126,7 @@ public class MersenneDivisorCycles
             }
         }
 
-        return exponent.Pow2MontgomeryModWindowedCpu(divisorData, keepMontgomery: false) == 1UL;
+        return exponent.Pow2MontgomeryModWindowed(divisorData, keepMontgomery: false) == 1UL;
     }
 
     private static bool IsValidMersenneDivisorCandidate(ulong divisor, ulong exponent)
@@ -231,14 +234,14 @@ public class MersenneDivisorCycles
             return (UInt128)cycle;
         }
 
-        UInt128 wideOrder = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResultWide wideResult = PrimeOrderCalculator.Calculate(
             divisor,
             previousOrder: null,
             PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
             PrimeOrderCalculator.PrimeOrderHeuristicDevice.Cpu);
-        if (wideOrder != UInt128.Zero)
+        if (wideResult.Order != UInt128.Zero)
         {
-            return wideOrder;
+            return wideResult.Order;
         }
 
         // Otherwise, find order of 2 mod divisor
@@ -261,7 +264,7 @@ public class MersenneDivisorCycles
         return order;
     }
 
-    public static bool TryCalculateCycleLengthForExponentCpu(
+    public static bool TryCalculateCycleLengthForExponent(
         ulong divisor,        
         ulong exponent,
         in MontgomeryDivisorData divisorData,
@@ -282,15 +285,15 @@ public class MersenneDivisorCycles
             return true;
         }
 
-        ulong order = PrimeOrderCalculator.Calculate(
+        PrimeOrderCalculator.PrimeOrderResult orderResult = PrimeOrderCalculator.Calculate(
             divisor,
             previousOrder: null,
             divisorData,
             PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
             PrimeOrderCalculator.PrimeOrderHeuristicDevice.Cpu);
-        if (order != 0UL)
+        if (orderResult.Order != 0UL)
         {
-            cycleLength = order;
+            cycleLength = orderResult.Order;
             return true;
         }
 
@@ -324,7 +327,7 @@ public class MersenneDivisorCycles
             return false;
         }
 
-        cycleLength = ReduceOrderCpu(divisorData, phi, factorCounts);
+        cycleLength = ReduceOrder(divisorData, phi, factorCounts);
         return true;
     }
 
@@ -468,7 +471,7 @@ public class MersenneDivisorCycles
         }
     }
 
-    private static ulong ReduceOrderCpu(in MontgomeryDivisorData divisorData, ulong initialOrder, Dictionary<ulong, int> factorCounts)
+    private static ulong ReduceOrder(in MontgomeryDivisorData divisorData, ulong initialOrder, Dictionary<ulong, int> factorCounts)
     {
         if (factorCounts.Count == 0)
         {
@@ -502,7 +505,7 @@ public class MersenneDivisorCycles
                     }
 
                     ulong candidate = order / prime;
-                    if (candidate.Pow2MontgomeryModWindowedCpu(divisorData, keepMontgomery: false) == 1UL)
+                    if (candidate.Pow2MontgomeryModWindowed(divisorData, keepMontgomery: false) == 1UL)
                     {
                         order = candidate;
                         continue;
@@ -527,31 +530,20 @@ public class MersenneDivisorCycles
             return 2UL;
         }
 
-        PollardRhoMontgomeryReducer reducer = PollardRhoMontgomeryReducer.Create(n);
-        ulong diff = 0UL;
-        ulong d = 0UL;
-
         while (true)
         {
-            ulong c = (DeterministicRandom.NextUInt64() % (n - 1UL)) + 1UL;
-            ulong xStandard = (DeterministicRandom.NextUInt64() % (n - 2UL)) + 2UL;
-            ulong yStandard = xStandard;
-            ulong cMontgomery = reducer.ConvertToMontgomery(c);
-            ulong xMontgomery = reducer.ConvertToMontgomery(xStandard);
-            ulong yMontgomery = xMontgomery;
-            d = 1UL;
+            ulong c = (NextRandomUInt64() % (n - 1UL)) + 1UL;
+            ulong x = (NextRandomUInt64() % (n - 2UL)) + 2UL;
+            ulong y = x;
+            ulong d = 1UL;
 
             while (d == 1UL)
             {
-                xMontgomery = reducer.Advance(xMontgomery, cMontgomery);
-                xStandard = reducer.AdvanceStandard(xStandard, c);
+                x = AdvancePolynomial(x, c, n);
+                y = AdvancePolynomial(y, c, n);
+                y = AdvancePolynomial(y, c, n);
 
-                yMontgomery = reducer.Advance(yMontgomery, cMontgomery);
-                yStandard = reducer.AdvanceStandard(yStandard, c);
-                yMontgomery = reducer.Advance(yMontgomery, cMontgomery);
-                yStandard = reducer.AdvanceStandard(yStandard, c);
-
-                diff = xStandard > yStandard ? xStandard - yStandard : yStandard - xStandard;
+                ulong diff = x > y ? x - y : y - x;
                 d = BinaryGcd(diff, n);
             }
 
@@ -562,6 +554,13 @@ public class MersenneDivisorCycles
         }
     }
 
+    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+    private static ulong AdvancePolynomial(ulong x, ulong c, ulong modulus)
+    {
+        UInt128 value = (UInt128)x * x + c;
+        return (ulong)(value % modulus);
+    }
+
     private static ulong BinaryGcd(ulong a, ulong b)
     {
         if (a == 0UL)
@@ -593,6 +592,13 @@ public class MersenneDivisorCycles
         }
     }
 
+    private static ulong NextRandomUInt64()
+    {
+        Span<byte> buffer = stackalloc byte[8];
+        RandomNumberGenerator.Fill(buffer);
+        return BinaryPrimitives.ReadUInt64LittleEndian(buffer);
+    }
+
     public readonly struct FactorCacheEntry
     {
         public FactorCacheEntry(ulong[] primes, byte[] exponents, int count)
@@ -934,15 +940,15 @@ public class MersenneDivisorCycles
 
         if (PrimeTester.IsPrimeInternal(divisor, CancellationToken.None))
         {
-            ulong order = PrimeOrderCalculator.Calculate(
+            PrimeOrderCalculator.PrimeOrderResult orderResult = PrimeOrderCalculator.Calculate(
                     divisor,
                     previousOrder: null,
                     divisorData,
                     PrimeOrderCalculator.PrimeOrderSearchConfig.HeuristicDefault,
                     PrimeOrderCalculator.PrimeOrderHeuristicDevice.Cpu);
-            if (order != 0UL)
+            if (orderResult.Order != 0UL)
             {
-                cycleLength = order;
+                cycleLength = orderResult.Order;
                 return true;
             }
         }

PerfectNumbers.Core/MersenneNumberDivisorByDivisorTester.cs

@@ -26,6 +26,8 @@ public static class MersenneNumberDivisorByDivisorTester
             return;
         }
 
+        _ = threadCount;
+
         candidates.Sort();
         Span<ulong> candidateSpan = CollectionsMarshal.AsSpan(candidates);
         int candidateCount = candidateSpan.Length;
@@ -36,65 +38,34 @@ public static class MersenneNumberDivisorByDivisorTester
         if (previousResults is not null && previousResults.Count > 0)
         {
             int recordedCount = previousResults.Count;
-            bool preferSortedMerge = recordedCount <= 4096 || (recordedCount * 4L) <= candidateCount;
-            if (preferSortedMerge)
+            ulong[] recordedCandidates = ArrayPool<ulong>.Shared.Rent(recordedCount);
+            try
             {
-                ulong[] recordedCandidates = ArrayPool<ulong>.Shared.Rent(recordedCount);
-                try
+                Span<ulong> recordedSpan = recordedCandidates.AsSpan(0, recordedCount);
+                int recordedIndex = 0;
+                foreach (ulong value in previousResults.Keys)
                 {
-                    Span<ulong> recordedSpan = recordedCandidates.AsSpan(0, recordedCount);
-                    int recordedIndex = 0;
-                    foreach (ulong value in previousResults.Keys)
-                    {
-                        recordedSpan[recordedIndex++] = value;
-                    }
-
-                    recordedSpan.Sort();
-
-                    int writeIndex = 0;
-                    int skipIndex = 0;
-
-                    for (int readIndex = 0; readIndex < candidateCount; readIndex++)
-                    {
-                        ulong candidate = candidateSpan[readIndex];
-
-                        while (skipIndex < recordedCount && recordedSpan[skipIndex] < candidate)
-                        {
-                            skipIndex++;
-                        }
-
-                        if (skipIndex < recordedCount && recordedSpan[skipIndex] == candidate)
-                        {
-                            skippedByPreviousResults++;
-                            skipIndex++;
-                            continue;
-                        }
-
-                        candidateSpan[writeIndex++] = candidate;
-                    }
-
-                    if (writeIndex < candidateCount)
-                    {
-                        candidates.RemoveRange(writeIndex, candidateCount - writeIndex);
-                        candidateSpan = CollectionsMarshal.AsSpan(candidates); // candidateSpan now tracks the reduced list.
-                        candidateCount = candidateSpan.Length;
-                    }
+                    recordedSpan[recordedIndex++] = value;
                 }
-                finally
-                {
-                    ArrayPool<ulong>.Shared.Return(recordedCandidates, clearArray: true);
-                }
-            }
-            else
-            {
+
+                recordedSpan.Sort();
+
                 int writeIndex = 0;
+                int skipIndex = 0;
+
                 for (int readIndex = 0; readIndex < candidateCount; readIndex++)
                 {
                     ulong candidate = candidateSpan[readIndex];
 
-                    if (previousResults.ContainsKey(candidate))
+                    while (skipIndex < recordedCount && recordedSpan[skipIndex] < candidate)
+                    {
+                        skipIndex++;
+                    }
+
+                    if (skipIndex < recordedCount && recordedSpan[skipIndex] == candidate)
                     {
                         skippedByPreviousResults++;
+                        skipIndex++;
                         continue;
                     }
 
@@ -104,10 +75,14 @@ public static class MersenneNumberDivisorByDivisorTester
                 if (writeIndex < candidateCount)
                 {
                     candidates.RemoveRange(writeIndex, candidateCount - writeIndex);
-                    candidateSpan = CollectionsMarshal.AsSpan(candidates); // candidateSpan now tracks the reduced list.
+                    candidateSpan = CollectionsMarshal.AsSpan(candidates);
                     candidateCount = candidateSpan.Length;
                 }
             }
+            finally
+            {
+                ArrayPool<ulong>.Shared.Return(recordedCandidates, clearArray: true);
+            }
         }
 
         if (skippedByPreviousResults > 0)
@@ -288,32 +263,7 @@ public static class MersenneNumberDivisorByDivisorTester
                 MaxDegreeOfParallelism = workerCount
             };
 
-            primeCount = filteredPrimes.Count; // Reusing primeCount to track the filtered count.
-            int primesPerWorker = (primeCount + workerCount - 1) / workerCount;
-
-            Parallel.For(
-                    0,
-                    workerCount,
-                    options,
-                    workerIndex =>
-                    {
-                        int start = workerIndex * primesPerWorker;
-                        if (start >= primeCount)
-                        {
-                            return;
-                        }
-
-                        int end = start + primesPerWorker;
-                        if (end > primeCount)
-                        {
-                            end = primeCount;
-                        }
-
-                        for (int i = start; i < end; i++)
-                        {
-                            ProcessPrime(filteredPrimes[i]);
-                        }
-                    });
+            Parallel.ForEach(filteredPrimes, options, ProcessPrime);
         }
     }
 }

PerfectNumbers.Core/MersennePrimeFactorTester.cs

@@ -371,6 +371,10 @@ public static class MersennePrimeFactorTester
             return 2UL;
         }
 
+        var rng = new Random(1234567); // TODO: Replace this RNG with the deterministic span-based
+                                       // sequence measured faster in PollardRhoBenchmarks so we avoid
+                                       // per-call Random allocations.
+
         ulong c, d, x, y, diff;
         while (true)
         {
@@ -379,8 +383,8 @@ public static class MersennePrimeFactorTester
                 return 0UL;
             }
 
-            c = (DeterministicRandom.NextUInt64() % (n - 1UL)) + 1UL;
-            x = (DeterministicRandom.NextUInt64() % (n - 2UL)) + 2UL;
+            c = (ulong)rng.Next(2, int.MaxValue);
+            x = (ulong)rng.Next(2, int.MaxValue);
             y = x;
             d = 1UL;
 
@@ -519,6 +523,9 @@ public static class MersennePrimeFactorTester
             return 2;
         }
 
+        var rng = new Random(1234567); // TODO: Replace with the deterministic UInt128 sequence from
+                                       // PollardRho128Benchmarks so we eliminate Random allocations.
+
         UInt128 c, d, x, y, diff;
         while (true)
         {
@@ -527,8 +534,8 @@ public static class MersennePrimeFactorTester
                 return 0;
             }
 
-            c = (DeterministicRandom.NextUInt128() % (n - 1)) + 1;
-            x = (DeterministicRandom.NextUInt128() % (n - 2)) + 2;
+            c = (UInt128)rng.NextInt64(2, long.MaxValue);
+            x = (UInt128)rng.NextInt64(2, long.MaxValue);
             y = x;
             d = 1;
 

PerfectNumbers.Core/PartialFactorResult.cs

@@ -1,76 +0,0 @@
-using System.Buffers;
-
-namespace PerfectNumbers.Core
-{
-    public sealed class PartialFactorResult
-    {
-        [ThreadStatic]
-        private static PartialFactorResult? s_poolHead;
-
-        public FactorEntry[]? Factors;
-        private PartialFactorResult? _next;
-        public ulong Cofactor;
-        public bool FullyFactored;
-        public int Count;
-
-        private PartialFactorResult()
-        {
-        }
-
-		public static PartialFactorResult Rent(in FactorEntry[]? factors, ulong cofactor, bool fullyFactored, int count)
-		{
-			PartialFactorResult? instance = s_poolHead;
-			if (instance is null)
-			{
-				instance = new();
-			}
-			else
-			{
-				s_poolHead = instance._next;
-			}
-
-			instance._next = null;
-			instance.Factors = factors;
-			instance.Cofactor = cofactor;
-			instance.FullyFactored = fullyFactored;
-			instance.Count = count;
-			return instance;
-		}
-
-		public static readonly PartialFactorResult Empty = new() { Cofactor = 1UL, FullyFactored = true };
-
-        public PartialFactorResult WithAdditionalPrime(ulong prime)
-        {
-            FactorEntry[]? source = Factors;
-            if (source is null || Count == 0)
-            {
-                FactorEntry[] local = ArrayPool<FactorEntry>.Shared.Rent(1);
-                local[0] = new FactorEntry(prime, 1);
-                return Rent(local, 1UL, true, 1);
-            }
-
-            FactorEntry[] extended = ArrayPool<FactorEntry>.Shared.Rent(Count + 1);
-            Array.Copy(source, 0, extended, 0, Count);
-            extended[Count] = new FactorEntry(prime, 1);
-            Span<FactorEntry> span = extended.AsSpan(0, Count + 1);
-            span.Sort(static (a, b) => a.Value.CompareTo(b.Value));
-            return Rent(extended, 1UL, true, Count + 1);
-        }
-
-        public void Dispose()
-		{
-			if (this != Empty)
-			{
-				FactorEntry[]? factors = Factors;
-				if (factors is not null)
-				{
-					Factors = null;
-					ArrayPool<FactorEntry>.Shared.Return(factors, clearArray: false);
-				}
-
-				_next = s_poolHead;
-				s_poolHead = this;
-			}
-        }
-    }
-}

PerfectNumbers.Core/PerfectNumberConstants.cs

@@ -8,7 +8,6 @@ public static class PerfectNumberConstants
     public const int MaxQForDivisorCycles = 4_000_000;
     public static readonly uint PrimesLimit = 1_000_000; //(ulong)Array.MaxLength;// 1_000_000;
     public const int MaxOddPowersCount = 128;
-    public const int PooledArrayThreshold = 64;
     // TODO: Load these limits from the benchmark-driven configuration so CPU and GPU scans stay aligned with the optimal
     // divisor-cycle datasets we generate offline.
     // TODO: Promote these magic numbers into a runtime profile derived from EvenPerfectBitScanner.Benchmarks so we can retune

PerfectNumbers.Core/PollardRhoMontgomeryReducer.cs

@@ -1,119 +0,0 @@
-using System;
-using System.Runtime.CompilerServices;
-
-namespace PerfectNumbers.Core;
-
-internal readonly struct PollardRhoMontgomeryReducer
-{
-    private readonly MontgomeryDivisorData _divisorData;
-    private readonly ulong _reciprocal;
-
-    [ThreadStatic]
-    private static bool s_hasCachedReciprocal;
-
-    [ThreadStatic]
-    private static ulong s_cachedReciprocal;
-
-    public PollardRhoMontgomeryReducer(in MontgomeryDivisorData divisorData, ulong reciprocal)
-    {
-        _divisorData = divisorData;
-        _reciprocal = reciprocal == 0UL || reciprocal == ulong.MaxValue
-            ? ReciprocalMath.ComputeReciprocalEstimate(divisorData.Modulus)
-            : reciprocal;
-    }
-
-    public ulong Modulus => _divisorData.Modulus;
-    private ulong NPrime => _divisorData.NPrime;
-    private ulong MontgomeryTwoSquared => _divisorData.MontgomeryTwoSquared;
-    private ulong MontgomeryOne => _divisorData.MontgomeryOne;
-    private ulong MontgomeryTwo => _divisorData.MontgomeryTwo;
-    public ulong Reciprocal => _reciprocal;
-
-    public static PollardRhoMontgomeryReducer Create(ulong modulus)
-    {
-        MontgomeryDivisorData divisorData = MontgomeryDivisorDataCache.Get(modulus);
-        ulong reciprocal;
-        if (s_hasCachedReciprocal)
-        {
-            reciprocal = ReciprocalMath.RefineReciprocalEstimate(s_cachedReciprocal, modulus);
-            if (reciprocal == 0UL || reciprocal == ulong.MaxValue)
-            {
-                reciprocal = ReciprocalMath.ComputeReciprocalEstimate(modulus);
-            }
-        }
-        else
-        {
-            reciprocal = ReciprocalMath.ComputeReciprocalEstimate(modulus);
-        }
-
-        s_cachedReciprocal = reciprocal;
-        s_hasCachedReciprocal = true;
-        return new PollardRhoMontgomeryReducer(divisorData, reciprocal);
-    }
-
-    public static PollardRhoMontgomeryReducer Create(in MontgomeryDivisorData divisorData, ulong previousReciprocal)
-    {
-        ulong reciprocal = ReciprocalMath.RefineReciprocalEstimate(previousReciprocal, divisorData.Modulus);
-        if (reciprocal == 0UL || reciprocal == ulong.MaxValue)
-        {
-            reciprocal = ReciprocalMath.ComputeReciprocalEstimate(divisorData.Modulus);
-        }
-
-        s_cachedReciprocal = reciprocal;
-        s_hasCachedReciprocal = true;
-        return new PollardRhoMontgomeryReducer(divisorData, reciprocal);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public ulong ConvertToMontgomery(ulong value)
-    {
-        if (value == 0UL)
-        {
-            return 0UL;
-        }
-
-        if (value == 1UL)
-        {
-            return MontgomeryOne;
-        }
-
-        if (value == 2UL)
-        {
-            return MontgomeryTwo;
-        }
-
-        return value.MontgomeryMultiply(MontgomeryTwoSquared, Modulus, NPrime);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public ulong ReduceFromMontgomery(ulong montgomeryValue)
-    {
-        return montgomeryValue.MontgomeryMultiply(1UL, Modulus, NPrime);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public ulong Advance(ulong montgomeryValue, ulong cMontgomery)
-    {
-        ulong squared = montgomeryValue.MontgomeryMultiply(montgomeryValue, Modulus, NPrime);
-        return MontgomeryAdd(squared, cMontgomery, Modulus);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public ulong AdvanceStandard(ulong standardValue, ulong c)
-    {
-        UInt128 polynomial = (UInt128)standardValue * standardValue + c;
-        return ReciprocalMath.Reduce(polynomial, Modulus, _reciprocal);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static ulong MontgomeryAdd(ulong a, ulong b, ulong modulus)
-    {
-        UInt128 total = (UInt128)a + b;
-        if (total >= modulus)
-        {
-            total -= modulus;
-        }
-
-        return (ulong)total;
-    }
-}

PerfectNumbers.Core/PrimeOrderCalculator.Wide.cs

@@ -9,18 +9,30 @@ namespace PerfectNumbers.Core;
 
 internal static partial class PrimeOrderCalculator
 {
-    public static UInt128 Calculate(UInt128 prime, UInt128? previousOrder, PrimeOrderSearchConfig config)
+    internal readonly struct PrimeOrderResultWide
+    {
+        public PrimeOrderResultWide(PrimeOrderStatus status, UInt128 order)
+        {
+            Status = status;
+            Order = order;
+        }
+
+        public PrimeOrderStatus Status { get; }
+
+        public UInt128 Order { get; }
+    }
+
+    public static PrimeOrderResultWide Calculate(UInt128 prime, UInt128? previousOrder, PrimeOrderSearchConfig config)
         => Calculate(prime, previousOrder, config, PrimeOrderHeuristicDevice.Gpu);
 
-    public static UInt128 Calculate(
+    public static PrimeOrderResultWide Calculate(
         UInt128 prime,
         UInt128? previousOrder,
         PrimeOrderSearchConfig config,
         PrimeOrderHeuristicDevice device)
     {
-        var scope = UsePow2Mode(device);
+        using var scope = UsePow2Mode(device);
         MontgomeryDivisorData divisorData;
-        UInt128 result;
         if (prime <= ulong.MaxValue)
         {
             ulong? previous = null;
@@ -39,49 +51,41 @@ internal static partial class PrimeOrderCalculator
 
             ulong prime64 = (ulong)prime;
             divisorData = MontgomeryDivisorData.FromModulus(prime64);
-            ulong order64 = Calculate(prime64, previous, divisorData, config, device);
-            result = order64 == 0UL ? UInt128.Zero : (UInt128)order64;
+            PrimeOrderResult result = Calculate(prime64, previous, divisorData, config, device);
+            return new PrimeOrderResultWide(result.Status, result.Order);
         }
         else
         {
             divisorData = default;
-            result = CalculateWideInternal(prime, previousOrder, divisorData, config);
         }
 
-        scope.Dispose();
-        return result;
+        return CalculateWideInternal(prime, previousOrder, divisorData, config);
     }
 
-    private static UInt128 CalculateWideInternal(UInt128 prime, UInt128? previousOrder, in MontgomeryDivisorData divisorData, PrimeOrderSearchConfig config)
+    private static PrimeOrderResultWide CalculateWideInternal(UInt128 prime, UInt128? previousOrder, in MontgomeryDivisorData divisorData, PrimeOrderSearchConfig config)
     {
         if (prime <= UInt128.One)
         {
-            return UInt128.One;
+            return new PrimeOrderResultWide(PrimeOrderStatus.Found, UInt128.One);
         }
 
         if (prime == (UInt128)3UL)
         {
-            return (UInt128)2UL;
+            return new PrimeOrderResultWide(PrimeOrderStatus.Found, (UInt128)2UL);
         }
 
         UInt128 phi = prime - UInt128.One;
-        var debugScope = UseDebugLogging(!IsGpuHeuristicDevice);
+        using var debugScope = UseDebugLogging(!IsGpuHeuristicDevice);
         PartialFactorResult128 phiFactors = PartialFactorWide(phi, config);
-        UInt128 result;
         if (phiFactors.Factors is null)
         {
-            result = FinishStrictlyWide(prime, divisorData);
-        }
-        else
-        {
-            result = RunHeuristicPipelineWide(prime, previousOrder, divisorData, config, phi, phiFactors);
+            return FinishStrictlyWide(prime, divisorData, config.Mode);
         }
 
-        debugScope.Dispose();
-        return result;
+        return RunHeuristicPipelineWide(prime, previousOrder, divisorData, config, phi, phiFactors);
     }
 
-    private static UInt128 RunHeuristicPipelineWide(
+    private static PrimeOrderResultWide RunHeuristicPipelineWide(
         UInt128 prime,
         UInt128? previousOrder,
         in MontgomeryDivisorData divisorData,
@@ -91,7 +95,7 @@ internal static partial class PrimeOrderCalculator
     {
         if (phiFactors.FullyFactored && TrySpecialMaxWide(phi, prime, divisorData, phiFactors))
         {
-            return phi;
+            return new PrimeOrderResultWide(PrimeOrderStatus.Found, phi);
         }
 
         UInt128 candidateOrder = InitializeStartingOrderWide(prime, phi, divisorData);
@@ -99,25 +103,27 @@ internal static partial class PrimeOrderCalculator
 
         if (TryConfirmOrderWide(prime, candidateOrder, divisorData, config))
         {
-            return candidateOrder;
+            return new PrimeOrderResultWide(PrimeOrderStatus.Found, candidateOrder);
         }
 
         if (config.Mode == PrimeOrderMode.Strict)
         {
-            return FinishStrictlyWide(prime, divisorData);
+            return FinishStrictlyWide(prime, divisorData, PrimeOrderMode.Strict);
         }
 
         if (TryHeuristicFinishWide(prime, candidateOrder, previousOrder, divisorData, config, out UInt128 order))
         {
-            return order;
+            return new PrimeOrderResultWide(PrimeOrderStatus.Found, order);
         }
 
-        return candidateOrder;
+        return FinishStrictlyWide(prime, divisorData, config.Mode);
     }
 
-    private static UInt128 FinishStrictlyWide(UInt128 prime, in MontgomeryDivisorData divisorData)
+    private static PrimeOrderResultWide FinishStrictlyWide(UInt128 prime, in MontgomeryDivisorData divisorData, PrimeOrderMode mode)
     {
-        return CalculateByFactorizationWide(prime, divisorData);
+        UInt128 strictOrder = CalculateByFactorizationWide(prime, divisorData);
+        PrimeOrderStatus status = mode == PrimeOrderMode.Strict ? PrimeOrderStatus.Found : PrimeOrderStatus.HeuristicUnresolved;
+        return new PrimeOrderResultWide(status, strictOrder);
     }
 
     private static bool TrySpecialMaxWide(UInt128 phi, UInt128 prime, in MontgomeryDivisorData divisorData, PartialFactorResult128 factors)

PerfectNumbers.Core/ReciprocalMath.cs

@@ -1,125 +0,0 @@
-using System.Numerics;
-using System.Runtime.CompilerServices;
-
-namespace PerfectNumbers.Core;
-
-internal static class ReciprocalMath
-{
-    private const int ReciprocalShift = 64;
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong ComputeReciprocalEstimate(ulong divisor)
-    {
-        if (divisor <= 1UL)
-        {
-            return ulong.MaxValue;
-        }
-
-        UInt128 scaledOne = UInt128.One << ReciprocalShift;
-        UInt128 estimate = scaledOne / divisor;
-        if ((scaledOne % divisor) != UInt128.Zero)
-        {
-            estimate += UInt128.One;
-        }
-
-        if (estimate == UInt128.Zero)
-        {
-            return 1UL;
-        }
-
-        if (estimate > ulong.MaxValue)
-        {
-            return ulong.MaxValue;
-        }
-
-        return (ulong)estimate;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong RefineReciprocalEstimate(ulong reciprocal, ulong divisor)
-    {
-        if (divisor <= 1UL)
-        {
-            return ulong.MaxValue;
-        }
-
-        if (reciprocal == 0UL || reciprocal == ulong.MaxValue)
-        {
-            return ComputeReciprocalEstimate(divisor);
-        }
-
-        UInt128 reciprocal128 = reciprocal;
-        UInt128 product = (UInt128)divisor * reciprocal128;
-        UInt128 scaled = product >> ReciprocalShift;
-        UInt128 twoScaled = UInt128.One << (ReciprocalShift + 1);
-        if (scaled >= twoScaled)
-        {
-            return ComputeReciprocalEstimate(divisor);
-        }
-
-        UInt128 correction = twoScaled - scaled;
-        UInt128 refined = (reciprocal128 * correction) >> ReciprocalShift;
-        if (refined == UInt128.Zero)
-        {
-            return 1UL;
-        }
-
-        return refined > ulong.MaxValue ? ulong.MaxValue : (ulong)refined;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong Reduce(UInt128 numerator, ulong divisor, ulong reciprocal)
-    {
-        if (divisor <= 1UL)
-        {
-            return 0UL;
-        }
-
-        if (numerator == UInt128.Zero)
-        {
-            return 0UL;
-        }
-
-        if (reciprocal == 0UL || reciprocal == ulong.MaxValue)
-        {
-            return (ulong)(numerator % divisor);
-        }
-
-        ulong high = (ulong)(numerator >> ReciprocalShift);
-        ulong low = (ulong)numerator;
-
-        if (high >= divisor)
-        {
-            return (ulong)(numerator % divisor);
-        }
-
-        UInt128 highProduct = (UInt128)high * reciprocal;
-        UInt128 lowProduct = (UInt128)low * reciprocal;
-        UInt128 estimate = highProduct + (lowProduct >> ReciprocalShift);
-
-        if (estimate == UInt128.Zero)
-        {
-            return (ulong)(numerator % divisor);
-        }
-
-        UInt128 product = estimate * divisor;
-        while (product > numerator)
-        {
-            if (estimate == UInt128.Zero)
-            {
-                return (ulong)(numerator % divisor);
-            }
-
-            estimate--;
-            product -= divisor;
-        }
-
-        UInt128 remainder = numerator - product;
-        while (remainder >= divisor)
-        {
-            remainder -= divisor;
-        }
-
-        return (ulong)remainder;
-    }
-}

PerfectNumbers.Core/UInt128Extensions.cs

@@ -218,7 +218,7 @@ public static class UInt128Extensions
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static bool IsBitSet(GpuUInt128 value, int bitIndex)
+    private static bool IsBitSet(in GpuUInt128 value, int bitIndex)
     {
         if (bitIndex >= 64)
         {
@@ -229,16 +229,18 @@ public static class UInt128Extensions
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static ulong ExtractWindowValue(GpuUInt128 exponent, int windowStart, int windowBitCount)
+    private static ulong ExtractWindowValue(in GpuUInt128 exponent, int windowStart, int windowBitCount)
     {
-		ulong mask = (1UL << windowBitCount) - 1UL;
         if (windowStart != 0)
         {
-            exponent.ShiftRight(windowStart);
-            return exponent.Low & mask;
+            GpuUInt128 shifted = exponent;
+            shifted.ShiftRight(windowStart);
+            ulong mask = (1UL << windowBitCount) - 1UL;
+            return shifted.Low & mask;
         }
 
-        return exponent.Low & mask;
+        ulong directMask = (1UL << windowBitCount) - 1UL;
+        return exponent.Low & directMask;
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]

PerfectNumbers.Core/ULongExtensions.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Buffers;
 using System.Numerics;
 using System.Runtime.CompilerServices;
 using ILGPU.Algorithms;
@@ -77,7 +76,7 @@ public static class ULongExtensions
     public static ulong MultiplyShiftRightShiftFirst(ulong value, ulong multiplier, int shift)
     {
         ulong high = value >> shift;
-		ulong mask = (1UL << shift) - 1UL;
+        ulong mask = (1UL << shift) - 1UL;
         ulong low = value & mask;
 
         UInt128 highContribution = (UInt128)high * multiplier;
@@ -327,7 +326,7 @@ public static class ULongExtensions
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong Pow2MontgomeryModWindowedCpu(this ulong exponent, in MontgomeryDivisorData divisor, bool keepMontgomery)
+    public static ulong Pow2MontgomeryModWindowed(this ulong exponent, in MontgomeryDivisorData divisor, bool keepMontgomery)
     {
         ulong modulus = divisor.Modulus;
         if (exponent == 0UL)
@@ -346,78 +345,7 @@ public static class ULongExtensions
 
         ulong result = divisor.MontgomeryOne;
         ulong nPrime = divisor.NPrime;
-        ulong[] oddPowers = InitializeMontgomeryOddPowersCpu(divisor, modulus, nPrime, oddPowerCount);
-
-        int index = bitLength - 1;
-		while (index >= 0)
-		{
-			if (((exponent >> index) & 1UL) == 0UL)
-			{
-				result = result.MontgomeryMultiply(result, modulus, nPrime);
-				index--;
-				continue;
-			}
-
-			int windowStart = index - windowSize + 1;
-			if (windowStart < 0)
-			{
-				windowStart = 0;
-			}
-
-			while (((exponent >> windowStart) & 1UL) == 0UL)
-			{
-				windowStart++;
-			}
-
-			int windowLength = index - windowStart + 1;
-			for (int square = 0; square < windowLength; square++)
-			{
-				result = result.MontgomeryMultiply(result, modulus, nPrime);
-			}
-
-			ulong mask = (1UL << windowLength) - 1UL;
-			ulong windowValue = (exponent >> windowStart) & mask;
-			int tableIndex = (int)((windowValue - 1UL) >> 1);
-			ulong multiplier = oddPowers[tableIndex];
-			result = result.MontgomeryMultiply(multiplier, modulus, nPrime);
-
-			index = windowStart - 1;
-		}
-		
-		if (oddPowerCount >= PerfectNumberConstants.PooledArrayThreshold)
-		{
-			ArrayPool<ulong>.Shared.Return(oddPowers);
-		}
-
-        if (keepMontgomery)
-        {
-            return result;
-        }
-
-        return result.MontgomeryMultiply(1UL, modulus, nPrime);
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong Pow2MontgomeryModWindowedGpu(this ulong exponent, in MontgomeryDivisorData divisor, bool keepMontgomery)
-    {
-        ulong modulus = divisor.Modulus;
-        if (exponent == 0UL)
-        {
-            return keepMontgomery ? divisor.MontgomeryOne : 1UL % modulus;
-        }
-
-        if (exponent <= Pow2WindowFallbackThreshold)
-        {
-            return Pow2MontgomeryModSingleBit(exponent, divisor, keepMontgomery);
-        }
-
-        int bitLength = GetPortableBitLength(exponent);
-        int windowSize = GetWindowSize(bitLength);
-        int oddPowerCount = 1 << (windowSize - 1);
-
-        ulong result = divisor.MontgomeryOne;
-        ulong nPrime = divisor.NPrime;
-        ulong[] oddPowers = InitializeMontgomeryOddPowersGpu(divisor, modulus, nPrime, oddPowerCount);
+        ulong[] oddPowers = InitializeMontgomeryOddPowers(divisor, modulus, nPrime, oddPowerCount);
 
         int index = bitLength - 1;
         while (index >= 0)
@@ -533,30 +461,7 @@ public static class ULongExtensions
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static ulong[] InitializeMontgomeryOddPowersCpu(in MontgomeryDivisorData divisor, ulong modulus, ulong nPrime, int oddPowerCount)
-    {
-		ulong[] oddPowers = oddPowerCount < PerfectNumberConstants.PooledArrayThreshold ? new ulong[oddPowerCount] : ArrayPool<ulong>.Shared.Rent(oddPowerCount);
-		
-        oddPowers[0] = divisor.MontgomeryTwo;
-        if (oddPowerCount == 1)
-        {
-            return oddPowers;
-        }
-
-        ulong previous,
-			  square = divisor.MontgomeryTwoSquared;
-
-        for (int i = 1; i < oddPowerCount; i++)
-        {
-            previous = oddPowers[i - 1];
-            oddPowers[i] = previous.MontgomeryMultiply(square, modulus, nPrime);
-        }
-
-        return oddPowers;
-    }
-
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private static ulong[] InitializeMontgomeryOddPowersGpu(in MontgomeryDivisorData divisor, ulong modulus, ulong nPrime, int oddPowerCount)
+    private static ulong[] InitializeMontgomeryOddPowers(in MontgomeryDivisorData divisor, ulong modulus, ulong nPrime, int oddPowerCount)
     {
         ulong[] oddPowers = new ulong[PerfectNumberConstants.MaxOddPowersCount];
         oddPowers[0] = divisor.MontgomeryTwo;
@@ -576,31 +481,17 @@ public static class ULongExtensions
     }
 
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong Pow2MontgomeryModWithCycleCpu(this ulong exponent, ulong cycleLength, in MontgomeryDivisorData divisor)
+    public static ulong Pow2MontgomeryModWithCycle(this ulong exponent, ulong cycleLength, in MontgomeryDivisorData divisor)
     {
         ulong rotationCount = exponent % cycleLength;
-        return Pow2MontgomeryModWindowedCpu(rotationCount, divisor, keepMontgomery: false);
+        return Pow2MontgomeryModWindowed(rotationCount, divisor, keepMontgomery: false);
     }
 
-	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static ulong Pow2MontgomeryModFromCycleRemainderCpu(this ulong reducedExponent, in MontgomeryDivisorData divisor)
-	{
-		return Pow2MontgomeryModWindowedCpu(reducedExponent, divisor, keepMontgomery: false);
-	}
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static ulong Pow2MontgomeryModWithCycleGpu(this ulong exponent, ulong cycleLength, in MontgomeryDivisorData divisor)
+    public static ulong Pow2MontgomeryModFromCycleRemainder(this ulong reducedExponent, in MontgomeryDivisorData divisor)
     {
-        ulong rotationCount = exponent % cycleLength;
-        return Pow2MontgomeryModWindowedGpu(rotationCount, divisor, keepMontgomery: false);
+        return Pow2MontgomeryModWindowed(reducedExponent, divisor, keepMontgomery: false);
     }
-
-	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	public static ulong Pow2MontgomeryModFromCycleRemainderGpu(this ulong reducedExponent, in MontgomeryDivisorData divisor)
-	{
-		return Pow2MontgomeryModWindowedGpu(reducedExponent, divisor, keepMontgomery: false);
-	}
-	
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static UInt128 PowMod(this ulong exponent, UInt128 modulus)
     {

docs/bydivisor_cpu_path.md

@@ -1,196 +0,0 @@
-# CPU `--mersenne=bydivisor` pipeline notes
-
-This document summarizes how the `EvenPerfectBitScanner` executable executes the
-`--mersenne=bydivisor` mode on the CPU, and how the analytic observations we
-derived for the quotients
-
-\[
-Q_k = \frac{N}{d_k}, \qquad d_k = 2pk + 1, \qquad N = 2^p - 1,
-\]
-
-can help us identify concrete optimization opportunities.
-
-## High-level control flow
-
-* `Program.Main` wires `_byDivisorTester` to a CPU implementation whenever the
-  CLI switches resolve to `--mersenne=bydivisor` and
-  `--mersenne-device=cpu`. The CLI also forces a block size of 1 so that the
-  pipeline pushes exponents to the tester one at a time.
-  (`Program.cs`, lines 459-520.)
-* When the mode starts, `RunByDivisorMode` delegates to
-  `MersenneNumberDivisorByDivisorTester.Run`, passing the candidate list from
-  `--filter-p`, the CPU tester instance and the optional replay of previous
-  outcomes. (`Program.cs`, lines 809-826.)
-* `MersenneNumberDivisorByDivisorTester.Run` sorts and deduplicates the
-  candidate exponents, drops the ones already confirmed in prior runs, validates
-  primality with the `Open.Numeric.Primes` enumerator and configures the tester
-  with the largest remaining exponent. (`MersenneNumberDivisorByDivisorTester.cs`,
-  lines 14-162.)
-* For each confirmed prime exponent, the CPU tester computes the largest divisor
-  it needs to probe through `ComputeAllowedMaxDivisor`. If the range is non-empty
-  it enters the `CheckDivisors` loop. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-  lines 83-110 and 161-266.)
-
-## Inner loop behaviour (`CheckDivisors`)
-
-The hot path is the `while (divisor <= limit)` loop in
-`MersenneNumberDivisorByDivisorCpuTester.CheckDivisors`.
-
-1. The loop enumerates divisor candidates of the form `d_k = 2pk + 1` by
-   incrementing `divisor` by `step = 2p` every iteration. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 177-256.)
-2. Small modulus filters track `d_k (mod 3·5·7·8·10·11)` to discard impossible
-   candidates without touching the divisor-cycle cache. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 195-263.)
-3. For every admissible divisor the tester fetches its Montgomery data and the
-   cached cycle length. When the cache does not contain an entry the
-   implementation recomputes the cycle by factoring the divisor. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 223-254.)
-4. A cycle equal to the tested exponent proves divisibility, so the loop aborts
-   as soon as one hit is found. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 241-247.)
-
-`DivisorScanSession.CheckDivisor` follows the same `d_k` progression when a
-batch API is used. It keeps a running Montgomery residue via
-`ExponentRemainderStepper`, but the stepper currently recomputes the delta by
-calling a full `Pow2MontgomeryModWindowed` whenever the exponent jumps.
-(`MersenneNumberDivisorByDivisorCpuTester.cs`, lines 358-405 and
-`ExponentRemainderStepper.cs`, lines 26-95.)
-
-## Where the analytic model fits
-
-The formulas we established for the quotient sequence
-
-\[
-\frac{Q_{k+1}}{Q_k} = \frac{2pk + 1}{2p(k+1) + 1}, \qquad
-Q_k - Q_{k+1} = \frac{N·2p}{(2pk + 1)(2p(k+1) + 1)}
-\]
-
-tell us that the successive quotients and remainders shrink smoothly and that the
-per-step update depends only on the previous `(Q_k, r_k)` state and the next
-`d_{k+1}`. This lines up with several TODO comments that highlight missing
-incremental updates:
-
-* `ExponentRemainderStepper` already caches the previous exponent and a running
-  Montgomery residue, but it falls back to a full modular exponentiation to
-  compute the delta between consecutive divisors. (`ExponentRemainderStepper.cs`,
-  lines 49-72.)
-* `CheckDivisors` rebuilds the Montgomery data for every hit candidate even
-  though the sequence of `d_k` values is strictly monotone.
-
-The quotient identity gives us a way to compute `Δ_k = Q_k - Q_{k+1}` by reading
-`Q_k` and the inexpensive division `(2pQ_k - r_k) / d_{k+1}`. Once we know `Δ_k`
-we can update
-
-\[
-Q_{k+1} = Q_k - Δ_k, \qquad r_{k+1} = r_k - 2p·Q_k + Δ_k · d_{k+1},
-\]
-
-without ever evaluating `2^p mod d_{k+1}` from scratch. Incorporating this into
-`ExponentRemainderStepper` would let the CPU path reuse a single Montgomery state
-across the entire scan and swap the current delta exponentiation (which costs a
-full modular ladder) for one multiply-high with a precomputed reciprocal of
-`d_{k+1}`. The loop already maintains `d_k` and `step`, so the extra bookkeeping
-fits naturally.
-
-## Optimization ideas grounded in the code
-
-1. **Delta-driven Montgomery updates.** Extend `DivisorScanSession` so it tracks
-   `(Q_k, r_k)` alongside the Montgomery residue and uses the analytic delta
-   formula to derive the next residue. This replaces the per-step powmod in
-   `ExponentRemainderStepper.ComputeNext` with a handful of 64-bit operations.
-   (`MersenneNumberDivisorByDivisorCpuTester.cs`, lines 358-405;
-   `ExponentRemainderStepper.cs`, lines 49-72.)
-2. **Bit-range skipping.** Because `Q_{k+1} / Q_k` is exactly the rational
-   `(2pk + 1)/(2p(k+1) + 1)`, we can predict when `⌊log₂ Q_k⌋` loses a bit and
-   jump the loop counter to the first `k` that crosses a target quotient bound
-   instead of checking each divisor. This is compatible with the existing
-   `allowedMax` guard because it only modifies how we arrive at the stopping
-   divisor. (`MersenneNumberDivisorByDivisorCpuTester.cs`, lines 161-266.)
-3. **Reuse Montgomery metadata.** The loop already calls `MontgomeryDivisorDataCache.Get`
-   for each divisor, but the cache lookup is repeated even though the next
-   divisor is a small increment away. Persisting the previous `MontgomeryDivisorData`
-   together with the `(Q_k, r_k)` tuple lets us skip redundant cache reads when
-   the divisor stays within the hot range. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 223-256.)
-4. **Reciprocal-based delta evaluation.** `DivisorScanSession.TryComputeAnalyticHit` already keeps the `(Q_k, r_k)` tuple
-   per exponent, but the current update loop advances one step at a time and divides by `nextDivisor` through `Int128`
-   arithmetic. (`MersenneNumberDivisorByDivisorCpuTester.cs`, lines 531-594.) We can remove the per-iteration division by
-   storing a 64-bit reciprocal of `d_k` alongside the state and updating it with a single Newton step when the divisor grows
-   by `2p`. Once the reciprocal is known, `Δ_k` follows from a multiply-high of `2p·Q_k - r_k`. This turns the loop into a
-   straight-line sequence of multiplies and subtractions and makes the state update viable even when we unroll multiple
-   increments at once.
-5. **Carry the Montgomery residue forward.** `PrimeDivisorState` already tracks `MontgomeryResidue`, yet the analytic path
-   currently recomputes it after the quotient update by calling `ToMontgomeryResidue`. (`MersenneNumberDivisorByDivisorCpuTester.cs`,
-   lines 602-618.) We can instead reuse the residue by multiplying it with the precomputed `R^2 mod d_k` factor that the
-   cache returns for every divisor. Because the divisor grows deterministically, we only need to fetch the updated Montgomery
-   constants when `d_k` crosses a cache boundary, letting the fast path avoid modular reductions entirely.
-
-These adjustments directly leverage the quotient progression we analysed and
-align with the existing TODO list, giving us a clear path to reduce the number of
-modular exponentiations and cache lookups in the CPU by-divisor path.
-
-## Implementation status
-
-* **Delta-driven Montgomery updates:** Implemented. The CPU session now keeps per-prime quotients, remainders, and last divisors so it can advance the analytic state across consecutive candidates, the reciprocal-corrected loop avoids per-step `UInt128` division, and zero cycle remainders short-circuit to direct Montgomery hits without invoking powmods.
-* **Bit-range skipping:** Implemented. The CPU divisor sweep now predicts when the quotient loses a bit across both 64-bit and wider strides by deriving the next jump with `UInt128` arithmetic,
-  and it only falls back to single-step increments when a projected jump would overshoot the configured limit or exceed `ulong.MaxValue`.
-* **Reuse Montgomery metadata:** Implemented. Each prime state now persists the divisor's `n'`, `R`, and `R^2` factors so resynchronization seeds the exponent stepper directly, and divisor sessions rebuild the Montgomery tuple from the cached state before touching the shared cache, meaning cache lookups only occur when no stored snapshot matches the new divisor.
-* **Reciprocal-based delta evaluation:** Implemented. The analytic updater now retries with a direct 128-bit division when the reciprocal corrections exhaust their tolerance, refreshes the cached reciprocal from that exact quotient, and keeps the progression on the analytic path without rebuilding the state.
-* **Carry the Montgomery residue forward:** Implemented. Each analytic update now normalizes the refreshed remainder and multiplies it by the cached `R^2 mod d` factor immediately, so the exponent stepper always has a Montgomery residue ready without recomputing modular reductions.
-
-
-## Prime-order factoring bottleneck and planned fixes
-
-The Pollard rho fallback in `PrimeOrderCalculator` still performs every quadratic
-polynomial advance by issuing a full-width division. The tight loop in
-`AdvancePolynomial` squares the iterate and takes a `% modulus`, which triggers
-hardware division for each step and dominates the runtime once we test large
-Mersenne divisors.【F:PerfectNumbers.Core/PrimeOrderCalculator.cs†L1180-L1211】
-The by-divisor CPU path consequently spends a measurable portion of its wall
-clock time inside the factorization helper whenever it needs to refresh a cycle
-or validate that a divisor candidate is prime.
-
-To bring this code in line with the Montgomery-first approach we use elsewhere
-we should:
-
-* **Introduce a Montgomery-backed polynomial step.** `PrimeDivisorState` already
-  carries the full set of Montgomery constants (`n'`, `R`, `R^2`) for each
-  divisor we touch in the by-divisor scan, and `DivisorScanSession` rebuilds a
-  `MontgomeryDivisorData` snapshot whenever it seeds the analytic stepper or the
-  exponent synchronizer.【F:PerfectNumbers.Core/Cpu/MersenneNumberDivisorByDivisorCpuTester.cs†L645-L779】【F:PerfectNumbers.Core/Cpu/MersenneNumberDivisorByDivisorCpuTester.cs†L1246-L1398】
-  We can surface the same data to the Pollard rho helper and rewrite
-  `AdvancePolynomial` so it accepts a precomputed reducer `(modulus, n', R^2)`.
-  The update then becomes `x = MontgomerySquareAdd(x, cMontgomery)`—a multiply
-  followed by one Montgomery reduction instead of a general-purpose remainder.
-  This eliminates the `% modulus` call entirely and lets the CPU factorizer reuse
-  the same fast path as the analytic delta updates.
-* **Reuse reciprocal estimates between neighbouring divisors.** The analytic path
-  already stores a reciprocal for each divisor and refines it with Newton steps
-  to divide by `d_k` without hitting the 128-bit fallback.【F:PerfectNumbers.Core/Cpu/MersenneNumberDivisorByDivisorCpuTester.cs†L876-L939】
-  Pollard rho can share the very same multiplier. We can stash the `FastDiv64`
-  multiplier inside the Pollard rho state and update it when `q` grows by `2p`
-  using a single Newton refinement, mirroring `DivideRoundUpUsingReciprocal`.
-  Once the reciprocal is in place, the `(x * x + c) mod q` step reduces to a
-  pair of `UInt128` products and one multiply-high to estimate the quotient—a
-  drop-in use of `ULongExtensions.FastDiv64`.【F:PerfectNumbers.Core/ULongExtensions.cs†L69-L101】
-* **Warm-start the Montgomery context from the monotone `q` stream.** Each scan
-  step increments the divisor by the fixed stride `2p`, so the cached Montgomery
-  tuple only changes slowly. We can therefore hand the next divisor’s
-  `MontgomeryDivisorData` directly to the Pollard rho routine instead of forcing
-  it to recompute the reducer. This is already how `DivisorScanSession` avoids
-  redundant cache lookups; exporting the cached tuple keeps the factorizer in
-  lock-step with the rest of the pipeline.【F:PerfectNumbers.Core/Cpu/MersenneNumberDivisorByDivisorCpuTester.cs†L645-L779】
-
-With these changes the divisor-refresh path would no longer spend most of its
-cycles on integer divisions, and the monotone growth of `q = 2kp + 1` for
-`p ≥ 138,000,000` would guarantee that the reciprocal refinements stay stable
-across thousands of consecutive candidates.
-
-### Pollard rho factoring implementation status
-
-* **Montgomery-backed polynomial step:** Completed. `PollardRhoMontgomeryReducer` now squares and adds in Montgomery space,
-  and the Pollard rho loops in `PrimeOrderCalculator` and `MersenneDivisorCycles` reuse the shared reducer instead of issuing `%` operations.
-* **Reciprocal reuse:** Completed. The reducer tracks a cached FastDiv64 reciprocal, refines it for each monotone modulus, and exposes `AdvanceStandard` so the standard-domain iterates reuse the cached multiplier without `%` or `UInt128` division.
-* **Warm-started Montgomery context:** Completed. The reducer accepts precomputed `MontgomeryDivisorData` snapshots, letting callers seed Pollard rho directly from the cached divisor state when the by-divisor pipeline advances to the next `q`.
-

todo_list.txt

@@ -123,6 +123,7 @@ PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:207:
 PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:214:                // TODO: Remove this no-cycle branch and require on-demand cycle computation (without
 PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:240:            // TODO: Replace this linear increment with the batched divisor-cycle walker validated in the
 PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:262:                : prime.Pow2MontgomeryMod(divisorData); // TODO: Switch to the upcoming ProcessEightBitWindows helper once the
+PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:283:        // TODO: Replace this modulo with the ring-buffer style counter (subtract loop) used in the fast CLI
 PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:356:                // TODO: Replace this guard with an on-demand CPU/GPU cycle computation path that skips
 PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:396:            // TODO: Remove this no-cycle fallback once divisor cycles are mandatory; the per-prime pow2 ladder here
 PerfectNumbers.Core\IMersenneNumberDivisorByDivisorTester.cs:7:    bool UseDivisorCycles { get; set; } // TODO: Remove the setter once divisor cycle usage becomes mandatory so all implementations always leverage the cached cycles.
@@ -266,6 +267,7 @@ todo_list.txt:122:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTeste
 todo_list.txt:123:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:214:                // TODO: Remove this no-cycle branch and require on-demand cycle computation (without
 todo_list.txt:124:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:240:            // TODO: Replace this linear increment with the batched divisor-cycle walker validated in the
 todo_list.txt:125:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:262:                : prime.Pow2MontgomeryMod(divisorData); // TODO: Switch to the upcoming ProcessEightBitWindows helper once the
+todo_list.txt:126:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:283:        // TODO: Replace this modulo with the ring-buffer style counter (subtract loop) used in the fast CLI
 todo_list.txt:127:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:356:                // TODO: Replace this guard with an on-demand CPU/GPU cycle computation path that skips
 todo_list.txt:128:PerfectNumbers.Core\Cpu\MersenneNumberDivisorByDivisorCpuTester.cs:396:            // TODO: Remove this no-cycle fallback once divisor cycles are mandatory; the per-prime pow2 ladder here
 todo_list.txt:129:PerfectNumbers.Core\IMersenneNumberDivisorByDivisorTester.cs:7:    bool UseDivisorCycles { get; set; } // TODO: Remove the setter once divisor cycle usage becomes mandatory so all implementations always leverage the cached cycles.